lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

regulator: of: Fix refcount leak bug in of_get_regulation_constraints()

Browse Source 
[ Upstream commit 66efb665cd5ad69b27dca8571bf89fc6b9c628a4 ]

We should call the of_node_put() for the reference returned by
of_get_child_by_name() which has increased the refcount.

Fixes: 40e20d68bb ("regulator: of: Add support for parsing regulator_state for suspend state")
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220715111027.391032-1-windhl@126.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Liang He 2022-07-15 19:10:27 +08:00 committed by Greg Kroah-Hartman
parent 52e1f85bf7
commit 35f9e861d9
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/regulator/of_regulator.c
View File

@ -206,8 +206,12 @@ static int of_get_regulation_constraints(struct device *dev,
} }
suspend_np = of_get_child_by_name(np, regulator_states[i]); suspend_np = of_get_child_by_name(np, regulator_states[i]);
if (!suspend_np || !suspend_state) if (!suspend_np)
continue; continue;
if (!suspend_state) {
of_node_put(suspend_np);
continue;
}
if (!of_property_read_u32(suspend_np, "regulator-mode", if (!of_property_read_u32(suspend_np, "regulator-mode",
&pval)) { &pval)) {