lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: i2c: ad5820: Fix error path

Browse Source 
[ Upstream commit 9fce241660f37d9e95e93c0ae6fba8cfefa5797b ]

Error path seems to be swaped. Fix the order and provide some meaningful
names.

Fixes: bee3d51156 ("[media] ad5820: Add driver for auto-focus coil")
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Ricardo Ribalda 2022-09-21 13:38:00 +02:00 committed by Greg Kroah-Hartman
parent e8e2da03c2
commit 3f2384f09b
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/media/i2c/ad5820.c
View File

@ -314,18 +314,18 @@ static int ad5820_probe(struct i2c_client *client,
ret = media_entity_pads_init(&coil->subdev.entity, 0, NULL); ret = media_entity_pads_init(&coil->subdev.entity, 0, NULL);
if (ret < 0) if (ret < 0)
goto cleanup2; goto clean_mutex;
ret = v4l2_async_register_subdev(&coil->subdev); ret = v4l2_async_register_subdev(&coil->subdev);
if (ret < 0) if (ret < 0)
goto cleanup; goto clean_entity;
return ret; return ret;
cleanup2: clean_entity:
mutex_destroy(&coil->power_lock);
cleanup:
media_entity_cleanup(&coil->subdev.entity); media_entity_cleanup(&coil->subdev.entity);
clean_mutex:
mutex_destroy(&coil->power_lock);
return ret; return ret;
} }