lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Remove unused hdd_softap_register_sta() params

Browse Source 
The parameters to function hdd_softap_register_sta() currently include
ucastSig and bcastSig. These "signature" parameters date back to a
previous version of the driver that used these signatures to
synchronize the data plane with the control plane. However the current
version of the driver does not use these parameters, so remove them as
part of the plan to completely remove these signatures from throughout
the driver.

Change-Id: I1f1f1fb1ef553d36ba0f4902ab29b2b4852ae5ca
CRs-Fixed: 2200356
This commit is contained in:
Jeff Johnson 2018-03-01 14:27:38 -08:00 committed by nshrivas
parent 9399ffc507
commit 3f6c89f77d
3 changed files with 17 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
core/hdd/inc/wlan_hdd_softap_tx_rx.h
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2014-2017 The Linux Foundation. All rights reserved.
* Copyright (c) 2014-2018 The Linux Foundation. All rights reserved.
*
* Previously licensed under the ISC license by Qualcomm Atheros, Inc.
*
@ -75,14 +75,25 @@ QDF_STATUS hdd_softap_rx_mul_packet_cbk(void *cds_context,
QDF_STATUS hdd_softap_deregister_sta(struct hdd_adapter *adapter,
uint8_t staId);
/**
* hdd_softap_register_sta() - Register a SoftAP STA
* @adapter: pointer to adapter context
* @fAuthRequired: is additional authentication required?
* @fPrivacyBit: should 802.11 privacy bit be set?
* @staId: station ID assigned to this station
* @pPeerMacAddress: station MAC address
* @fWmmEnabled: is WMM enabled for this STA?
*
* Return: QDF_STATUS_SUCCESS on success, QDF_STATUS_E_** on error
*/
QDF_STATUS hdd_softap_register_sta(struct hdd_adapter *adapter,
bool fAuthRequired,
bool fPrivacyBit,
uint8_t staId,
uint8_t ucastSig,
uint8_t bcastSig,
struct qdf_mac_addr *pPeerMacAddress,
bool fWmmEnabled);
QDF_STATUS hdd_softap_register_bc_sta(struct hdd_adapter *adapter,
bool fPrivacyBit);
QDF_STATUS hdd_softap_deregister_bc_sta(struct hdd_adapter *adapter);

4
core/hdd/src/wlan_hdd_hostapd.c
View File

@ -2131,7 +2131,7 @@ QDF_STATUS hdd_hostapd_sap_event_cb(tpSap_Event pSapEvent,
adapter,
true,
ap_ctx->privacy,
event->staId, 0, 0,
event->staId,
(struct qdf_mac_addr *)
wrqu.addr.sa_data,
event->wmmEnabled);
@ -2144,7 +2144,7 @@ QDF_STATUS hdd_hostapd_sap_event_cb(tpSap_Event pSapEvent,
adapter,
false,
ap_ctx->privacy,
event->staId, 0, 0,
event->staId,
(struct qdf_mac_addr *)
wrqu.addr.sa_data,
event->wmmEnabled);

17
core/hdd/src/wlan_hdd_softap_tx_rx.c
View File

@ -882,25 +882,10 @@ QDF_STATUS hdd_softap_deregister_sta(struct hdd_adapter *adapter,
return qdf_status;
}
/**
* hdd_softap_register_sta() - Register a SoftAP STA
* @adapter: pointer to adapter context
* @fAuthRequired: is additional authentication required?
* @fPrivacyBit: should 802.11 privacy bit be set?
* @staId: station ID assigned to this station
* @ucastSig: unicast security signature
* @bcastSig: broadcast security signature
* @pPeerMacAddress: station MAC address
* @fWmmEnabled: is WMM enabled for this STA?
*
* Return: QDF_STATUS_SUCCESS on success, QDF_STATUS_E_** on error
*/
QDF_STATUS hdd_softap_register_sta(struct hdd_adapter *adapter,
bool fAuthRequired,
bool fPrivacyBit,
uint8_t staId,
uint8_t ucastSig,
uint8_t bcastSig,
struct qdf_mac_addr *pPeerMacAddress,
bool fWmmEnabled)
{
@ -1014,7 +999,7 @@ QDF_STATUS hdd_softap_register_bc_sta(struct hdd_adapter *adapter,
qdf_status =
hdd_softap_register_sta(adapter, false, fPrivacyBit,
ap_ctx->broadcast_sta_id,
0, 1, &broadcastMacAddr, 0);
&broadcastMacAddr, 0);
return qdf_status;
}