lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

i2c: img-scb: fix reference leak when pm_runtime_get_sync fails

Browse Source 
[ Upstream commit 223125e37af8a641ea4a09747a6a52172fc4b903 ]

The PM reference count is not expected to be incremented on
return in functions img_i2c_xfer and img_i2c_init.

However, pm_runtime_get_sync will increment the PM reference
count even failed. Forgetting to putting operation will result
in a reference leak here.

Replace it with pm_runtime_resume_and_get to keep usage
counter balanced.

Fixes: 93222bd9b9 ("i2c: img-scb: Add runtime PM")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Qinglang Miao 2020-12-01 17:31:39 +08:00 committed by Greg Kroah-Hartman
parent ed016b7701
commit 4734c4b1d9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/i2c/busses/i2c-img-scb.c
View File

@ -1057,7 +1057,7 @@ static int img_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
atomic = true; atomic = true;
} }
ret = pm_runtime_get_sync(adap->dev.parent); ret = pm_runtime_resume_and_get(adap->dev.parent);
if (ret < 0) if (ret < 0)
return ret; return ret;
@ -1158,7 +1158,7 @@ static int img_i2c_init(struct img_i2c *i2c)
u32 rev; u32 rev;
int ret; int ret;
ret = pm_runtime_get_sync(i2c->adap.dev.parent); ret = pm_runtime_resume_and_get(i2c->adap.dev.parent);
if (ret < 0) if (ret < 0)
return ret; return ret;