lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hwmon: (pmbus) Add Vin unit off handling

Browse Source 
[ Upstream commit a5436af598779219b375c1977555c82def1c35d0 ]

If there is an input undervoltage fault, reported in STATUS_INPUT
command response, there is quite likely a "Unit Off For Insufficient
Input Voltage" condition as well.

Add a constant for bit 3 of STATUS_INPUT. Update the Vin limit
attributes to include both bits in the mask for clearing faults.

If an input undervoltage fault occurs, causing a unit off for
insufficient input voltage, but the unit is off bit is not cleared, the
STATUS_WORD will not be updated to clear the input fault condition.
Including the unit is off bit (bit 3) allows for the input fault
condition to completely clear.

Signed-off-by: Brandon Wyman <bjwyman@gmail.com>
Link: https://lore.kernel.org/r/20220317232123.2103592-1-bjwyman@gmail.com
Fixes: b4ce237b7f ("hwmon: (pmbus) Introduce infrastructure to detect sensors and limit registers")
[groeck: Dropped unnecessary ()]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Brandon Wyman 2022-03-17 23:21:23 +00:00 committed by Greg Kroah-Hartman
parent acba286182
commit 4c0173521d
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/hwmon/pmbus/pmbus.h
View File

@ -292,6 +292,7 @@ enum pmbus_fan_mode { percent = 0, rpm };
/* /*
* STATUS_VOUT, STATUS_INPUT * STATUS_VOUT, STATUS_INPUT
*/ */
#define PB_VOLTAGE_VIN_OFF BIT(3)
#define PB_VOLTAGE_UV_FAULT BIT(4) #define PB_VOLTAGE_UV_FAULT BIT(4)
#define PB_VOLTAGE_UV_WARNING BIT(5) #define PB_VOLTAGE_UV_WARNING BIT(5)
#define PB_VOLTAGE_OV_WARNING BIT(6) #define PB_VOLTAGE_OV_WARNING BIT(6)

2
drivers/hwmon/pmbus/pmbus_core.c
View File

@ -1324,7 +1324,7 @@ static const struct pmbus_limit_attr vin_limit_attrs[] = {
.reg = PMBUS_VIN_UV_FAULT_LIMIT, .reg = PMBUS_VIN_UV_FAULT_LIMIT,
.attr = "lcrit", .attr = "lcrit",
.alarm = "lcrit_alarm", .alarm = "lcrit_alarm",
.sbit = PB_VOLTAGE_UV_FAULT, .sbit = PB_VOLTAGE_UV_FAULT | PB_VOLTAGE_VIN_OFF,
}, { }, {
.reg = PMBUS_VIN_OV_WARN_LIMIT, .reg = PMBUS_VIN_OV_WARN_LIMIT,
.attr = "max", .attr = "max",