lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ALSA: firewire-digi00x: prevent potential use after free

Browse Source 
[ Upstream commit c0e72058d5e21982e61a29de6b098f7c1f0db498 ]

This code was supposed to return an error code if init_stream()
failed, but it instead freed dg00x->rx_stream and returned success.
This potentially leads to a use after free.

Fixes: 9a08067ec3 ("ALSA: firewire-digi00x: support AMDTP domain")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/c224cbd5-d9e2-4cd4-9bcf-2138eb1d35c6@kili.mountain
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dan Carpenter 2023-05-09 12:07:11 +03:00 committed by Greg Kroah-Hartman
parent b22b514209
commit 5009aead17
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sound/firewire/digi00x/digi00x-stream.c
View File

@ -259,8 +259,10 @@ int snd_dg00x_stream_init_duplex(struct snd_dg00x *dg00x)
return err; return err;
err = init_stream(dg00x, &dg00x->tx_stream); err = init_stream(dg00x, &dg00x->tx_stream);
if (err < 0) if (err < 0) {
destroy_stream(dg00x, &dg00x->rx_stream); destroy_stream(dg00x, &dg00x->rx_stream);
return err;
}
err = amdtp_domain_init(&dg00x->domain); err = amdtp_domain_init(&dg00x->domain);
if (err < 0) { if (err < 0) {