lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ASoC: Intel: Skylake: mem leak in skl register function

Browse Source 
[ Upstream commit f8ba14b780273fd290ddf7ee0d7d7decb44cc365 ]

skl_platform_register() uses krealloc. When krealloc is fail,
then previous memory is not freed. The leak is also when soc
component registration failed.

Signed-off-by: Kamil Duljas <kamil.duljas@gmail.com>
Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Link: https://lore.kernel.org/r/20231116224112.2209-2-kamil.duljas@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Kamil Duljas 2023-11-16 23:41:13 +01:00 committed by Greg Kroah-Hartman
parent 81610106fd
commit 61c1e46fb8
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sound/soc/intel/skylake/skl-pcm.c
View File

@ -1492,6 +1492,7 @@ int skl_platform_register(struct device *dev)
dais = krealloc(skl->dais, sizeof(skl_fe_dai) + dais = krealloc(skl->dais, sizeof(skl_fe_dai) +
sizeof(skl_platform_dai), GFP_KERNEL); sizeof(skl_platform_dai), GFP_KERNEL);
if (!dais) { if (!dais) {
kfree(skl->dais);
ret = -ENOMEM; ret = -ENOMEM;
goto err; goto err;
} }
@ -1504,8 +1505,10 @@ int skl_platform_register(struct device *dev)
ret = devm_snd_soc_register_component(dev, &skl_component, ret = devm_snd_soc_register_component(dev, &skl_component,
skl->dais, num_dais); skl->dais, num_dais);
if (ret) if (ret) {
kfree(skl->dais);
dev_err(dev, "soc component registration failed %d\n", ret); dev_err(dev, "soc component registration failed %d\n", ret);
}
err: err:
return ret; return ret;
} }