lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: s5p-mfc: Clear workbit to handle error condition

Browse Source 
[ Upstream commit d3f3c2fe54e30b0636496d842ffbb5ad3a547f9b ]

During error on CLOSE_INSTANCE command, ctx_work_bits was not getting
cleared. During consequent mfc execution NULL pointer dereferencing of
this context led to kernel panic. This patch fixes this issue by making
sure to clear ctx_work_bits always.

Fixes: 818cd91ab8 ("[media] s5p-mfc: Extract open/close MFC instance commands")
Cc: stable@vger.kernel.org
Cc: linux-fsd@tesla.com
Signed-off-by: Smitha T Murthy <smitha.t@samsung.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Smitha T Murthy 2022-09-07 16:02:26 +05:30 committed by Greg Kroah-Hartman
parent 4a52a1a3ea
commit 640075400c
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
View File

@ -468,8 +468,10 @@ void s5p_mfc_close_mfc_inst(struct s5p_mfc_dev *dev, struct s5p_mfc_ctx *ctx)
s5p_mfc_hw_call(dev->mfc_ops, try_run, dev); s5p_mfc_hw_call(dev->mfc_ops, try_run, dev);
/* Wait until instance is returned or timeout occurred */ /* Wait until instance is returned or timeout occurred */
if (s5p_mfc_wait_for_done_ctx(ctx, if (s5p_mfc_wait_for_done_ctx(ctx,
S5P_MFC_R2H_CMD_CLOSE_INSTANCE_RET, 0)) S5P_MFC_R2H_CMD_CLOSE_INSTANCE_RET, 0)){
clear_work_bit_irqsave(ctx);
mfc_err("Err returning instance\n"); mfc_err("Err returning instance\n");
}
/* Free resources */ /* Free resources */
s5p_mfc_hw_call(dev->mfc_ops, release_codec_buffers, ctx); s5p_mfc_hw_call(dev->mfc_ops, release_codec_buffers, ctx);