lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drivers: mcb: fix resource leak in mcb_probe()

Browse Source 
[ Upstream commit d7237462561fcd224fa687c56ccb68629f50fc0d ]

When probe hook function failed in mcb_probe(), it doesn't put the device.
Compiled test only.

Fixes: 7bc364097a ("mcb: Acquire reference to device in probe")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Signed-off-by: Johannes Thumshirn <jth@kernel.org>
Link: https://lore.kernel.org/r/9f87de36bfb85158b506cb78c6fc9db3f6a3bad1.1669624063.git.johannes.thumshirn@wdc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Zhengchao Shao 2022-12-02 01:38:49 -08:00 committed by Greg Kroah-Hartman
parent 80dc47e751
commit 68e54d9ee8
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/mcb/mcb-core.c
View File

@ -71,8 +71,10 @@ static int mcb_probe(struct device *dev)
get_device(dev); get_device(dev);
ret = mdrv->probe(mdev, found_id); ret = mdrv->probe(mdev, found_id);
if (ret) if (ret) {
module_put(carrier_mod); module_put(carrier_mod);
put_device(dev);
}
return ret; return ret;
} }