lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Change check for wma_is_vdev_started() to WLAN_VDEV_S_UP

Browse Source 
When running WHUNT test case for SET NUD STATS vendor command,
wma_set_arp_req_stats is supposed to be sent to FW but it fails to send
due to the check in wma_is_vdev_started(), which is currently checking
if the vdev state is WLAN_VDEV_S_START, instead of WLAN_VDEV_S_UP, thus
allowing vdev state WLAN_VDEV_S_UP to still continue when it is not
started. Hence, change the check to WLAN_VDEV_S_UP to provide proper check.

Change-Id: Ifae00ff26a27df92cd4d09047c326bcccfdbf602
CRs-Fixed: 2651406
This commit is contained in:
Alan Chen 2020-03-27 12:44:51 -07:00 committed by nshrivas
parent 433881962b
commit 6a2c5953c1
3 changed files with 1 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
core/wma/inc/wma_internal.h
View File

@ -1809,16 +1809,6 @@ int wma_fill_beacon_interval_reset_req(tp_wma_handle wma, uint8_t vdev_id,
*/
bool wma_is_vdev_valid(uint32_t vdev_id);
/*
* wma_is_vdev_started() - check whether vdev is started or not
* @vdev: pointer to vdev object
*
* This function verifies the vdev is started nor not
*
* Return: 'true' if vdev is started else 'false'
*/
bool wma_is_vdev_started(struct wlan_objmgr_vdev *vdev);
/**
* wma_vdev_obss_detection_info_handler - event handler to handle obss detection
* @handle: the wma handle

8
core/wma/src/wma_dev_if.c
View File

@ -1356,14 +1356,6 @@ bool wma_is_vdev_valid(uint32_t vdev_id)
return wma_handle->interfaces[vdev_id].vdev_active;
}
bool wma_is_vdev_started(struct wlan_objmgr_vdev *vdev)
{
if (WLAN_VDEV_S_START == wlan_vdev_mlme_get_state(vdev))
return true;
else
return false;
}
/**
* wma_vdev_set_param() - set per vdev params in fw
* @wmi_handle: wmi handle

2
core/wma/src/wma_main.c
View File

@ -7619,7 +7619,7 @@ static void wma_set_arp_req_stats(WMA_HANDLE handle,
return;
}
if (!wma_is_vdev_started(vdev)) {
if (!wma_is_vdev_up(req_buf->vdev_id)) {
WMA_LOGD("vdev id:%d is not started", req_buf->vdev_id);
goto release_ref;
}