lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in probe

Browse Source 
commit dd218433f2b635d97e8fda3eed047151fd528ce4 upstream.

The devm_memremap() function returns error pointers.
It never returns NULL. Fix the check.

Fixes: 7ca5ce8965 ("firmware: add Intel Stratix10 service layer driver")
Cc: stable@vger.kernel.org
Signed-off-by: Wang Ming <machel@vivo.com>
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
Link: https://lore.kernel.org/r/20230727193750.983795-1-dinguyen@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wang Ming 2023-07-27 14:37:50 -05:00 committed by Greg Kroah-Hartman
parent bee7f3a494
commit 6b701dab19
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/firmware/stratix10-svc.c
View File

@ -616,7 +616,7 @@ svc_create_memory_pool(struct platform_device *pdev,
paddr = begin; paddr = begin;
size = end - begin; size = end - begin;
va = devm_memremap(dev, paddr, size, MEMREMAP_WC); va = devm_memremap(dev, paddr, size, MEMREMAP_WC);
if (!va) { if (IS_ERR(va)) {
dev_err(dev, "fail to remap shared memory\n"); dev_err(dev, "fail to remap shared memory\n");
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
} }