lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Remove wlan_sap_set_pre_cac_status() handle param

Browse Source 
Function wlan_sap_set_pre_cac_status() currently takes as one
parameter a tHalHandle handle.  This handle is converted into a MAC
context pointer. That MAC context pointer is then tested for NULL but
is otherwise unused.  Since the MAC context, and hence the handle, are
unnecessary, remove them.

This is part of an ongoing campaign to remove or replace all instances
of tHalHandle.

Change-Id: I1c280be8c7c65a28267a9ab38d76fb8aa94e48af
CRs-Fixed: 2347653
This commit is contained in:
Jeff Johnson 2018-10-30 07:18:49 -07:00 committed by nshrivas
parent 2febb64e8f
commit 6ccbec1f48
3 changed files with 4 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/hdd/src/wlan_hdd_sap_cond_chan_switch.c
View File

@ -48,7 +48,7 @@ static int wlan_hdd_set_pre_cac_status(struct hdd_adapter *pre_cac_adapter,
QDF_STATUS ret;
ret = wlan_sap_set_pre_cac_status(
WLAN_HDD_GET_SAP_CTX_PTR(pre_cac_adapter), status, handle);
WLAN_HDD_GET_SAP_CTX_PTR(pre_cac_adapter), status);
if (QDF_IS_STATUS_ERROR(ret))
return -EINVAL;

5
core/sap/inc/sap_api.h
View File

@ -951,14 +951,13 @@ QDF_STATUS wlan_sap_update_next_channel(struct sap_context *sap_ctx,
* wlan_sap_set_pre_cac_status() - Set the pre cac status
* @sap_ctx: SAP context
* @status: Status of pre cac
* @handle: Global MAC handle
*
* Sets the pre cac status in the MAC context and updates the state
* Updates the state of pre cac in the SAP context
*
* Return: QDF_STATUS
*/
QDF_STATUS wlan_sap_set_pre_cac_status(struct sap_context *sap_ctx,
bool status, tHalHandle handle);
bool status);
/**
* wlan_sap_set_chan_before_pre_cac() - Save the channel before pre cac

10
core/sap/src/sap_module.c
View File

@ -1494,16 +1494,8 @@ QDF_STATUS wlan_sap_update_next_channel(struct sap_context *sap_ctx,
#ifdef FEATURE_SAP_COND_CHAN_SWITCH
QDF_STATUS wlan_sap_set_pre_cac_status(struct sap_context *sap_ctx,
bool status, tHalHandle handle)
bool status)
{
tpAniSirGlobal mac_ctx = PMAC_STRUCT(handle);
if (!mac_ctx) {
QDF_TRACE(QDF_MODULE_ID_SAP, QDF_TRACE_LEVEL_ERROR,
"%s: Invalid mac pointer", __func__);
return QDF_STATUS_E_FAULT;
}
if (!sap_ctx) {
QDF_TRACE(QDF_MODULE_ID_SAP, QDF_TRACE_LEVEL_ERROR,
"%s: Invalid SAP pointer", __func__);