lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iocost: bump up default latency targets for hard disks

Browse Source 
The default hard disk param sets latency targets at 50ms.  As the
default target percentiles are zero, these don't directly regulate
vrate; however, they're still used to calculate the period length -
100ms in this case.

This is excessively low.  A SATA drive with QD32 saturated with random
IOs can easily reach avg completion latency of several hundred msecs.
A period duration which is substantially lower than avg completion
latency can lead to wildly fluctuating vrate.

Let's bump up the default latency targets to 250ms so that the period
duration is sufficiently long.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Tejun Heo 2019-09-25 16:03:35 -07:00 committed by Jens Axboe
parent 7cd806a9a9
commit 7afcccafa5
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
block/blk-iocost.c
View File

@ -529,8 +529,8 @@ struct iocg_wake_ctx {
static const struct ioc_params autop[] = { static const struct ioc_params autop[] = {
[AUTOP_HDD] = { [AUTOP_HDD] = {
.qos = { .qos = {
[QOS_RLAT] = 50000, /* 50ms */ [QOS_RLAT] = 250000, /* 250ms */
[QOS_WLAT] = 50000, [QOS_WLAT] = 250000,
[QOS_MIN] = VRATE_MIN_PPM, [QOS_MIN] = VRATE_MIN_PPM,
[QOS_MAX] = VRATE_MAX_PPM, [QOS_MAX] = VRATE_MAX_PPM,
}, },