lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cavium: Fix return values of the probe function

Browse Source 
[ Upstream commit c69b2f46876825c726bd8a97c7fa852d8932bc32 ]

During the process of driver probing, the probe function should return < 0
for failure, otherwise, the kernel will treat value > 0 as success.

Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Zheyu Ma 2021-10-18 14:32:57 +00:00 committed by Greg Kroah-Hartman
parent 9f5fd5aab8
commit 82005afbb3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/ethernet/cavium/thunder/nicvf_main.c
View File

@ -1226,7 +1226,7 @@ static int nicvf_register_misc_interrupt(struct nicvf *nic)
if (ret < 0) { if (ret < 0) {
netdev_err(nic->netdev, netdev_err(nic->netdev,
"Req for #%d msix vectors failed\n", nic->num_vec); "Req for #%d msix vectors failed\n", nic->num_vec);
return 1; return ret;
} }
sprintf(nic->irq_name[irq], "%s Mbox", "NICVF"); sprintf(nic->irq_name[irq], "%s Mbox", "NICVF");
@ -1245,7 +1245,7 @@ static int nicvf_register_misc_interrupt(struct nicvf *nic)
if (!nicvf_check_pf_ready(nic)) { if (!nicvf_check_pf_ready(nic)) {
nicvf_disable_intr(nic, NICVF_INTR_MBOX, 0); nicvf_disable_intr(nic, NICVF_INTR_MBOX, 0);
nicvf_unregister_interrupts(nic); nicvf_unregister_interrupts(nic);
return 1; return -EIO;
} }
return 0; return 0;