lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mfd: dln2: Fix double put in dln2_probe

Browse Source 
[ Upstream commit 759c409bc5fc496cbc22cd0b392d3cbb0c0e23eb ]

The dln2_free() already contains usb_put_dev(). Therefore,
the redundant usb_put_dev() before dln2_free() may lead to
a double free.

Fixes: 96da8f148396 ("mfd: dln2: Fix memory leak in dln2_probe()")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20230925024134.9683-1-dinghao.liu@zju.edu.cn
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dinghao Liu 2023-09-25 10:41:33 +08:00 committed by Greg Kroah-Hartman
parent b843d2cd13
commit 87b1ee831d
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/mfd/dln2.c
View File

@ -797,7 +797,6 @@ out_stop_rx:
dln2_stop_rx_urbs(dln2); dln2_stop_rx_urbs(dln2);
out_free: out_free:
usb_put_dev(dln2->usb_dev);
dln2_free(dln2); dln2_free(dln2);
return ret; return ret;