lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Add NULL check for tx_rx_hist

Browse Source 
Currently, we are updating tx_rx_hist without performing a NULL check.
There can be the case where the tx_rx_hist is freed and we are trying to
de-reference the tx_rx_hist, which will cause the NULL pointer dereference
issue.

Fix is to add NULL check for tx_rx_hist before dereferencing it.

Change-Id: I0c298f1c86dd86b6ac987c005ed19b20933ffba8
CRs-Fixed: 3196312
This commit is contained in:
Amit Mehta 2022-05-12 17:49:07 +05:30
parent 110644cec7
commit 94962f3d04
1 changed files with 18 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
core/hdd/src/wlan_hdd_main.c
View File

@ -10422,18 +10422,24 @@ static void hdd_pld_request_bus_bandwidth(struct hdd_context *hdd_ctx,
is_tx_pm_qos_high,
cpumask_pr_args(&pm_qos_cpu_mask_tx));
hdd_ctx->hdd_txrx_hist[index].next_tx_level = next_tx_level;
hdd_ctx->hdd_txrx_hist[index].next_rx_level = next_rx_level;
hdd_ctx->hdd_txrx_hist[index].is_rx_pm_qos_high =
is_rx_pm_qos_high;
hdd_ctx->hdd_txrx_hist[index].is_tx_pm_qos_high =
is_tx_pm_qos_high;
hdd_ctx->hdd_txrx_hist[index].next_vote_level = next_vote_level;
hdd_ctx->hdd_txrx_hist[index].interval_rx = rx_packets;
hdd_ctx->hdd_txrx_hist[index].interval_tx = tx_packets;
hdd_ctx->hdd_txrx_hist[index].qtime = qdf_get_log_timestamp();
hdd_ctx->hdd_txrx_hist_idx++;
hdd_ctx->hdd_txrx_hist_idx &= NUM_TX_RX_HISTOGRAM_MASK;
if (hdd_ctx->hdd_txrx_hist) {
hdd_ctx->hdd_txrx_hist[index].next_tx_level =
next_tx_level;
hdd_ctx->hdd_txrx_hist[index].next_rx_level =
next_rx_level;
hdd_ctx->hdd_txrx_hist[index].is_rx_pm_qos_high =
is_rx_pm_qos_high;
hdd_ctx->hdd_txrx_hist[index].is_tx_pm_qos_high =
is_tx_pm_qos_high;
hdd_ctx->hdd_txrx_hist[index].next_vote_level =
next_vote_level;
hdd_ctx->hdd_txrx_hist[index].interval_rx = rx_packets;
hdd_ctx->hdd_txrx_hist[index].interval_tx = tx_packets;
hdd_ctx->hdd_txrx_hist[index].qtime =
qdf_get_log_timestamp();
hdd_ctx->hdd_txrx_hist_idx++;
hdd_ctx->hdd_txrx_hist_idx &= NUM_TX_RX_HISTOGRAM_MASK;
}
/* Clear all the mask if no silver/gold vote is required */
if (next_vote_level < PLD_BUS_WIDTH_MEDIUM)