lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nios2: traced syscall does need to check the syscall number

Browse Source 
commit 25ba820ef36bdbaf9884adeac69b6e1821a7df76 upstream.

all checks done before letting the tracer modify the register
state are worthless...

Fixes: 82ed08dd1b ("nios2: Exception handling")
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Al Viro 2022-08-08 16:07:21 +01:00 committed by Greg Kroah-Hartman
parent 73c0883732
commit 9e9151768b
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
arch/nios2/kernel/entry.S
View File

@ -255,9 +255,9 @@ traced_system_call:
ldw r6, PT_R6(sp) ldw r6, PT_R6(sp)
ldw r7, PT_R7(sp) ldw r7, PT_R7(sp)
/* Fetch the syscall function, we don't need to check the boundaries /* Fetch the syscall function. */
* since this is already done. movui r1, __NR_syscalls
*/ bgeu r2, r1, traced_invsyscall
slli r1, r2, 2 slli r1, r2, 2
movhi r11,%hiadj(sys_call_table) movhi r11,%hiadj(sys_call_table)
add r1, r1, r11 add r1, r1, r11
@ -287,6 +287,11 @@ end_translate_rc_and_ret2:
RESTORE_SWITCH_STACK RESTORE_SWITCH_STACK
br ret_from_exception br ret_from_exception
/* If the syscall number was invalid return ENOSYS */
traced_invsyscall:
movi r2, -ENOSYS
br translate_rc_and_ret2
Luser_return: Luser_return:
GET_THREAD_INFO r11 /* get thread_info pointer */ GET_THREAD_INFO r11 /* get thread_info pointer */
ldw r10, TI_FLAGS(r11) /* get thread_info->flags */ ldw r10, TI_FLAGS(r11) /* get thread_info->flags */