lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clk: samsung: Fix memory leak in _samsung_clk_register_pll()

Browse Source 
[ Upstream commit 5174e5b0d1b669a489524192b6adcbb3c54ebc72 ]

If clk_register() fails, @pll->rate_table may have allocated memory by
kmemdup(), so it needs to be freed, otherwise will cause memory leak
issue, this patch fixes it.

Fixes: 3ff6e0d8d6 ("clk: samsung: Add support to register rate_table for samsung plls")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Link: https://lore.kernel.org/r/20221123032015.63980-1-xiujianfeng@huawei.com
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Xiu Jianfeng 2022-11-23 11:20:15 +08:00 committed by Greg Kroah-Hartman
parent 7a2c66429b
commit a00b4e0fa2
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/clk/samsung/clk-pll.c
View File

@ -1390,6 +1390,7 @@ static void __init _samsung_clk_register_pll(struct samsung_clk_provider *ctx,
if (ret) { if (ret) {
pr_err("%s: failed to register pll clock %s : %d\n", pr_err("%s: failed to register pll clock %s : %d\n",
__func__, pll_clk->name, ret); __func__, pll_clk->name, ret);
kfree(pll->rate_table);
kfree(pll); kfree(pll);
return; return;
} }