lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf: arm_dsu: Fix hotplug callback leak in dsu_pmu_init()

Browse Source 
[ Upstream commit facafab7611f7b872c6b9eeaff53461ef11f482e ]

dsu_pmu_init() won't remove the callback added by cpuhp_setup_state_multi()
when platform_driver_register() failed. Remove the callback by
cpuhp_remove_multi_state() in fail path.

Similar to the handling of arm_ccn_init() in commit 26242b3300 ("bus:
arm-ccn: Prevent hotplug callback leak")

Fixes: 7520fa9924 ("perf: ARM DynamIQ Shared Unit PMU support")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20221115070207.32634-2-yuancan@huawei.com
Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Yuan Can 2022-11-15 07:02:06 +00:00 committed by Greg Kroah-Hartman
parent 1e9186d628
commit af2256d778
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/perf/arm_dsu_pmu.c
View File

@ -816,7 +816,11 @@ static int __init dsu_pmu_init(void)
if (ret < 0) if (ret < 0)
return ret; return ret;
dsu_pmu_cpuhp_state = ret; dsu_pmu_cpuhp_state = ret;
return platform_driver_register(&dsu_pmu_driver); ret = platform_driver_register(&dsu_pmu_driver);
if (ret)
cpuhp_remove_multi_state(dsu_pmu_cpuhp_state);
return ret;
} }
static void __exit dsu_pmu_exit(void) static void __exit dsu_pmu_exit(void)