lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: typec: Check for ops->exit instead of ops->enter in altmode_exit

Browse Source 
[ Upstream commit b6ddd180e3d9f92c1e482b3cdeec7dda086b1341 ]

typec_altmode_exit checks if ops->enter is not NULL but then calls
ops->exit a few lines below. Fix that and check for the function
pointer it's about to call instead.

Fixes: 8a37d87d72 ("usb: typec: Bus type for alternate modes")
Signed-off-by: Sven Peter <sven@svenpeter.dev>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20221114165924.33487-1-sven@svenpeter.dev
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Sven Peter 2022-11-14 17:59:24 +01:00 committed by Greg Kroah-Hartman
parent a45ba33d39
commit af4049a2ff
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/usb/typec/bus.c
View File

@ -126,7 +126,7 @@ int typec_altmode_exit(struct typec_altmode *adev)
if (!adev || !adev->active) if (!adev || !adev->active)
return 0; return 0;
if (!pdev->ops || !pdev->ops->enter) if (!pdev->ops || !pdev->ops->exit)
return -EOPNOTSUPP; return -EOPNOTSUPP;
/* Moving to USB Safe State */ /* Moving to USB Safe State */