lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: musb: tusb6010: uninitialized data in tusb_fifo_write_unaligned()

Browse Source 
commit 517c7bf99bad3d6b9360558414aae634b7472d80 upstream.

This is writing to the first 1 - 3 bytes of "val" and then writing all
four bytes to musb_writel().  The last byte is always going to be
garbage.  Zero out the last bytes instead.

Fixes: 550a7375fe ("USB: Add MUSB and TUSB support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210916135737.GI25094@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2021-09-16 16:57:37 +03:00 committed by Greg Kroah-Hartman
parent b8c8060651
commit b1f6efa27b
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/usb/musb/tusb6010.c
View File

@ -190,6 +190,7 @@ tusb_fifo_write_unaligned(void __iomem *fifo, const u8 *buf, u16 len)
} }
if (len > 0) { if (len > 0) {
/* Write the rest 1 - 3 bytes to FIFO */ /* Write the rest 1 - 3 bytes to FIFO */
val = 0;
memcpy(&val, buf, len); memcpy(&val, buf, len);
musb_writel(fifo, 0, val); musb_writel(fifo, 0, val);
} }