lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pinctrl: amd: Don't show Invalid config param errors

Browse Source 
commit 87b549efcb0f7934b0916d2a00607a878b6f1e0f upstream.

On some systems amd_pinconf_set() is called with parameters
0x8 (PIN_CONFIG_DRIVE_PUSH_PULL) or 0x14 (PIN_CONFIG_PERSIST_STATE)
which are not supported by pinctrl-amd.

Don't show an err message when called with an invalid parameter,
downgrade this to debug instead.

Cc: stable@vger.kernel.org # 6.1
Fixes: 635a750d958e1 ("pinctrl: amd: Use amd_pinconf_set() for all config options")
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20230717201652.17168-1-mario.limonciello@amd.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Mario Limonciello 2023-07-17 15:16:52 -05:00 committed by Greg Kroah-Hartman
parent 99a73016a5
commit b6fefef07d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/pinctrl/pinctrl-amd.c
View File

@ -659,7 +659,7 @@ static int amd_pinconf_get(struct pinctrl_dev *pctldev,
break; break;
default: default:
dev_err(&gpio_dev->pdev->dev, "Invalid config param %04x\n", dev_dbg(&gpio_dev->pdev->dev, "Invalid config param %04x\n",
param); param);
return -ENOTSUPP; return -ENOTSUPP;
} }
@ -712,7 +712,7 @@ static int amd_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
break; break;
default: default:
dev_err(&gpio_dev->pdev->dev, dev_dbg(&gpio_dev->pdev->dev,
"Invalid config param %04x\n", param); "Invalid config param %04x\n", param);
ret = -ENOTSUPP; ret = -ENOTSUPP;
} }