lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: ti: fix UAF in tlan_remove_one

Browse Source 
commit 0336f8ffece62f882ab3012820965a786a983f70 upstream.

priv is netdev private data and it cannot be
used after free_netdev() call. Using priv after free_netdev()
can cause UAF bug. Fix it by moving free_netdev() at the end of the
function.

Fixes: 1e0a8b13d3 ("tlan: cancel work at remove path")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Pavel Skripkin 2021-07-09 17:58:29 +03:00 committed by Greg Kroah-Hartman
parent 2b70ca9284
commit b7e5563f2a
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/ethernet/ti/tlan.c
View File

@ -314,9 +314,8 @@ static void tlan_remove_one(struct pci_dev *pdev)
pci_release_regions(pdev); pci_release_regions(pdev);
#endif #endif
free_netdev(dev);
cancel_work_sync(&priv->tlan_tqueue); cancel_work_sync(&priv->tlan_tqueue);
free_netdev(dev);
} }
static void tlan_start(struct net_device *dev) static void tlan_start(struct net_device *dev)