lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dm: remove flush_scheduled_work() during local_exit()

Browse Source 
[ Upstream commit 0b22ff5360f5c4e11050b89206370fdf7dc0a226 ]

Commit acfe0ad74d ("dm: allocate a special workqueue for deferred
device removal") switched from using system workqueue to a single
workqueue local to DM.  But it didn't eliminate the call to
flush_scheduled_work() that was introduced purely for the benefit of
deferred device removal with commit 2c140a246d ("dm: allow remove to
be deferred").

Since DM core uses its own workqueue (and queue_work) there is no need
to call flush_scheduled_work() from local_exit().  local_exit()'s
destroy_workqueue(deferred_remove_workqueue) handles flushing work
started with queue_work().

Fixes: acfe0ad74d ("dm: allocate a special workqueue for deferred device removal")
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Mike Snitzer 2023-02-14 13:06:05 -05:00 committed by Greg Kroah-Hartman
parent e6d9a876d9
commit b89d2ed564
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/md/dm.c
View File

@ -263,7 +263,6 @@ out_uevent_exit:
static void local_exit(void) static void local_exit(void)
{ {
flush_scheduled_work();
destroy_workqueue(deferred_remove_workqueue); destroy_workqueue(deferred_remove_workqueue);
unregister_blkdev(_major, _name); unregister_blkdev(_major, _name);