lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

crypto: rsa-pkcs1pad - Use akcipher_request_complete

Browse Source 
[ Upstream commit 564cabc0ca0bdfa8f0fc1ae74b24d0a7554522c5 ]

Use the akcipher_request_complete helper instead of calling the
completion function directly.  In fact the previous code was buggy
in that EINPROGRESS was never passed back to the original caller.

Fixes: 3d5b1ecdea ("crypto: rsa - RSA padding algorithm")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Herbert Xu 2023-01-31 16:02:04 +08:00 committed by Greg Kroah-Hartman
parent 8c1447495f
commit c4d8c23efe
1 changed files with 15 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
crypto/rsa-pkcs1pad.c
View File

@ -213,16 +213,14 @@ static void pkcs1pad_encrypt_sign_complete_cb(
struct crypto_async_request *child_async_req, int err) struct crypto_async_request *child_async_req, int err)
{ {
struct akcipher_request *req = child_async_req->data; struct akcipher_request *req = child_async_req->data;
struct crypto_async_request async_req;
if (err == -EINPROGRESS) if (err == -EINPROGRESS)
return; goto out;
async_req.data = req->base.data; err = pkcs1pad_encrypt_sign_complete(req, err);
async_req.tfm = crypto_akcipher_tfm(crypto_akcipher_reqtfm(req));
async_req.flags = child_async_req->flags; out:
req->base.complete(&async_req, akcipher_request_complete(req, err);
pkcs1pad_encrypt_sign_complete(req, err));
} }
static int pkcs1pad_encrypt(struct akcipher_request *req) static int pkcs1pad_encrypt(struct akcipher_request *req)
@ -331,15 +329,14 @@ static void pkcs1pad_decrypt_complete_cb(
struct crypto_async_request *child_async_req, int err) struct crypto_async_request *child_async_req, int err)
{ {
struct akcipher_request *req = child_async_req->data; struct akcipher_request *req = child_async_req->data;
struct crypto_async_request async_req;
if (err == -EINPROGRESS) if (err == -EINPROGRESS)
return; goto out;
async_req.data = req->base.data; err = pkcs1pad_decrypt_complete(req, err);
async_req.tfm = crypto_akcipher_tfm(crypto_akcipher_reqtfm(req));
async_req.flags = child_async_req->flags; out:
req->base.complete(&async_req, pkcs1pad_decrypt_complete(req, err)); akcipher_request_complete(req, err);
} }
static int pkcs1pad_decrypt(struct akcipher_request *req) static int pkcs1pad_decrypt(struct akcipher_request *req)
@ -511,15 +508,14 @@ static void pkcs1pad_verify_complete_cb(
struct crypto_async_request *child_async_req, int err) struct crypto_async_request *child_async_req, int err)
{ {
struct akcipher_request *req = child_async_req->data; struct akcipher_request *req = child_async_req->data;
struct crypto_async_request async_req;
if (err == -EINPROGRESS) if (err == -EINPROGRESS)
return; goto out;
async_req.data = req->base.data; err = pkcs1pad_verify_complete(req, err);
async_req.tfm = crypto_akcipher_tfm(crypto_akcipher_reqtfm(req));
async_req.flags = child_async_req->flags; out:
req->base.complete(&async_req, pkcs1pad_verify_complete(req, err)); akcipher_request_complete(req, err);
} }
/* /*