lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pinctrl: aspeed: Fix confusing types in return value

Browse Source 
[ Upstream commit 287a344a11f1ebd31055cf9b22c88d7005f108d7 ]

The function signature is int, but we return a bool. Instead return a
negative errno as the kerneldoc suggests.

Fixes: 4d3d0e4272 ("pinctrl: Add core support for Aspeed SoCs")
Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Link: https://lore.kernel.org/r/20230119231856.52014-1-joel@jms.id.au
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Joel Stanley 2023-01-20 09:48:56 +10:30 committed by Greg Kroah-Hartman
parent f209431be1
commit cc1affa234
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/pinctrl/aspeed/pinctrl-aspeed.c
View File

@ -115,7 +115,7 @@ static int aspeed_disable_sig(struct aspeed_pinmux_data *ctx,
int ret = 0; int ret = 0;
if (!exprs) if (!exprs)
return true; return -EINVAL;
while (*exprs && !ret) { while (*exprs && !ret) {
ret = aspeed_sig_expr_disable(ctx, *exprs); ret = aspeed_sig_expr_disable(ctx, *exprs);