lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: lpfc: Add missing destroy_workqueue() in error path

Browse Source 
commit da6d507f5ff328f346b3c50e19e19993027b8ffd upstream.

Add the missing destroy_workqueue() before return from
lpfc_sli4_driver_resource_setup() in the error path.

Link: https://lore.kernel.org/r/20220823044237.285643-1-yangyingliang@huawei.com
Fixes: 3cee98db26 ("scsi: lpfc: Fix crash on driver unload in wq free")
Reviewed-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Yang Yingliang 2022-08-23 12:42:37 +08:00 committed by Greg Kroah-Hartman
parent 5682c94644
commit d0e7be0dc9
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/scsi/lpfc/lpfc_init.c
View File

@ -6537,7 +6537,7 @@ lpfc_sli4_driver_resource_setup(struct lpfc_hba *phba)
/* Allocate device driver memory */ /* Allocate device driver memory */
rc = lpfc_mem_alloc(phba, SGL_ALIGN_SZ); rc = lpfc_mem_alloc(phba, SGL_ALIGN_SZ);
if (rc) if (rc)
return -ENOMEM; goto out_destroy_workqueue;
/* IF Type 2 ports get initialized now. */ /* IF Type 2 ports get initialized now. */
if (bf_get(lpfc_sli_intf_if_type, &phba->sli4_hba.sli_intf) >= if (bf_get(lpfc_sli_intf_if_type, &phba->sli4_hba.sli_intf) >=
@ -6911,6 +6911,9 @@ out_free_bsmbx:
lpfc_destroy_bootstrap_mbox(phba); lpfc_destroy_bootstrap_mbox(phba);
out_free_mem: out_free_mem:
lpfc_mem_free(phba); lpfc_mem_free(phba);
out_destroy_workqueue:
destroy_workqueue(phba->wq);
phba->wq = NULL;
return rc; return rc;
} }