lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvdimm: Fix badblocks clear off-by-one error

Browse Source 
commit ef9102004a87cb3f8b26e000a095a261fc0467d3 upstream.

nvdimm_clear_badblocks_region() validates badblock clearing requests
against the span of the region, however it compares the inclusive
badblock request range to the exclusive region range. Fix up the
off-by-one error.

Fixes: 23f4984483 ("libnvdimm: rework region badblocks clearing")
Cc: <stable@vger.kernel.org>
Signed-off-by: Chris Ye <chris.ye@intel.com>
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Link: https://lore.kernel.org/r/165404219489.2445897.9792886413715690399.stgit@dwillia2-xfh
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Chris Ye 2022-05-31 17:09:54 -07:00 committed by Greg Kroah-Hartman
parent 53fb996f27
commit d5e32f08e7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/nvdimm/bus.c
View File

@ -187,8 +187,8 @@ static int nvdimm_clear_badblocks_region(struct device *dev, void *data)
ndr_end = nd_region->ndr_start + nd_region->ndr_size - 1; ndr_end = nd_region->ndr_start + nd_region->ndr_size - 1;
/* make sure we are in the region */ /* make sure we are in the region */
if (ctx->phys < nd_region->ndr_start if (ctx->phys < nd_region->ndr_start ||
|| (ctx->phys + ctx->cleared) > ndr_end) (ctx->phys + ctx->cleared - 1) > ndr_end)
return 0; return 0;
sector = (ctx->phys - nd_region->ndr_start) / 512; sector = (ctx->phys - nd_region->ndr_start) / 512;