lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pinctrl: mcp23s08: Fix missing unlock on error in mcp23s08_irq()

Browse Source 
commit 884af72c90016cfccd5717439c86b48702cbf184 upstream.

Add the missing unlock before return from function mcp23s08_irq()
in the error handling case.

v1-->v2:
   remove the "return IRQ_HANDLED" line

Fixes: 897120d41e7a ("pinctrl: mcp23s08: fix race condition in irq handler")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Link: https://lore.kernel.org/r/1623134048-56051-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Zou Wei 2021-06-08 14:34:08 +08:00 committed by Greg Kroah-Hartman
parent f176dec999
commit f190ca9068
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/pinctrl/pinctrl-mcp23s08.c
View File

@ -461,7 +461,7 @@ static irqreturn_t mcp23s08_irq(int irq, void *data)
if (intf == 0) { if (intf == 0) {
/* There is no interrupt pending */ /* There is no interrupt pending */
return IRQ_HANDLED; goto unlock;
} }
if (mcp_read(mcp, MCP_INTCAP, &intcap)) if (mcp_read(mcp, MCP_INTCAP, &intcap))