lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

NFSv4/pnfs: Fix a use-after-free bug in open

Browse Source 
commit 2135e5d56278ffdb1c2e6d325dc6b87f669b9dac upstream.

If someone cancels the open RPC call, then we must not try to free
either the open slot or the layoutget operation arguments, since they
are likely still in use by the hung RPC call.

Fixes: 6949493884fe ("NFSv4: Don't hold the layoutget locks across multiple RPC calls")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Trond Myklebust 2022-08-02 15:48:50 -04:00 committed by Greg Kroah-Hartman
parent 14b5a92e33
commit f7ee3b772d
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
fs/nfs/nfs4proc.c
View File

@ -3039,12 +3039,13 @@ static int _nfs4_open_and_get_state(struct nfs4_opendata *opendata,
} }
out: out:
if (opendata->lgp) { if (!opendata->cancelled) {
nfs4_lgopen_release(opendata->lgp); if (opendata->lgp) {
opendata->lgp = NULL; nfs4_lgopen_release(opendata->lgp);
} opendata->lgp = NULL;
if (!opendata->cancelled) }
nfs4_sequence_free_slot(&opendata->o_res.seq_res); nfs4_sequence_free_slot(&opendata->o_res.seq_res);
}
return ret; return ret;
} }