lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

powerpc/44x/fsp2: add missing of_node_put

Browse Source 
[ Upstream commit 290fe8aa69ef5c51c778c0bb33f8ef0181c769f5 ]

Early exits from for_each_compatible_node() should decrement the
node reference counter.  Reported by Coccinelle:

./arch/powerpc/platforms/44x/fsp2.c:206:1-25: WARNING: Function
"for_each_compatible_node" should have of_node_put() before return
around line 218.

Fixes: 7813043e1b ("powerpc/44x/fsp2: Add irq error handlers")
Signed-off-by: Bixuan Cui <cuibixuan@linux.alibaba.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/1635406102-88719-1-git-send-email-cuibixuan@linux.alibaba.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Bixuan Cui 2021-10-28 15:28:22 +08:00 committed by Greg Kroah-Hartman
parent d3dd1a057c
commit fb7b73cd94
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/powerpc/platforms/44x/fsp2.c
View File

@ -208,6 +208,7 @@ static void node_irq_request(const char *compat, irq_handler_t errirq_handler)
if (irq == NO_IRQ) { if (irq == NO_IRQ) {
pr_err("device tree node %pOFn is missing a interrupt", pr_err("device tree node %pOFn is missing a interrupt",
np); np);
of_node_put(np);
return; return;
} }
@ -215,6 +216,7 @@ static void node_irq_request(const char *compat, irq_handler_t errirq_handler)
if (rc) { if (rc) {
pr_err("fsp_of_probe: request_irq failed: np=%pOF rc=%d", pr_err("fsp_of_probe: request_irq failed: np=%pOF rc=%d",
np, rc); np, rc);
of_node_put(np);
return; return;
} }
} }