lisa/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Drivers: hv: vmbus: Fix memory leak in vmbus_add_channel_kobj

Browse Source 
[ Upstream commit 8bc69f86328e87a0ffa79438430cc82f3aa6a194 ]

kobject_init_and_add() takes reference even when it fails.
According to the doc of kobject_init_and_add()：

   If this function returns an error, kobject_put() must be called to
   properly clean up the memory associated with the object.

Fix memory leak by calling kobject_put().

Fixes: c2e5df616e ("vmbus: add per-channel sysfs info")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Juan Vazquez <juvazq@linux.microsoft.com>
Link: https://lore.kernel.org/r/20220203173008.43480-1-linmq006@gmail.com
Signed-off-by: Wei Liu <wei.liu@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Miaoqian Lin 2022-02-04 01:30:08 +08:00 committed by Greg Kroah-Hartman
parent ba71b1b30d
commit fe595759c2
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/hv/vmbus_drv.c
View File

@ -1787,8 +1787,10 @@ int vmbus_add_channel_kobj(struct hv_device *dev, struct vmbus_channel *channel)
kobj->kset = dev->channels_kset; kobj->kset = dev->channels_kset;
ret = kobject_init_and_add(kobj, &vmbus_chan_ktype, NULL, ret = kobject_init_and_add(kobj, &vmbus_chan_ktype, NULL,
"%u", relid); "%u", relid);
if (ret) if (ret) {
kobject_put(kobj);
return ret; return ret;
}
ret = sysfs_create_group(kobj, &vmbus_chan_group); ret = sysfs_create_group(kobj, &vmbus_chan_group);
@ -1797,6 +1799,7 @@ int vmbus_add_channel_kobj(struct hv_device *dev, struct vmbus_channel *channel)
* The calling functions' error handling paths will cleanup the * The calling functions' error handling paths will cleanup the
* empty channel directory. * empty channel directory.
*/ */
kobject_put(kobj);
dev_err(device, "Unable to set up channel sysfs files\n"); dev_err(device, "Unable to set up channel sysfs files\n");
return ret; return ret;
} }