At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCGIWAP should no longer be used, so remove
it.
Change-Id: Ic513986029090b55f3df2ea31d07cf1594d17d4d
CRs-Fixed: 2128993
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCSIWMLME should no longer be used, so remove
it.
Change-Id: I9c68bf1b2c734ae2bcb862cd8acfbcea41f48411
CRs-Fixed: 2128992
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCSIWESSID should no longer be used, so remove
it.
Change-Id: Idf75957707c3799add0c59fdd532fe0c24d27117
CRs-Fixed: 2128991
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCGIWESSID should no longer be used, so remove
it.
Change-Id: I4210a1faf12adeaeede1a379f0827eddfbd19881
CRs-Fixed: 2128990
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCSIWNICKN should no longer be used, so remove
it.
Change-Id: Iab8a3e9fafc7a1c4c59bebd308b6b50a46b9228f
CRs-Fixed: 2128989
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCGIWNICKN should no longer be used, so remove
it.
Change-Id: I20f78d9cb52187676e543e90f5ffe19176fe8bc3
CRs-Fixed: 2128988
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCSIWRATE should no longer be used, so remove
it.
Change-Id: If9a82dd0d450a215e5dfaddb93ae6ffe71386aa9
CRs-Fixed: 2128987
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCGIWRATE should no longer be used, so remove
it.
Change-Id: Ibc58460db88bbc3461d67a79b2dafae7a095ce62
CRs-Fixed: 2128986
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCSIWRTS should no longer be used, so remove
it.
Change-Id: I2562e9b2e063810b98a7be15419468f09180ac57
CRs-Fixed: 2128985
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
implementation of SIOCGIWRTS should no longer be used, so remove it.
Change-Id: I517481792e3fb211454b5383288c5cfd92131b2a
CRs-Fixed: 2128984
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCSIWFRAG should no longer be used, so remove
it.
Change-Id: I25e2102a9d97b583783df4480f3fc81fc2a1d202
CRs-Fixed: 2128983
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
implementation of SIOCGIWFRAG should no longer be used, so remove it.
Change-Id: If83d63cea9f3f85a7c2597ae3cf43113548de3ba
CRs-Fixed: 2128982
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCSIWTXPOW should no longer be used, so remove
it.
Change-Id: I77abd4b621a2541e9b745f3a48cd533dc293bf72
CRs-Fixed: 2128591
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCGIWTXPOW should no longer be used, so remove
it.
Change-Id: If5e0a007182e0a25344d27d653b87d22327398fd
CRs-Fixed: 2128590
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCSIWRETRY should no longer be used, so remove
it.
Change-Id: I01a0c501e9417b867a08b3a4b7e2dc462195f1c7
CRs-Fixed: 2128589
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCGIWRETRY should no longer be used, so remove
it.
Change-Id: Iec9fa41ccb52723d8938b1392342b2e10d66c363
CRs-Fixed: 2128588
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCSIWENCODE should no longer be used, so remove
it.
Change-Id: I3aa8ecd114b7be9bdef0efbac9b854cf6119f02b
CRs-Fixed: 2128587
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCGIWENCODE should no longer be used, so
remove it.
Change-Id: Ia67464527b795c93014ff2fe2347edd318ce6a25
CRs-Fixed: 2128585
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCSIWPOWER performs no useful actions and
should no longer be used, so remove it.
Change-Id: Ib42d515ca19ca23b50dc34e7df0e62b7507bc728
CRs-Fixed: 2128584
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCGIWPOWER performs no useful actions and
should no longer be used, so remove it.
Change-Id: I3226f15ae9685eab83e8dc3ee9771da0ad3df5fc
CRs-Fixed: 2128583
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCSIWGENIE should no longer be used, so remove
it.
Change-Id: I95cdb9431edace942ccef40efee918316a9f6cb9
CRs-Fixed: 2128582
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCGIWGENIE should no longer be used, so remove
it.
Change-Id: If7bbffdaa9c32e0945688e3dd41cb135ba57a44d
CRs-Fixed: 2128581
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCSIWAUTH should no longer be used, so remove
it.
Change-Id: I34a90c11c50967c8ccd74984721e709eda66d322
CRs-Fixed: 2128361
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCGIWAUTH should no longer be used, so remove
it.
Change-Id: I454f925ac3d11cf84d311285b74ecd3674ecb90f
CRs-Fixed: 2128360
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCSIWENCODEEXT should no longer be used, so
remove it.
Change-Id: Ifc2e25eb1736795a56f07d6ef588156ca12b9dcc
CRs-Fixed: 2128359
At one time the predecessor to the current driver was managed via
wireless extensions, but now the driver is managed by cfg80211. The
STA implementation of SIOCGIWENCODEEXT should no longer be used, so
remove it.
Change-Id: I02aca0bab022d84775acfa6d238e23ea357b79d0
CRs-Fixed: 2128358
Recent fix I082c771bbee6d083b15515dd2e40ed9a27e0a9a1 has been added
to release PEER's uncleaned timer memory but this fix is not good
enough to cover SSR (sub system restart) scenario in which driver
never calls stop bss API.
To resolve the SSR case, call lim_del_pmf_sa_query_timer() API before
deleting the PE session.
CRs-Fixed: 2127688
Change-Id: I50d6eda88fcd666b546fffb6a0bc1b7e500a8cae
Currently the mpdu_data_len in Rx pkt meta is not checked for
upper bound in wma_process_rmf_frame.
Add sanity check to drop the packet if mpdu_data_len is
greater than 2000 bytes.
Change-Id: I156cf9766dda30ee3746361614a2e4586553f93d
CRs-Fixed: 2123807
Currently, OL/TXRX is unable to handle non TSO
packets which are non-linear. These packets have skb->gso_size as zero
since they are not jumbo packets and dont need to be TSOed.
However, TSO code can handle such packets. The current code assumes that
non TSO packets will be linear. This may case an incorrect memory access
leading to a crash.
Fill in gso_size for non-linear TCP packets if it is zero. This lets the
TSO logic handle these packets for CE transmission.
Change-Id: I75c7759e1a35c462966a2d925db6f537670ad72f
CRs-Fixed: 2100254
Currently with CONFIG_WLAN_FEATURE_FILS set to n in Kbuild,
compilation issues are seen in the function hdd_save_gtk_params
due to usage of fils related structure without the compilation flag
checked.
Add new definition for the function hdd_save_gtk_params to fix
compilation issues with hdd_save_gtk_params set to n
Change-Id: Iab96c97df50f50c601ba52060440668373f74744
CRs-Fixed: 2111640
Currently the debug logs print only the KEK, KCK and other
keys during FILS Roam sync indication from FW to Framework.
Add additional debug logs to print Next ERP Sequence Number
from the firmware during roam sync indication to Framework.
Change-Id: I3df03cd3d426ffa18e021a45d95edb3148838858
CRs-Fixed: 2106552
Currently, wmi_service_bitmap field in WMI_SERVICE_READY_EVENT is
exhausted. WMI_SERVICE_AVAILABLE_EVENT is available for upcoming
capability intimations.
Add service_available_event handler in host driver to extract
FILS roaming capability of fw. Based on this capability only,
send RSO, update connect params, HLP IE commands, GTK offload
are sent to fw.
Change-Id: I320ba86d29109d8cba23830ef9cb5e159792f19a
CRs-Fixed: 2094229
Currently, driver sends add/delete pmksa entry to fw
whenever supplicant sends set/delete pmksa to driver.
Add support to flush all PMKSA entries as well.
Change-Id: I044a25b071cab5c156b41bcaab338328b5439d64
CRs-Fixed: 2094257
Currently, in host driver, FILS Keys(PMK, KEK, ICK) are
printed in debug logs.
Remove all the Key dumps added as part of FILS.
Change-Id: Iafdd556b5c547d5d8f8184a33c0d2fad40cb96d0
CRs-Fixed: 2095631
Add FILS roaming support changes as follows:
- Update ERP info in RSO Start
- Update HLP info in a new command WMI_PDEV_UPDATE_FILS_HLP_PKT_CMDID
- Set/Delete PMK cache info with WMI_PDEV_UPDATE_PMK_CACHE_CMDID
- Process FILS TLV in Roam Synch Indication and update the FILS info
[seq number,PMK, KEK, realm] to Supplicant.
Change-Id: I78c3bdde080701deb8d2bdb92d8d57d18cceb864
CRs-Fixed: 2081252
Currently BcnNumIes is uint8_t, which is used to hold ie length,
and it cannot be used to hold if ie length is greater than 255,
it will wrap-around to zero or smaller number.
So change BcnNumIes variable type from uint8_t to uint16_t.
Also change to bss desc copy logic in
sme_rrm_send_beacon_report_xmit_ind function.
Change-Id: Ie92a9afbf6e3674a0730f5f48210424b1d34386d
CRs-Fixed: 2124579
Currently the "requested BSSID" is kept in struct hdd_wext_state. This
information is independent of wireless extensions, so relocate it to
struct hdd_station_ctx and rename it to improve readability and to
conform to the Linux coding style.
Change-Id: I3410103260d5be9cb405084f7f357fcfe08fb6f0
CRs-Fixed: 2128357
To reduce code size, remove legacy P2P codes in SAP layer. Remove
P2P files from Kbuild.
Change-Id: I83a704d3f03e9cb9e6a7420f32d609a323799a12
CRs-Fixed: 2111575
Introduce a new parameter in the ini file for the maximum
number of MSDUs per HTT_RX_INORDERIND message.
This parameter is now sent over to the FW through the RFS
configuration message.
Change-Id: Id0057861bc172a36483804170274b202198b6824
CRs-Fixed: 2106760
This reverts commit I3216a4c14ac624cc313d11226909efd4f63841d0
When alloccate free Tx desc list, Tx desc pool size is not initialized yet,
so tx_desc_size is set to 0.
This cause free Tx descriptor allocation failed.
Change-Id: I02ae2e59311e737dd9245228048d62f657d5b0d1
CRs-Fixed: 2085753
This change adds support for configuring voltage corner mode
thorugh INI parameter. User will provide a bitmap which will
be passed on to the FW during initialization. In this bitmap,
each pair of bits till BIT27 correspond to different phymode,
bw combination. Bit values signify voltage corner configuration.
Change-Id: I9e86d43079225b6f08fdd281c8f424b18abcffe9
CRs-Fixed: 2109884
The hdd_hostapd_state bCommit flag is a remnant from a prior version
of the driver. This flag is written, but never read, and hence
obviously has no purpose, so remove it.
Change-Id: If4fd93f474fcd6e01cdc51b1575a3509b538b504
CRs-Fixed: 2126889
Checkpatch reported the following issue, so fix it:
- ERROR:SPACING: space prohibited after that '*' (ctx:ExW)
Change-Id: I78a48d284d8b773a4a8c02f2196200f615836690
CRs-Fixed: 2126450
Remove P2P debug functions from legacy code and apply the new
functions in UMAC P2P component.
Change-Id: I1ff627a553108c74be144232fd0a0406d88de395
CRs-Fixed: 2105808
In WMI_SERVICE_READY_EVENTID, check for number of dbs HW modes against
the metadata.
Change-Id: I043c93c4e6bc0dfdd73dbdc65bab683c56269308
CRs-Fixed: 2119387
When receive STOP_BSS, send WLAN_CLIENT_DISONNNECT event send to IPA.
And upon receiving WLAN_CLIENT_DISONNNECT, check if all clients are
already disconnected to avoid redundant event processing.
Change-Id: Ibb3074cdaf65da9ea8c2032df86f9d66b2fce014
CRs-Fixed: 2096338
Propagation from qcacld-2.0 to qcacld-3.0
ipv4 and ipv6 workqueues are initialized in open adapter for STA
and P2P modes but not for AP mode. The workqueues are cancelled
in stop adapter. The cancel_work_sync may be called on AP adapter
workqueue also, if just in time, the AP adapter mode has changed
to STA mode, for example during hostapd stop etc. This can cause
the cancel_work_sync to continuously loop since INIT_WORK has not
been called, finally raising CPU stuck. There is no harm in calling
INIT_WORK on any workqueue since it only makes sure that in cases
as above there is no undeterministic behaviour.
Fix cancel_work_sync issues by initializing ipv4 and ipv6 workqueues.
CRs-Fixed: 2121723
Change-Id: Ief8dd0c797dd1492fa30ca4e41da9e583548e21d
__iw_softap_set_ini_cfg assumes a given user supplied buffer is null
terminated, which can lead to a buffer overrun. Ensure the buffer is
null terminated by copying it to a new, oversized buffer whose last byte
is zero.
Change-Id: If94e753026f79a368cd6b9cb7c745ade4ae29452
CRs-Fixed: 2118809
Netdev Tx/Rx stat counters doesn't reflect packet counter from IPA
offload data path.
Change to add Tx/Rx packet counts from IPA uC data path through IPA uC
stats query.
Change-Id: If80dee818e97f4f75407885c20ee9abf2257be7c
CRs-Fixed: 956283
The original version of the driver was based upon wireless
extensions. Later when nl80211/cfg80211 support was added, in some
cases data received with nl80211 semantics was converted to wireless
extensions semantics. One such data item is the WPA version.
Now that wireless extensions have been deprecated, it is desirable to
align on cfg80211/nl80211 semantics. Therefore now align on enum
nl80211_wpa_versions for maintaining the WPA version.
Change-Id: I2a0fb6996b42adfe6dec7c14493c2dc10f83230c
CRs-Fixed: 2126880
It doesn't record current scan request and won't cleanup being
process scan request. In some Rome platform, host driver just load one
time, scan request status mismatch to cfg80211 if didn't cleanup scan
request, and then cause crash.
Change-Id: I000db80bdf5175775f2415130ee3a2974aefa4ea
CRs-Fixed: 2111330
As part of configure default filters over suspend code
changes wlan module loading broken.
Fix the loading issue by adding the newly added files
to Kbuild.
CRs-Fixed: 2017259
Change-Id: Ib33efa8f7f5e2ca8d9734181df94f70557e9f9cd
In suspend mode multicast, broadcast packets wakes up host,
this leads to higher power consumption.
Add support to configure the IPv6/IPv4 multicast, IPv4 broadcast, XID,
STP, DTP/LLC/CDP packet filters based on ini bit map param, before the
device goes to suspend mode and clear the same filters in resume.
CRs-Fixed: 2011442
Change-Id: Ib355459132086902ba008f2abd17415a8f569b41
In Rome platform, it use invalid radio id in FW event
WMI_RADIO_LINK_STATS_EVENTID and cause crash. So check
radio id when handling this event.
Change-Id: Iadf61fbde53f80f1081da9a386cf13f0cce69e3c
CRs-Fixed: 2123782
when unloading driver, there is possible that the driver_status
has been DRIVER_MODULES_CLOSED, then NETDEV_GOING_DOWN is received,
which will cause assert in qdf_mutex_acquire as lock has been
destoryed.
Change-Id: Ic7e26dc1eb9a40a2462b041b0f3b84452e448cfd
CRs-Fixed: 2126832
Number of profile data from firmware cannot be trusted. Check for
number of entries against the metadata in TLV header.
Change-Id: I0d8078f623a97e33ee1689398c291be75fe9a62a
CRs-Fixed: 2119391
Pending_event memory is dynamically allocated after driver loaded
but freed up only when driver unloading.
Fix to free pending_event memory when driver stop.
Change-Id: Ia748e311fc77fc99e193230910fccd7bc9b4f5a9
CRs-Fixed: 2126695
If SAP has no channel left to move then it will issue stop bss. In this
scenario, SAP is not cleaning up its entry from policy manager table
which causes stale entry left over in table.
Fix this situation by stopping the bss successfully and deleting entry
from policy manager table.
Change-Id: I7c7d305936fe16b0deebb9b7a67f7753cbf243e6
CRs-Fixed: 2112932
Release the NSS update request from the serialization active
command list in case the request fails.
Change-Id: Id6bfee6f510132bacdc69773c8aba90be43aa813
CRs-Fixed: 2112932
SoftAP start fails during station connection is in progress and the flag
update_beacon is not set. Also allow beacon/probe resp update in the middle
of p2p connection.
Change-Id: I13d89b6b8b51f999ff317d1f55dc3fcf48bdd422
CRs-Fixed: 2108186
This reverts Change-Id: I1887aab39d2fa13cc8a900164d2aa6d489464e42
Driver is no more acquiring qdf_conc_list_lock before calling
cds_get_pcl(). SME active queue will serialize connection request and
bss start commands.
Change-Id: I98066b8f1e756ae930ea97be6f8c6e6de244662d
CRs-Fixed: 2108186
For data stall continuous HDD tx timeout count of five
post HOST TX time out data stall event to handle it in
data detection module.
Change-Id: Ic6cf5e62f711cef5919a4a5e85e4232c622c04bb
CRs-Fixed: 2094393
Add sanity check for vdev id in wma_vdev_start_resp_handler() to prevent
out of bound memory access.
Change-Id: Ia4e18e8e322142928c41dfa88b874ff017727266
CRs-Fixed: 2120424
There is a possibility of double start of inactivity timer if iff_up
(hdd_open) happens while probe/remove/reinit is still going on.
To mitigate this issue, on iff_up, start inactivity after acquiring
hdd_init_deinit_lock, which make sure probe/remove/reinit are
completed, and thereby inactivity timer is stopped.
Change-Id: I2417215380e318a8410a2d25eabf82f353a26c4f
CRs-Fixed: 2125494
There can be deadlock on iff_up on anyone of mutex's like
init_deinit_lock, iface_change_lock. To catch what caused the
deadlock start the inactivity timer to root-cause the issue
CRs-Fixed: 2120569
Change-Id: I830cc4127a9c0691ee44a5e2c56c871471d638db
qcacld-2.0 to qcacld-3.0 Propagation.
Wifi OFF/ON is needed to update the gEnableModuleDTIM ini param.
Add private ioctl to configure modulated DTIM at runtime.
CRs-Fixed: 2002662
Change-Id: I28be432da775a9aa026cd702c63dee5666260d33
Fine tune the scan rest time configuration parameters,
gRoamRestTimeMin and gNeighborScanTimerPeriod to 50ms and
100ms respectively for better power efficiency.
Change-Id: Ia6edb87dbb0abf4771613a028d711f4f7a4e0f41
CRs-Fixed: 2120683
Some data path code change didn't consider SDIO code path, so
introducing some build error for SDIO driver. Fix them in one
submission to enable ACI
Change-Id: I3d1b81c57a8ae854f18db3eccb546b7b552899b7
CRs-Fixed: 2033757
Assert was added in the wma_rx_aggr_failure_event_handler via the change
Iea93e879196e9cd43856a7dcc9204d2304f76c78 and it exposes further security
issues.
Remove the assert in wma_rx_aggr_failure_event_handler.
Change-Id: Iaef00389fa19da0fe33e3bcd6f2123e553b84dff
CRs-Fixed: 2114789
SAP DUT allocates SA query timer for each STA-PEER which gets associated
to DUT. When STA-PEER walks out or gets disassociated, SAP DUT releases
this timer memory through PEER clean-up process but in few corner cases
it is observed that STA-PEER left uncleaned.
In such cases ideally when SAP session goes away, SAP state-machine
should check any left out memory and clean it up through
lim_cleanup_mlm() but this API check for own session validity and
own session has been marked as invalid before even calling this API.
Due to which timer memory leaks.
Fix the situation by deleting the timer before marking own session as
invalid.
In some cases, for some reasons PEER delete sta request couldn't send to
FW then memory associated with delete sta request needs to be freed.
If status is failure and del sta response is not required then silently
release the memory.
CRs-Fixed: 2124293
Change-Id: I082c771bbee6d083b15515dd2e40ed9a27e0a9a1
Currently during peer initialization (ol_txrx_peer_attach), we are
initializing peer refcount to 2. This is done to prevent peer
deletion, in case some logic tries to delete a peer when the host has
not received peer map events.
The above logic fails to address the condition when there is roaming
failure, followed by peer deletion from userpace. In this case, host
tries to create a peer and initializes refcount to 2. However, since
roaming fails, firmware does not send out peer map events. In the
meanwhile, the framework tries to delete the existing peer. This
deletion following the peer creation and absence of peer map leads to an
incorrect peer refcount even after deletion and hence this peer does not
get deleted.
Initialize peer with refcount of 2 but 1 instead. In case a map or
unmap arrives after peer deletion, the existing logic will
try to find a peer in the peer hash bins or peer_id_obj_map and will
not find the peer.
Change-Id: Ia3ba6842122dba49281d7bd00303cbe7685ef91c
CRs-Fixed: 2087373
To avoid circular dependency, cleanup is done
in common code, So use correct header file to
fix any compilation issue.
Change-Id: Id094107dda4f34ed479ead0b801da27c7aa240ff
CRs-Fixed: 2126011
Add sanity check for wow_buf_pkt_len in wma_wow_wakeup_host_event()
to avoid out of bound memory access.
Change-Id: Id3b0003aa366d9239739efe561f44eff1dceff5d
CRs-Fixed: 2119401
When force_sap_acs is enabled, hostapd acs will be discarded
and driver acs will happen with override values from ini. Finally
weight for a channel is calculated based on rssi, bsscount. etc.
from auto_channel_select_weight. This ini value is getting extracted
only in __wlan_hdd_cfg80211_do_acs() and so ini value won't be updated
in sap config when hostapd acs doesn't happen or force_sap_acs is enabled.
Update auto_channel_select_weight ini value in sap config in
wlan_hdd_cfg80211_start_bss() which is called irrespective of any
configuration.
Change-Id: I90f549fece117a72c19cf5fdc9f6485b1ab8afdc
CRs-Fixed: 2125597
Checkpatch reported instances of the following issue, so fix them:
- ERROR:SPACING: space prohibited before that ',' (ctx:WxE)
Change-Id: Ifc015a9e3976ebca03662438998433e976e6cf18
CRs-Fixed: 2125683
Checkpatch reported the following issues, so fix them:
- ERROR:SPACING: space prohibited before that ':' (ctx:WxE)
- ERROR:SPACING: space prohibited after that '*' (ctx:ExW)
Change-Id: I2ae63f6a0474a6d8384c2b6796a5239b99aa3ffb
CRs-Fixed: 2125682
Checkpatch flaged the following issues, so fix them:
- WARNING:LONG_LINE: line over 80 characters
- ERROR:SPACING: space prohibited before that ',' (ctx:WxE)
- WARNING:LINE_SPACING: Missing a blank line after declarations
Change-Id: Ifb14eaa7828da997c35265deed5e94a2a2db9054
CRs-Fixed: 2125681
Checkpatch reported the following issues, so fix them:
- WARNING: Missing a blank line after declarations
- WARNING: Block comments use a trailing */ on a separate line
- ERROR: that open brace { should be on the previous line
Change-Id: I7671e3a165cb7f372187c37ce31a92778422031a
CRs-Fixed: 2124909
Checkpatch reported the following issues, so fix them:
- ERROR: else should follow close brace '}'
- WARNING: braces {} are not necessary for single statement blocks
Change-Id: I9c8d329d70ee258834eaaea0183ba2e36643b572
CRs-Fixed: 2124908
It can help to trace what is happening during load/unload and
avoid just exiting silently.
Change-Id: I61a451058a7846d3627500db2c9d8d5998e8210e
CRs-fixed: 2123331
Commit fb9d5acfed and 645749571d introduce an API to deinit scan
runtime suspend lock and move runtime suspend context deinit in
order to fix a memory leak issue. However, it breaks SSR because
runtime suspend context init and deinit are not matching during
SSR which results double free happens in the rmmod after SSR.
Move runtime suspend context init to correct place.
Change-Id: I698385ab52e7e18636b143cd71c229afb676baff
CRs-fixed: 2123331
If probe failed because of no memory, we want to try to recovery by
issuing a re-probe for built-in driver. Hence, convert probe return
error from -ENOMEM to -EPROBE_DEFER for built-in driver so that
platform driver can issue re-probe based on the return value.
CRs-Fixed: 2124159
Change-Id: I6cca0ed186554c8065b77af8c178ca9e143abf98
Checkpatch reported the following problem:
ERROR: Prefixing 0x with decimal output is defective
Correctly use %x when logging hex data.
Change-Id: I8150cf6ae5770a18035f006df9e774932919d9b7
CRs-Fixed: 2124907
In WMA, data from firmware event buffer is used without
sanity checks for upper limit. This might lead to a potential
integer overflow further leading to buffer corruption.
Add sanity check to avoid integer overflow.
Change-Id: Id47e12015a4d46af24180b621b52ffcb17596c07
CRs-Fixed: 2112832
Structure roam_offload_synch_ind has element hlp_data which is of
size FILS_MAX_HLP_DATA_LEN is greater than WMI_SVC_MSG_MAX_SIZE.
Hence, remove check for size of roam_offload_synch_ind against
WMI_SVC_MSG_MAX_SIZE to avoid roam failure. Also, modify check
for validity of vdev id.
Change-Id: I1b9cef08e1d847f27b7057abf7189ef0f867b92f
CRs-Fixed: 2124786
Fw assert and unloading can occur at same moment, there is no need
to recover if wlan unloading is ongoing, so skip notifying SSR framework
in such case.
Change-Id: I2176d1505e8e358f4436277e4d0b706923596f27
CRs-Fixed: 2087634
In driver as part of __wlan_hdd_cfg80211_set_ap_channel_width() driver
modify the channelBondingMode24GHz and this modified value is not
changed to default value once hostapd restarts.
Due to this when the 20/40 BSS Coexistence Management frame is
received and hostapd tries to change the width to 20Mhz using
__wlan_hdd_cfg80211_set_ap_channel_width(), as
channelBondingMode24GHz is already set to 0, the request is
ignored and SAP doesn’t switch to 20Mhz.
To fix this use per session cb mode to validate bw switch.
Change-Id: Ia233c478794602aa6909cf637c5fc8c82fc3433a
CRs-Fixed: 2058315
Currently resp_event->vdev_id, recevied from the FW, is directly used
to refer to wma->interfaces without validating if the vdev_id is valid.
Add sanity check to make sure vdev_id is less than max_bssid before
using it.
Change-Id: I734ff795a3936719b08493f868384dbde72a80df
CRs-Fixed: 2119394
In function wma_ndp_end_indication_event_handler, num_ndp_end_indication_list
from the fw is used to calculate buf_size which is in turn used to malloc.
This could lead to potential integer overflow if num_ndp_end_indication_list
is a very high value.
Add check to validate num_ndp_end_indication_list does not exceed the max
message size from firmware.
Change-Id: Icbb763bfc14ec0ef8424cab50afa5c6826fd3c60
CRs-Fixed: 2114255
Set uapsd_delivery_mask if either static mask uapsd_per_ac_bit_mask is
set or dynamic mask uapsd_per_ac_delivery_enable_mask is set. Both static
and dynamic masks need not to be set to enable uapsd_delivery_mask.
Similar logic is applicable as well for uapsd_trigger_mask. Hence, revert
commit 2560111dd2.
Change-Id: I743d11617e33e7a358473eeab4455339fe1bbd98
CRs-Fixed: 2123812
Currently, when wifi is disabled from UI, and if the device goes
to suspend before the interface change timer expires, then until
the next APPS wakeup wifi remains enabled hence power numbers are
high.
As a part of fix, Host acquire wakelock when it start change
interface timer.
Change-Id: I41662596725315a6cfe185ee23ae889b69938e0b
CRs-Fixed: 2091154
Implement nbuf alloc fail replenish timer which starts when
there is an nbuf allocation failure and stops when there is
an nbuf allocation success with in the timer expiry duration.
Change-Id: Ie956ea144dec4323664632d00bb8f0f82ba22439
CRs-Fixed: 2033944
Currently fix_param->vdev_id, recevied from the FW, is directly used
to refer to wma->interfaces without validating if the vdev_id is valid.
Add sanity check to make sure vdev_id is less than max_bssid before
using it.
Change-Id: I92743589e0333449c39e148b37d200cac2cdb817
CRs-Fixed: 2119434
Add sanity check for num_hw_modes and num_phy in wma_populate_soc_caps()
for WMI_SERVICE_READY_EXT_EVENTID.
Change-Id: I023d737449283f9ac092d278bde016b208b2c891
CRs-Fixed: 2119887
1) Currently all the parameter to decide best candidate are chosen
as by default.
Add INI support for those parameters to change values on basis
of performance.
2) At the time of calculating best candidate score, rssi consider
bucket size, good rssi, bad rssi, good rssi percentage from total
rssi percentage, bad rssi percentage from total percentage.
Configure these all params from ini.
Change-Id: I808a40486473fcbb161c12fbd369b3b846beb8c2
CRs-Fixed: 2121735
In function wma_unified_link_iface_stats_event_handler, num_ac is received
from the firmware and is used in the loop to populate values into results.
However the memory for results is allocated only for WIFI_AC_MAX and a
buffer overflow will occur of num_ac is greater than WIFI_AC_MAX.
Add checks to make sure num_ac is not greater than WIFI_AC_MAX and
num_offload_stats is not greater than WMI_OFFLOAD_STATS_TYPE_MAX.
Change-Id: Ife8b1d19aa853f85f4fad82d5791e49a8c892ca4
CRs-Fixed: 2114756
