One of the HDD functions with the highest cyclomatic complexity is
__wlan_hdd_cfg80211_wifi_configuration_set(). In order to reduce the
complexity there is a plan to replace the inline attribute handling
with a vtable-based approach.
As part of that goal refactor the following independent attribute
handling into a separate function and add that function to the vtable:
- QCA_WLAN_VENDOR_ATTR_CONFIG_SCAN_ENABLE
Change-Id: Ia9e97c19c26d7fbdaed0ddaec2def1bdc78ae34c
CRs-Fixed: 2371564
One of the HDD functions with the highest cyclomatic complexity is
__wlan_hdd_cfg80211_wifi_configuration_set(). In order to reduce the
complexity there is a plan to replace the inline attribute handling
with a vtable-based approach.
As part of that goal refactor the following independent attribute
handling into a separate function and add that function to the vtable:
- QCA_WLAN_VENDOR_ATTR_CONFIG_LRO
Change-Id: I5627292f84cefe79b1a89d1be84cea5d8a7c6cc1
CRs-Fixed: 2371563
One of the HDD functions with the highest cyclomatic complexity is
__wlan_hdd_cfg80211_wifi_configuration_set(). In order to reduce the
complexity there is a plan to replace the inline attribute handling
with a vtable-based approach.
As part of that goal refactor the following independent attribute
handling into a separate function and add that function to the vtable:
- QCA_WLAN_VENDOR_ATTR_CONFIG_LISTEN_INTERVAL
Change-Id: I61b679c4fda4b803a8721054694102c7af46fc88
CRs-Fixed: 2371562
One of the HDD functions with the highest cyclomatic complexity is
__wlan_hdd_cfg80211_wifi_configuration_set(). In order to reduce the
complexity there is a plan to replace the inline attribute handling
with a vtable-based approach.
As part of that goal refactor the following independent attribute
handling into a separate function and add that function to the vtable:
-QCA_WLAN_VENDOR_ATTR_CONFIG_MODULATED_DTIM
Change-Id: Iebadf68ec920ab4198feb5b8ee99ec3d8b961173
CRs-Fixed: 2371561
One of the HDD functions with the highest cyclomatic complexity is
__wlan_hdd_cfg80211_wifi_configuration_set(). In order to reduce the
complexity there is a plan to replace the inline attribute handling
with a vtable-based approach.
As part of that goal refactor the following independent attribute
handling into a separate function and add that function to the vtable:
- QCA_WLAN_VENDOR_ATTR_CONFIG_FINE_TIME_MEASUREMENT
Change-Id: I8b9914936ed9077b487bb8092246a64a6c5f914b
CRs-Fixed: 2371560
One of the HDD functions with the highest cyclomatic complexity is
__wlan_hdd_cfg80211_wifi_configuration_set(). In order to reduce the
complexity there is a plan to replace the inline attribute handling
with a vtable-based approach.
The QCA_WLAN_VENDOR_ATTR_CONFIG_SCAN_DEFAULT_IES attribute handling is
already in a separate function, so add that function to the vtable
instead of calling it directly.
Change-Id: Id77d491ce90bbc1d2a0569af37bba55aeeaa0295
CRs-Fixed: 2371559
One of the HDD functions with the highest cyclomatic complexity is
__wlan_hdd_cfg80211_wifi_configuration_set(). In order to reduce the
complexity there is a plan to replace the inline attribute handling
with a vtable-based approach
As the first step of this refactoring add the actual vtable
infrastructure. Later changes will refactor the attribute handling
and populate the vtables.
Change-Id: If79fc61f84bf17a39e300c18681961a4a0e01408
CRs-Fixed: 2371558
Use policy manager to set and update the NAN Discovery
related connection info. Disable NAN Discovery
explicitly for unsupported concurrencies.
Handle concurrencies with NAN Discovery interface.
Change-Id: I8c9450b034983ef0402fdc878d8b525bedac9f0b
CRs-Fixed: 2358180
Reject con mode handler after driver is unloaded. Proper order is
Driver needs to be re-loaded again and then con mode change handler
needs to be invoked.
Change-Id: Ibc3dfbae1ba3953af537f2d5f50748598a4fe3e1
CRs-Fixed: 2369284
Change Idf75957707c3799add0c59fdd532fe0c24d27117 ("qcacld-3.0: Remove
obsolete STA support for SIOCSIWESSID") removed the last client of
hdd_wmm_get_uapsd_mask(). Since this function is now unused, remove
it.
Change-Id: I28b1909690e1f1c813f4169b6429a7faecdac7d6
CRs-Fixed: 2371200
The user setting value is checked against the previous setting
hence if the current setting value is greater than previous setting
then driver returns error.
Check the user setting value against the range and update the param
value.
Change-Id: I2c730b71668efa7932600328459da9347d3e1d2f
CRs-Fixed: 2371024
Change Idaaacac4fdaf1b964432c33c10b1c86f8a591c2d ("qcacld-3.0: Remove
legacy P2P codes in HDD") removed the logic which utilized the
rem_on_chan_ready_event field in struct hdd_adapter. Since this field
is no longer used, remove it.
Change-Id: Ic8947dc70d510bd123759e53e58e33c5b64ec130
CRs-Fixed: 2370881
PNO adaptive dwell mode is updated from adaptive_dwell_mode_enabled
instead of pnoscan_adaptive_dwell_mode.
Use pnoscan_adaptive_dwell_mode to update the PNO adaptive dwell time
mode.
Change-Id: Ia1f44fa6e3bf65ca41e1a29dcdac345432923e76
CRs-Fixed: 2370377
Change Idaaacac4fdaf1b964432c33c10b1c86f8a591c2d ("qcacld-3.0:
Remove legacy P2P codes in HDD") removed the code that utilized
the cancel_rem_on_chan_var completion variable. Since it is no
longer used, remove the remaining references to it.
Change-Id: Icb2701a8335042aade3a2c7eb0af308e8bdfc658
CRs-Fixed: 2370037
Change Ia860904685fc4783453491effa4518777c7406d0 ("qcacld-3.0:
TDLS: remove legacy interfaces") removed the last reference to
enum tdls_concerned_external_events. Since this enum is now unused,
remove it.
Change-Id: Ie21072a45d7c083d4f0f661906ca9cabb17a6178
CRs-Fixed: 2370025
Change I994e53b17788472de979df9dce9e18c6f68de850 ("qcacld-3.0: Add
support for regulatory component ucfg apis") removed the last
reference to macro WLAN_WAIT_TIME_COUNTRY. Since this macro is now
unused, remove it.
Change-Id: Ia0824abe9bb4419966b812f755600853520f8df2
CRs-Fixed: 2370024
Change I8ba344ce5593df44bd15527e2ff68e872b6d23b8 ("qcacld-3.0: TDLS:
remove legacy core functions") removed the code that used macro
WLAN_HDD_PUBLIC_ACTION_TDLS_DISC_RESP. Since the macro is now unused,
remove it.
Change-Id: Ie0cd5cea1bc2a16829bbfb9b8339a41b303c6724
CRs-Fixed: 2370023
Change Ia8b85548ff64ad77b5066fe03229e2b0b2f7fae3 ("qcacld-3.0: Remove
legacy scan complete callback") removed the "nil scan report"
feature. However it left behind the last_nil_scan_bug_report_timestamp
field in struct hdd_context. Since this field is now unused, remove
it.
Change-Id: I7a208121c3957a5ab04df455ad8a8b54932dfd1c
CRs-Fixed: 2370022
TDLS is not supported in concurrency. As part of second interface
creation, TDLS is disabled in both host and FW. But after the second
interface is deleted, TDLS is not enabled in FW and host even for
Standalone STA and P2P client cases.
Change-Id: I362c22a79e171f9779393b1b893b5bfd14ff562a
CRs-Fixed: 2367083
If DBS is disabled from INI then driver just bails out
in wlan_hdd_update_dbs_scan_and_fw_mode_config() API and never report
it to FW. This creates a confusion when DBS is disable INI but our HW
is capable of doing DBS, i.e. driver thinks that DBS disabled
but FW thinks that DBS is enabled.
Provide a fix that driver should report exact INI setting to FW.
This issue got introduced as part of regression caused by:
Iec2ef7e77e91f332028904c319d24e1ed134306d
ROME platform doesn't support any DBS related commands in FW,
so if driver sends wmi command with dual_mac_config with all params
set to 0 then FW wouldn't respond back and driver would timeout on
waiting for response. This was the original issue for which
Iec2ef7e77e91f332028904c319d24e1ed134306d was added.
Make sure current solution doesn't break backward compatibility.
Add a check to make sure FW supports DBS to eliminate
ROME vs NON-ROME platform.
CRs-Fixed: 2361628
Change-Id: I8a3b795b20e82391ae5d5c86d1e7d814d103ce64
Change I3260369879108f167453d5e0b8435c30ed729c5e ("qcacld-3.0: HDD
changes for common scan module") removed the only reference to macro
MAX_PENDING_LOG. Since it is now unused, remove it.
Change-Id: I4b5bf351a5bc7e2b841810302b75102038ae5a43
CRs-Fixed: 2368721
Change I84e9ac5ccfe8faaa00dfc448defb81fb792263d5 ("qcacld-3.0: Add
support for NDP vendor commands and NDI Create") introduced a forward
reference to struct hdd_tgt_cfg. That struct doesn't actually exist,
so remove the forward reference.
Change-Id: Ic3129f6c0c8e55824ba066d5d36a7d10868f9f50
CRs-Fixed: 2368720
Change I64d7a0e3e180a636d710b42837ff3a982853fb12 ("qcacld-3.0: Remove
the excessive logging in hdd_get_adapter_by_vdev") removed the last
reference to macro RATE_LIMIT_ERROR_LOG. Since it is now unused,
remove it.
Change-Id: I531f0496edb064ed0a8208c497a7a5905be21713
CRs-Fixed: 2368719
Change I3a506905f40272efe472028391e8080d764cb390 ("qcacld-3.0: Use max
STA count when iterating SAP clients") removed the only reference to
macro WE_GET_STA_INFO_SIZE. Since it is unused, remove it.
Change-Id: I6c8069f0ce420fbe08d4e2527ce94f5c906027c6
CRs-Fixed: 2368718
The following macros have neer been used by the current version of the
driver, so remove them:
- HDD_P2P_WILDCARD_SSID
- HDD_P2P_WILDCARD_SSID_LEN
Change-Id: Ice446d0e6a9f6a1e95b16267a3cb6aebf85cf5ad
CRs-Fixed: 2368717
Change I8ba344ce5593df44bd15527e2ff68e872b6d23b8 ("qcacld-3.0: TDLS:
remove legacy core functions") removed the only reference to macro
HDD_CHANNEL_14. Since it is now obsolete, remove it.
Change-Id: I41267b0e5aef8f60c8a48cd9154529b2689bab5f
CRs-Fixed: 2368716
Change I2e2380b1789cce7841ff0be4120184d1bce0b7e7 ("qcacld-3.0: TDLS:
remove legacy event process") removed the "real" implementation of
hdd_roam_tdls_status_update_handler() but left behind the stub
implementation, so remove the stub as well.
Change-Id: I4862a4cb2b27323c0bb7fb69e6033eaf2a0375b5
CRs-Fixed: 2368715
Change I0fa178bc92bc2a02e45d1ec577f9a54f40d559fb ("qcacld-3.0: Remove
wlan_hdd_tdls_set_params() prototype") removed the last reference to
struct hdd_tdls_config_params. Since it is obsolete, remove the
struct.
Change-Id: I3b5dfc94e17ba1f5b490d10593ba10fd6e33d3f5
CRs-Fixed: 2368714
Change Idaaacac4fdaf1b964432c33c10b1c86f8a591c2d ("qcacld-3.0: Remove
legacy P2P codes in HDD") removed the only reference to macro
WLAN_HDD_80211_PEER_ADDR_OFFSET. Since it is obsolete, remove it.
Change-Id: I5a298200fc007472651fdab5ded64fb1ee730636
CRs-Fixed: 2368713
Change I5af85d68ee53ad557e64523f7a1719e328536926 ("qcacld-3.0: Update
for converged NAN config params") relocated the NAN INI parsing.
However the change failed to remove the stub implementations of the
following functions, so remove them now:
- hdd_nan_populate_cds_config()
- hdd_nan_populate_pmo_config()
Change-Id: Ic2e7ed3e9a30fb20541734c0a72b55e6478877cf
CRs-Fixed: 2368712
Change I45181908a6a81de21e4ba906f54ae3190aa212d0 ("qcacld-3.0: Use
common scan api to wait on scan to get completed") removed the logic
that used macro WLAN_WAIT_TIME_ABORTSCAN. Since the macro is obsolete,
remove it.
Change-Id: Ie367743e2ba98bac9f554732682d8430c4016c42
CRs-Fixed: 2368711
The TDLS functionality has moved to its own component. Left behind in
HDD were the following macros which are now obsolete, so remove them:
- WAIT_TIME_TDLS_LINK_ESTABLISH_REQ
- WAIT_TIME_TDLS_MGMT
Change-Id: Ie9667cafc66975e2cd92265353a8299cb5dff441
CRs-Fixed: 2368708
Change I2fa509f53b47d65ba0f4abbc438834b85b9c21f6 ("qcacld-3.0: Report
more information in survey dump") removed the legacy survey code that
utilized the survey_idx field in struct hdd_adapter. Since the field
is now obsolete, remove it.
Change-Id: I59653739949692eee4c15d5db1db386deb2d4182
CRs-Fixed: 2368707
Since they are now unused remove the hdd_ipa field from struct
hdd_context and the ipa_context field from struct hdd_adapter.
Change-Id: Iec841efdd3aa0f16298c0c58ce5756b325563b34
CRs-Fixed: 2368706
Change Iaa1934594d5ffcf3b90dd2ad41bba4eb62f71119 ("qcacld-3.0: Fix
memleak for pm runtime suspend lock") removed the only usage of struct
hdd_connect_pm_context. Since the struct is obsolete, remove it.
Change-Id: If6e043e3aa2c76bcef6ae63858c5bf51fdfa8d09
CRs-Fixed: 2368705
Change Iebded11869c55c1797f0521af05585284f46f544 ("qcacld-3.0:
Relocate legacy DP INI items") removed the only references to
TX_SCHED_WRR_PARAM_STRING_LENGTH. Since it is now unused, remove it.
Change-Id: I0d6729af053a543f23b45ef84371886812414870
CRs-Fixed: 2368704
As part of change I374e870610d79cc0d172ae126bfa70dc6d2db9a9
("qcacld-3.0: Remove not used INI CFG") support for the INI item
"gSapSccChanAvoidance" was removed. However that change left behind
the SapSccChanAvoidance field in struct hdd_config. This is now
obsolete, so remove it.
Change-Id: I4950066f492417922ec4054938da1e9acfaf9668
CRs-Fixed: 2368703
NAN component has been moved to CLD. It includes implementation
of the new NAN command QCA_NL80211_VENDOR_SUBCMD_NAN_EXT.
Change the legacy NAN implementation of vendor cmd
QCA_NL80211_VENDOR_SUBCMD_NAN so that the requests go
through the NAN component. Clean up the legacy path.
Functionality remains unchanged for legacy command.
Route the legacy NAN commands through the NAN component.
Change-Id: I542e5afe832619f8c088220cc4456aa7fe4416fd
CRs-Fixed: 2356772
As part of supporting NAN DBS, new WMI TLVs are defined so
that Host can maintain the status of NAN Discovery in sync
with the Firmware. Add modules that process these events and
updates the NAN states.
Add support for handling the NAN events.
Change-Id: Icfcd9c33cc410d9a65140f63cac69ddd69742306
CRs-Fixed: 2355383
Host will receive the NAN related service capabilities from
the SERVICE_AVAILABLE event. In the HDD callback that gets
called afterwards, set the NAN related capabilities into
the NAN's private PSOC object.
Store the NAN target capabilities inside its private object.
Change-Id: If398b6f253613fc424b7821cfc62b0984ad34b6c
CRs-Fixed: 2356709
As part of the NAN Discovery DBS support, a new vendor command
- QCA_NL80211_VENDOR_SUBCMD_NAN_EXT - has been defined that can
carry the binary blob encapsulated within an attribute and can
carry additional attributes to enhance the NAN command interface.
Add related data structures in NAN component and add modules in
OSIF to parse and sanitize this new command data and forward
the NAN message to the NAN component.
Add support for the new NAN EXT vendor command.
Change-Id: I0e6bb833b01a8cbd65e4d42700b5b70599f3ef99
CRs-Fixed: 2339029
