Sometimes TXRX_PRINT is taking more time to process as
some other printks' are already in progress. As this TXRX_PRINT is
inside spinlock, so when some other core is also competing for
this spinlock, that core keeps iterating in a loop. After some
time spinlock bug is triggered as it is suspected that this core
is locked on this spinlock.
To fix this, move the TXRX_PRINT outside spinlock so that the other
core don't have to wait to acquire spinlock due to this TXRX_PRINT.
CRs-Fixed: 1107213
Change-Id: Ie6f8a7c8f9731883c2440641b8b9542f9d40c4a9
Include missing header file to fix the undefined API compilation
error and removed unused variable.
CRs-Fixed: 1107859
Change-Id: I4dcf1b0bb19662ba2c1f3af197ca34b656be7d9a
We want to enable the compiler's -Wmissing-prototypes switch, but
there is existing code in ol_tx_queue.c which is generating warnings
because not all public APIs have prototypes defined. Define the
missing prototypes for:
ol_txrx_vdev_flush()
ol_txrx_vdev_pause()
ol_txrx_vdev_unpause()
ol_tx_throttle_set_level()
ol_tx_throttle_init_period()
In addition make the following private since they are now only called
internally to ol_tx_queue.c:
ol_tx_pdev_peer_bal_timer()
ol_tx_queue_log_alloc()
ol_tx_queue_display()
Change-Id: I4a3d767c650eefc39c3bf51ce102c8b5de391ec5
CRs-Fixed: 1104127
We want to enable the compiler's -Wmissing-prototypes switch, but
there is existing code which is generating warnings because not all
public APIs have prototypes defined. Define the missing prototype for
ol_txrx_flow_control_cb().
Change-Id: Ifb7fff891b237e6202cc96afd3ab2e21bc4f13aa
CRs-Fixed: 1104126
We want to enable the compiler's -Wmissing-prototypes switch, but
there is existing code in ol_tx.c which is generating warnings because
not all public APIs have prototypes defined. Define the missing
prototypes for:
ol_tx_send_ipa_data_frame()
ol_tx_non_std()
ol_txrx_mgmt_tx_cb_set()
ol_txrx_mgmt_send_ext()
In addition make the following private since they are now only called
internally to ol_tx.c:
ol_tx_non_std_ll()
ol_tx_non_std_hl()
Change-Id: I29f334de30ab492f2ef6c422352d11c059e40f1b
CRs-Fixed: 1104125
We want to enable the compiler's -Wmissing-prototypes switch, but
there is existing code in ol_cfg.c which is generating warnings
because not all public APIs have prototypes defined. Define the
missing prototypes for the following:
ol_pdev_cfg_attach()
ol_set_cfg_rx_fwd_disabled()
ol_set_cfg_packet_log_enabled()
Change-Id: I787d4d7954751cda2878229d1d8967e1c168f95c
CRs-Fixed: 1104124
Currently the qcacld-3.0 driver does not build cleanly when compiled
with the gcc -Wmissing-prototypes switch. One set of warnings is due
to the QCA_COMPUTE_TX_DELAY APIs not being exported properly. Address
the warnings by properly exporting these functions.
Change-Id: Ib0f8a43a4575caf5714709e7fab659aa0b6f3009
CRs-Fixed: 1103659
Currently the qcacld-3.0 driver does not build cleanly when compiled
with the gcc -Wmissing-prototypes switch. One set of warnings is due
to ol_tx_set_flow_control_parameters() not being exported properly.
Address the warnings by properly exporting this function.
Change-Id: Iec79c1684c74312fa121349c1d7f721666bf904a
CRs-Fixed: 1103127
We want to enable the compiler's -Wmissing-prototypes switch, but
there is existing code that is generating warnings. Fix all warnings
in core/dp/txrx.
Change-Id: Ib6ad0a6414456e2b4c6b881b94d716843cdf24cc
CRs-Fixed: 1091496
We want to enable the compiler's -Wmissing-prototypes switch, but
there is existing code that is generating warnings. Fix all warnings
in core/dp/htt.
Change-Id: I189ca782bdcae7d8d3a6f54acd1baf15f3f300f6
CRs-Fixed: 1091016
The following HTT debug functions are not being used:
htt_rx_print_rx_indication()
htt_rx_hash_dump_table()
Delete these obsolete functions.
Change-Id: I8f47cd9706749acdb55736edd1876813bb3177fb
CRs-Fixed: 1091016
Use QDF_BUG to create a crash dump when peer attach operation detects
that the peer already exists even after waiting for 500 ms. It will
detect failure to complete peer delete operation in firmware and
missing peer unmap events.
Crash dump is enabled only when compiled with PANIC_ON_BUG, otherwise
it will print a warning.
CRs-Fixed: 1075798
Change-Id: I0131f4f706bc76feb86894975ff9f3c30f873b9b
This reverts Change-Id I2aec7253511d2ca7b08ca77d858a46f9c01d4e9d
Adding support for dumping 32 tx/rx packets during connection
by reverting above change as "exceeding skb buffer size and
leading to crash" issue is resolved with this change.
Change-Id: I951355776461706bb52eeee0527819377e7b7857
CRs-Fixed: 1097280
In some cases, this TXRX_PRINT is taking more time to process as
some other printks' are already in progress. As this printk is
inside spinlock, so when some other core is also competiting for
this spinlock, that core keeps iterating in a loop. After some
time spinlock bug is triggered as it is suspected that this core
is locked on this spinlock.
This fix moves the TXRX_PRINT outside spinlock so that the other
core don't have to wait to acquire spinlock due to this printk.
Change-Id: Ie0fa7addd4f2a1272a4d5e287635b6a0f016ba97
CRs-Fixed: 1095406
Log rx frag/tkip mic error packet in packetlog as per
rx frag indication message from firmware.
Change-Id: I4670c070e5affc5bf5b9f5ded23721e464a45737
CRs-Fixed: 1074043
Fix a race condition where the HTT peer map event is received before
the peer object is allocated in the data path.
CRs-Fixed: 1089662
Change-Id: I3931e6dbae3ec3a68d446c245432549fa635a97e
Fix improper naming and exporting of dump_pkt() by:
1) adding ol_txrx prefix in the api
2) adding prototype of api to ol_txrx.h and removing the local
prototype for the api from core/dp/txrx/ol_tx_desc.c
CRs-Fixed: 1093667
Change-Id: I14e547223f8c96f10897aa6dc5c9781018a4d986
qcacld-2.0 to qcacld-3.0 propagation
Add sanity check for tx desc to avoid crash if firmware report the invalid
msdu id to the host.
Change-Id: I5a339e81f3de882b5f7cc42b0628ea4738141c58
CRs-Fixed: 1071620
Remove legacy apis call from out side of data path.
Replace legacy apis to cdp apis.
Introduce cdp apis wrappers.
dp module.
Change-Id: I345abb70b6ddd7f5768cea2d933e0023c5742b4a
CRs-fixed: 1075736
Make changes for per per Rx context LRO manager, this addresses
all parallel Rx concurrency issues. There by removes all the contention.
Change-Id: I3609bcdb67e0046fac5a22bba9cb6a5eb4bcbe84
CRs-Fixed: 1079320
qcacld-2.0 to qcacld-3.0 propagation
Fail to allocate local peer id when connecting the last 32th station in
AP+AP mode. The reason is the OL_TXRX_NUM_LOCAL_PEER_IDS is defined to 33,
but each AP's peer will occupy one ID. So the remainder are not enough,
change this macro to 34 will fix this issue.
Change-Id: Ie5b63b6885fd7f2d4f941b6ffad43cbac57040e5
CRs-Fixed: 1085367
This reverts Change-Id Icd08475c3f81aa182c902b8e8defbdb904c5509d
Above change was exceeding skb buffer size and leading to crash.
For now removing the support for dump Tx/Rx packets during connection.
Change-Id: I2aec7253511d2ca7b08ca77d858a46f9c01d4e9d
CRs-Fixed: 1083912
Fix 32 bit compilation issues due to improper shift operation.
Also make bitwise operations compatible with 32-bit.
CRs-Fixed: 1085499
Change-Id: Ifceefb52cfc5b89ca3e1eb0b428b34a5f7f792dc
qcacld-2.0 to qcacld-3.0 propagation
Add packet length check for HTT_T2H_MSG_TYPE_RX_FRAG_IND message.
Do not clone the RX frag buffer in the ol_rx_fraglist_insert, and all
buffer will be freed by ol_rx_frag_indication_handler or upper layer to
avoid double free issue.
Change-Id: I977ed9109a476a092dfb298386625a707bc98191
CRs-Fixed: 1039135
When firmware sends WMI_ROAM_REASON_HO_FAILED event to host,
it has already deleted the peer. Host should not send peer
and vdev cleanup commands to firmware.
Add disassoc_reason field to roamCmd to indicate that CSR wants to
disconnect because of ROAM_HO_FAIL. Copy that information to PE
session, send it to WMA using WMA_DELETE_BSS_HO_FAIL_REQ.
Add wma_delete_bss_ho_fail() to take care of driver state cleanup
without sending commands to firmware.
CRs-Fixed: 1083649
Change-Id: Icdd7571214ea5510c0cdbc44c69d6b5060f5892c
Recently the following change removed the only reference to function
ol_txrx_ipa_uc_fw_op_event_handler():
Change-Id Iae45c059006592293ea61d04be89b1477daae514
"qcacld-3.0: Fix HTT_T2H_MSG_TYPE_WDI_IPA_OP_RESPONSE handler"
Since the function is now obsolete, remove it.
Change-Id: I10d8ee7ef9a97d1eb5283e08c786826005fbd335
CRs-Fixed: 1075151
Fix improper naming and exporting of dump_frag_desc() by:
1) adding ol_txrx prefix in the api
2) adding prototype of api to ol_tx.h and removing the local
prototype for the api from core/dp/txrx/ol_tx_desc.c
Change-Id: I29a06419164afba7c1c391d11aee10742d41b93c
CRs-Fixed: 1083068
(cherry picked from commit bcc6b34818654241a4886b35619fb5e901f6f10b)
Enable logging of DPTRACE logs at each layer of driver and at tx
completion for all tx as well as rx protocol packets.
Change-Id: Id568c19196702034989a0f55490bc62667b3b20e
CRs-Fixed: 1083002
(cherry picked from commit c91cad24c240283aa70b120836799014c820975f)
Add a spinlock to make sure that htt rx_hash history buffer will
not break under SMP conditions. Apply the lock on set and reset operations.
Add timestamp to each buffer entry (will store the time stamp of the last
operation on the entry).
Change-Id: If1dcab4ac331351cf2dcfbaa6cb24d453e7fdf50
CRs-Fixed: 1077047
(cherry picked from commit be2d6e14afdc142564bb9d7fbcc446c060b0d0d4)
Fix memory leak:
1) during driver shutdown as netbufs associated with
outstanding descriptors at the time of driver shutdown
are not getting freed.
2) in ol_tx_ll_fast where in case packet fails to download,
descriptor is being freed but the netbuf associated with
it is not getting freed.
Change-Id: I6c3eaf551149078f1ecd1329d5f3fe8ab36c2f34
CRs-Fixed: 1081206
(cherry picked from commit 2e5ea6c3489e8ef40e07c45d0f8e244bbd6bee7f)
Pass correct parameter(msdu in place of head_msdu) in
ol_rx_send_pktlog_event in ol_rx_indication_handler.
Change-Id: I11c3fcf038b1b8242733bc19889d550fdf4a5766
CRs-Fixed: 1082515
(cherry picked from commit 97632b4f075245c93b348dfd2ed76b5b14bb9a5c)
Propagation from qcacld-2.0 to qcacld-3.0.
Fix DPTRACE implementation in rx path by setting
QDF_NBUF_CB_TX_PACKET_TRACK for data packet to
QDF_NBUF_TX_PKT_DATA_TRACK in
ol_rx_offload_paddr_deliver_ind_handler.
Change-Id: Iab77f19ee0040d601b3e91013d08a04362b3d4a9
CRs-Fixed: 1074435
(cherry picked from commit be3a5cd2e00aff5552dd4d55e199c5452b7b5c1b)
Propagation from qcacld-2.0 to qcacld-3.0.
Add changes to send 32 tx/rx packets to HAL layer during connection.
This can help in debugging connection related issues.
Change-Id: Icd08475c3f81aa182c902b8e8defbdb904c5509d
CRs-Fixed: 959645
(cherry picked from commit 45416eeee7dde24f1456e0c2b667e8147742f054)
qcacld-2.0 to qcacld-3.0 propagation
Currently TXQ of DEFAULT_MGMT packet is using TID
HTT_TX_EXT_TID_MGMT when we inserted into Scheduler, so use
same TID when we flush it.
Change-Id: I1631b7706d1f8bf0352ceecb8836d82743526e44
CRs-Fixed: 1000968
(cherry picked from commit 9b41b24a9da6b9415ebdafb6e4574f0b03570e9e)
qcacld-2.0 to qcacld-3.0 propagation
Currently FW does not indicate wow wake up frame to host for
HL project. After the change, FW will indicate wake up frame
with HTT_T2H_MSG_TYPE_RX_OFFLOAD_DELIVER_IND htt msg and host
will handle this message to indicate to OS protocol stack.
Change-Id: I5f4446de7ec3c4ff1c1de6fd6105429e0898291c
CRs-Fixed: 956416
(cherry picked from commit b5cb00e05b1db94a2869cc5becef3d777dbd560e)
Changed the API to support per vdev firmware statistics.
This API change is needed by the WIN team.
Change-Id: If50a767e031e6f203abc01e3dfa26dc59249bb95
CRs-Fixed: 1057751
Propagate from qcacld-2.0 to qcacld-3.0
Add htt_htc_pkt_free() in htt_h2t_dbg_stats_get() to avoid memory
leak in the error case.
Change-Id: Ie0cd4939706046370c7a0ce4053be1103637f769
CRs-Fixed: 979671
When both host and FW support a new partition, FW uses host use
the new parition HTT_TX_IPA_NEW_MSDU_ID_SPACE_BEGIN.
If FW doesn't support a new partition, host falls back to use old
HTT_TX_IPA_MSDU_ID_SPACE_BEGIN.
Handshaking is done through WMI_READY and WMI_INIT.
Change-Id: I974c931e1b4b2d84e809ec19537a09b679932568
CRs-Fixed: 1072812
Add the following statistics for LRO
- packet count based on the number of packets aggregated
- total number of LRO eligible and ineligible TCP packets
- total number of packets aggregated
- total number of flows flushed
- number of times an LRO descriptor was not found
Change-Id: Icea6b7745df9bda5b517c1a7f27c8395ede2cec6
CRs-Fixed: 1042116
Currently we are queuing the message into rx thread for processing even
if the RX thread is not enabled.
Solution: Donot queue the message into Rx thread. Call the
callback function directly (registered during
ol_txrx_ipa_uc_register_op_cb)
Change-Id: Iae45c059006592293ea61d04be89b1477daae514
CRs-Fixed: 1075151
Roam_synch indication processing in host performs peer detach/attach
operations after firmware has already moved to the new peer. Out of
sequence peer unmap and map events can mess up the reference count
for reused peer_id values, which can lead to crash.
Solution:
While detaching a peer during roam sync indication processing,
copy its peer_id_ref_cnt in peer_id_to_obj array to new variable
in the same peer map for that peer id. Peer is deleted at that point.
When the unmap events come in, decrement the old ref_cnt and
map events increment the real ref_cnt.
Once the old ref_cnt goes to 0, subsequent unmap operations apply to
the real peer.
CRs-Fixed: 1063177
Change-Id: I9b20f28f17dea1647a213b9f36060109264addf0
Improper use of qdf_event_create caused QDF_ASSERT. Use qdf_event_reset
in ol_txrx_peer_attach(). Use correct comparison for return value
of qdf_wait_single_event().
CRs-Fixed: 1065451
Change-Id: I735fe12230b6558123f73d68f09fd126bf0406d6
Wrong use of runtime get results in mismatch in runtime pm usage count.
Hence fix it by calling runtime put API instead of get API.
Change-Id: I89dfcd2d1ad980df47f2244c9fcac5a68ac27d71
CRs-Fixed: 1072520
skb->cb has different meaning for rx & tx packets. Reset the
cb to avoid mis-interpretation of the data that leads to
eratic misbehavior the least of which is failure to forward
packets.
Change-Id: I5d1396c70cd93d165aa825c4408ad46d082693f3
CRs-Fixed: 1065769
qdf_mem_cmp api returns zero when comparison string matches
else returns non zero. Checking return value with true/false
can cause confusion and errors.
Replace the return value check from true/false to
zero/non-zero values.
Change-Id: I485d69a4bf85d1e6273ea780af6d0423c3910686
CRs-Fixed: 1066946
