Commit Graph

195 Commits

Author SHA1 Message Date
Jeff Johnson
9a472f7f85 qcacld-3.0: Rename SAP identifier pconfig
The Linux Coding Style frowns upon so-called Hungarian notation, so
rename SAP identifier pconfig to be compliant.

Change-Id: I2d0ef46cf8f9972ca16592e7d8799ab8592b04a0
CRs-Fixed: 2422213
2019-03-25 22:17:25 -07:00
Jeff Johnson
8f8ceb9ac8 qcacld-3.0: Replace typedef tsap_config_t
The Linux Coding Style enumerates a few special cases where typedefs
are useful, but stresses "NEVER EVER use a typedef unless you can
clearly match one of those rules." The tsap_config_t typedef does not
meet any of those criteria, so replace it with the underlying struct.

Change-Id: I95d9ad30d9af35dc4572d70c555b24b0285f8b2d
CRs-Fixed: 2422212
2019-03-25 22:17:19 -07:00
Jeff Johnson
7dcac7ecbf qcacld-3.0: Rename SAP Event Callback identifiers
The Linux Coding Style frowns upon mixed-case names and so-called
Hungarian notation, so rename SAP Event Callback identifiers
tpWLAN_SAPEventCB, pfnSapEventCallback, pSapEventCallback, and
pacs_event_callback to be compliant.

Change-Id: I6ce97af649c73dd779b23c7ec4f0192f28d0f00a
CRs-Fixed: 2422210
2019-03-25 20:40:33 -07:00
Jeff Johnson
2284ad9c47 qcacld-3.0: Rename SAP identifier pUsrContext
The Linux Coding Style frowns upon mixed-case names and so-called
Hungarian notation, so rename SAP identifier pUsrContext to be
compliant.

Change-Id: Ib9c4cac6eb6f813e4da66c1c65bab16cebf62946
CRs-Fixed: 2422209
2019-03-25 20:40:26 -07:00
Jeff Johnson
eb704c070e qcacld-3.0: Rename SAP identifier pConfig
The Linux Coding Style frowns upon mixed-case names and so-called
Hungarian notation, so rename SAP identifier pConfig to be compliant.

Change-Id: I7618b95b3d88c2306412eb8d1f55dcc6cfd1a476
CRs-Fixed: 2422208
2019-03-25 20:40:19 -07:00
Jeff Johnson
72577c82a6 qcacld-3.0: Rename SAP identifier pDelStaParams
The Linux Coding Style frowns upon mixed-case names and so-called
Hungarian notation, so rename SAP identifier pDelStaParams to be
compliant.

Change-Id: I034f0157fe4016bbcacf3ce652035a3a13184f90
CRs-Fixed: 2422207
2019-03-25 20:40:12 -07:00
Jeff Johnson
8329f33bc8 qcacld-3.0: Rename SAP identifier sapContext
The Linux Coding Style frowns upon mixed-case names so rename SAP
identifier sapContext to be compliant.

Change-Id: If3d09c63141077247635315186068cabab396612
CRs-Fixed: 2422206
2019-03-25 20:40:05 -07:00
Ashish Kumar Dhanotiya
6025c701f7 qcacld-3.0: Cache supported mode of connected STA for SAP
Currently in case of SAP, supported mode of station received
in assoc request is not getting cached.

Add support to cache the supported mode of station received
in assoc request request in sta_info.

Change-Id: I9820ae2d65fc529a1ab16424f6732fd273da3ae0
CRs-fixed: 2419957
2019-03-22 13:33:34 -07:00
Srinivas Girigowda
b8fdc643d2 qcacld-3.0: Consolidate multiple MAX_SSID_LEN to WLAN_SSID_MAX_LEN
Consolidate multiple MAX_SSID_LEN to WLAN_SSID_MAX_LEN.

Change-Id: I1764b891501c4e3371cf478c324ebcdcab319f5f
CRs-Fixed: 2419367
2019-03-20 22:09:45 -07:00
Srinivas Girigowda
cf161406dd qcacld-3.0: Use converged qcacmn macros (part 1)
Replace the existing qcacld-3.0 macros with qcacmn converged
macros.

Change-Id: Ie05f396fcd2e01cf86256f25dbc171bbdf763da9
CRs-Fixed: 2416429
2019-03-19 02:24:23 -07:00
Jeff Johnson
4338caad72 qcacld-3.0: Replace typedef tSap_Event
The Linux Coding Style enumerates a few special cases where typedefs
are useful, but stresses "NEVER EVER use a typedef unless you can
clearly match one of those rules." The tSap_Event typedef does not
meet any of those criteria, so replace it (and the "tp" variant) with
a reference to the underlying struct.

Further note the Linux Coding Style frowns upon mixed-case names and
so-called Hungarian notation, so in conjunction rename the underlying
struct to be in compliance.

Change-Id: I523f8642ef81b3e35b2bb7a2801f3b734b2f5865
CRs-Fixed: 2412716
2019-03-09 02:28:46 -08:00
Jeff Johnson
04739e334c qcacld-3.0: Remove RSNAuthType from struct sap_config
The RSNAuthType field in struct sap_config is unused, so remove it.

Change-Id: Id60840b00ae30b243f46ba51a5840cb29a17dc1a
CRs-Fixed: 2411671
2019-03-08 10:47:56 -08:00
Abhishek Singh
8f4aa18225 qcacld-3.0: Fix vdev ref leak in P2P-GO during SSR
If P2P-GO is active and SSR happens the vdev ref coount taken
by sap_ctx is not released and this lead to ref count leak.

To fix this release vdev ref count for sap_ctx in
hdd_reset_all_adapters().

Change-Id: Id35247a917f3e0c3e163ea00a7a850cdf28ddd80
CRs-Fixed: 2410121
2019-03-06 16:56:17 -08:00
Jeff Johnson
93107ad75f qcacld-3.0: Rename HDD variable pStaCtx
The Linux Coding Style frowns upon mixed-case names and so-called
Hungarian notation, so rename HDD local variable pStaCtx to be
compliant.

Change-Id: Ief8942a12c802720d5eb2819e85eb895c6d8df40
CRs-Fixed: 2405752
2019-02-27 11:37:34 -08:00
Min Liu
0daa098737 qcacld-3.0: Handle OWE info update from hostapd
Handle OWE info update from hostapd in the following path:
HDD->SAP->SME->CSR

Change-Id: I7584fb5db036d1643bd7d56076d30a0c75008a98
CRs-Fixed: 2397009
2019-02-27 08:11:47 -08:00
Min Liu
e34708a91d qcacld-3.0: Send update OWE info event
When receiving assoc request from OWE STA, always send update OWE
info event which contains the following information:
- MAC address of STA
- RSN IE in assoc request
- DH IE in assoc request

Change-Id: I7017c5d2730e493db2472ae53d5dfa69553cfe45
CRs-Fixed: 2396925
2019-02-27 08:11:42 -08:00
Min Liu
ddd233069e qcacld-3.0: Save RSN auth type for RSN association
Save RSN auth type in related context for RSN assocoation.
Some OWE specific operation need to be done according to
this RSN auth type since we cannot tell if a STA / SAP is OWE,
WPA2 or OPEN by its auth type OPEN.

Change-Id: I17dd72c7adf1c663725ac58ce263f4408d9c967b
CRs-Fixed: 2396885
2019-02-25 18:43:42 -08:00
Pragaspathi Thilagaraj
2720d81efe qcacld-3.0: Send all assoc request IE to hostapd in SAP mode
Host driver packs only the RSN IE, WAP IE and additional IE
from association request to upper layers. With any new IE
support added on the driver, the driver has to add new structure
to csr_roam_info and pack that IE into the
tSap_StationAssocReassocCompleteEvent and pass it to higher
layers. This increases the redundancy with new IE introduced.

To facilitate hostapd to get information on all IE, pass all the
IE present in the assoc request to hostapd.

Change-Id: I1665a83de52bd67529ea026dc0c5e92cfbd51590
CRs-Fixed: 2390425
2019-02-20 07:42:04 -08:00
Jeff Johnson
6ed8018b5c qcacld-3.0: Remove eSAP_ASSOC_STA_CALLBACK_EVENT handling
Change Iea602a1da42d5eecafae1d00f2260f4930128f40 ("qcacld-3.0: Remove
eWNI_SME_GET_ASSOC_STAS_REQ handling") removed the logic that sent the
eSAP_ASSOC_STA_CALLBACK_EVENT event. Since this event is obsolete,
remove the handling code from SAP and HDD.

Change-Id: I49e169a1832845bac4e89cd832d72dec42d4ee09
CRs-Fixed: 2396058
2019-02-11 23:56:52 -08:00
Jeff Johnson
a7d5b54c7e qcacld-3.0: Replace typedef tSirSmeChanInfo
The Linux Coding Style enumerates a few special cases where typedefs
are useful, but stresses "NEVER EVER use a typedef unless you can
clearly match one of those rules." The tSirSmeChanInfo typedef does
not meet any of those criteria, so replace it (and the "tp" variant)
with a reference to the underlying struct.

Further note the Linux Coding Style frowns upon mixed-case names and
so-called Hungarian notation, so in conjunction rename the underlying
struct to be in compliance, as well as to be more specific on how the
struct is used.

Change-Id: Ic9a596d05a7c4c0727264c33e865edd4a9786dac
CRs-Fixed: 2394998
2019-02-09 18:02:47 -08:00
Abhinav Kumar
338e57d779 qcacld-3.0: Avoid VDEV restart for SAP when roaming in progress
Currently, driver allows VDEV-RESTART on SAP interface in order to
channel switch or hidden ssid connection when roaming is in progress
on STA interface. This leads to two simultaneous vdev starts or
vdev-restart in FW which causes the FW to assert.

Add changes to reject the channel switch for SAP or in hidden ssid
connection if roaming is in progress on any STA interface.

Change-Id: I1cea389021049779b5aa00145e2470cd67158edd
CRs-Fixed: 2390235
2019-02-06 17:12:36 -08:00
Jeff Johnson
ecd4f21b4a qcacld-3.0: Replace typedef tSirSupportedRates
The Linux Coding Style enumerates a few special cases where typedefs
are useful, but stresses "NEVER EVER use a typedef unless you can
clearly match one of those rules." The tSirSupportedRates typedef does
not meet any of those criteria, so replace it (and the "tp" variant)
with a reference to the underlying struct.

Further note the Linux Coding Style frowns upon mixed-case names
and so-called Hungarian notation, so in conjunction rename the
underlying struct to be in compliance.

Change-Id: I5007379a50223b6de85830e7ae389e65cdb8e4d3
CRs-Fixed: 2392398
2019-02-06 04:25:07 -08:00
Ashish Kumar Dhanotiya
c617106eea qcacld-3.0: Add support to cache peer capability info
Currently connected peer capability information is not getting
cached for SAP.

Add support to cache the capability info from assoc request

Change-Id: I0088bd20a98e2491f6ffb452417bc73f21e69e63
CRs-Fixed: 2392939
2019-02-05 06:29:30 -08:00
Dustin Brown
b4260d5e38 qcacld-3.0: Simplify pre-cac flush prevention
Change I875c2f14ffd54272fc9ea0df1cecc6dd1171e310 introduced an elaborate
workaround to prevent the pre-cac work from flushing itself during stop
adapter. Introduce a less complicated work around by simply checking if
the current adapter is the pre-cac adapter before flushing the pre-cac
work.

Change-Id: Ib3e0716f8d088d124e960dcd724f579fb39a3d74
CRs-Fixed: 2387173
2019-01-28 01:57:10 -08:00
Jeff Johnson
89748dc3d1 qcacld-3.0: Remove tSap_ManagementFrameInfo
Change Ib83700825112cc52dade594909bfa8993909ac29 ("qcacld-3.0: Send
management frame indication directly to HDD from PE") removed the
usage of tSap_ManagementFrameInfo. Since this struct is obsolete,
remove it.

Change-Id: Ic10c150286fe9f998884cdfcb8da2edadee7e156
CRs-Fixed: 2380771
2019-01-18 16:35:42 -08:00
Jeff Johnson
034649dbd7 qcacld-3.0: Remove requestedMCRate from tSap_AssocMacAddr
The requestedMCRate field in tSap_AssocMacAddr is unused,
so remove it.

Change-Id: If5ae0df5f84c99e3684df3cac75d32d63227d5ce
CRs-Fixed: 2380770
2019-01-18 16:35:38 -08:00
Jeff Johnson
ec828e6c62 qcacld-3.0: Remove last_radar_found_channel from tSapDfsInfo
The last_radar_found_channel field in tSapDfsInfo is unused,
so remove it.

Change-Id: I7afb516b01f5f696ea9fb9ad386daf2b0767e754
CRs-Fixed: 2380769
2019-01-18 16:35:34 -08:00
Jeff Johnson
c7429e600c qcacld-3.0: Remove ht_op_mode_fixed from struct sap_config
The ht_op_mode_fixed field in struct sap_config is unused,
so remove it.

Change-Id: Ie85a99d793c964dec493432b7680eb469a20a364
CRs-Fixed: 2380768
2019-01-18 16:35:30 -08:00
Jeff Johnson
7700a964a9 qcacld-3.0: Remove ampdu_size from struct sap_config
Change I9d05cd7b8e051c4e9e4912cf866206ae32ec293d ("qcacld-3.0: Define
data structures for new AP requirements") added the ampdu_size field
to struct sap_config. However logic to use this field was never added,
so remove the field since it is unused.

Change-Id: I183766da3af3a3e9c609ccde95a0cca561813226
CRs-Fixed: 2380767
2019-01-18 16:35:25 -08:00
Jingxiang Ge
1a16551c90 qcacld-3.0: Revert "qcacld-3.0: Check if gp_sap_ctx is empty after reinit"
This reverts commit I77708d296fb218ca53ac656f844d02f58e23d241

Change-Id: I564d7858576af09e0a0d9d89f569a7b09ce72a84
CRs-Fixed: 2381581
2019-01-16 19:35:21 -08:00
Wu Gao
aa15514706 qcacld-3.0: Change WNI_CFG_COUNTRY_CODE_LEN to CFG_COUNTRY_CODE_LEN
All WNI configurations will be cleanup based on new cfg framework, so
change Change WNI_CFG_COUNTRY_CODE_LEN to CFG_COUNTRY_CODE_LEN.

Change-Id: I786b62e2c0aff08a89fc3c8a3359e2ffb4044269
CRs-Fixed: 2380488
2019-01-14 21:47:20 -08:00
Jingxiang Ge
b5fb05be39 qcacld-3.0: Check if gp_sap_ctx is empty after reinit
In SSR, after reinit, there is still memory leak
for gp_sap_ctx; As in multi SSR test, memory leak
detection is disabled in recovery mode, it is a
little late to get the issue moment.

Check gp_sap_ctx after stopping all adapter in
hdd_is_interface_down_during_ssr.

Change-Id: I77708d296fb218ca53ac656f844d02f58e23d241
CRs-Fixed: 2377718
2019-01-12 01:28:29 -08:00
Jeff Johnson
a2a04c7b4c qcacld-3.0: Remove sap_roc_ind from tSap_Event
Change I83a704d3f03e9cb9e6a7420f32d609a323799a12 ("qcacld-3.0: Remove
legacy P2P codes in SAP") removed the usage of the sap_roc_ind field
in tSap_Event. Since it is obsolete, remove the field along with the
underlying struct sap_roc_ready_ind_s.

Change-Id: I6101ec7874825b8e4e2e891c3f8ae084486eef87
CRs-Fixed: 2378326
2019-01-11 13:36:57 -08:00
Yeshwanth Sriram Guntuka
261ac4d56e qcacld-3.0: Remove redundant logic in csr_is_valid_channel
sapDfsChannelNolList and numCurrentRegDomainDfsChannels
fields in sap dfs info is not populated and is used in
csr_is_valid_channel.

Fix is to remove the redundant logic in csr_is_valid_channel.

Change-Id: Ib98423ba910a1947a908f4a74762f82183aa89d5
CRs-Fixed: 2374080
2019-01-09 10:34:56 -08:00
Jeff Johnson
22e2026036 qcacld-3.0: Remove vendor_ie_access_policy from sap_config
Change "I9d05cd7b8e051c4e9e4912cf866206ae32ec293d" ("qcacld-3.0:
Define data structures for new AP requirements") added the
vendor_ie_access_policy field to struct sap_config, but subsequently
no code was added which actually utilizes this field. Since it is
unused, remove it, along with the underlying enumeration.

Change-Id: I7a3661a50ef17b0452e87e0ed86c3826b3bd199d
CRs-Fixed: 2375528
2019-01-08 15:31:37 -08:00
Jeff Johnson
9661fc978d qcacld-3.0: Remove sapGetWPSPBCSessionEvent from tSap_Event
Change I9d83f66bce4ec66bc131747254a45d8b6afb5cbb ("qcacld-3.0:
Remove eSAP_GET_WPSPBC_SESSION_EVENT") removed the references
to the sapGetWPSPBCSessionEvent field in typedef tSap_Event.
Since this field is obsolete, remove it, along with the underlying
tSap_GetWPSPBCSessionEvent typedef which is also now obsolete.

Change-Id: I20dbc1635430f8148f997aeb15df4ddb7e06ceef
CRs-Fixed: 2375527
2019-01-08 15:31:30 -08:00
Jeff Johnson
b3a9c6cfc7 qcacld-3.0: Remove ap_table fields from struct sap_config
The ap_table_max_size and ap_table_expiration_time fields in struct
sap_config are unused, so remove them.

Change-Id: I24aabe78b0da45c3dde19b444f94222eb874477d
CRs-Fixed: 2374831
2019-01-07 00:09:59 -08:00
lifeng
0b46ae503e qcacld-3.0: Refine mlme reg configurations
Refine mlme reg configurations based on converged cfg component.
Remove related legacy codes.

Change-Id: I524b29d2d03e60111fa1759d11e32236bb3aa3fa
CRs-Fixed: 2357961
2018-12-19 04:56:44 -08:00
Jeff Johnson
f9f921c52a qcacld-3.0: Clean up tSap_StationAssocReassocCompleteEvent
The typedef tSap_StationAssocReassocCompleteEvent contains the
following fields that are not being used, so remove them:
- SapAuthType
- beaconLength
- beaconPtr
- assocReqLength
- assocReqPtr
- assocRespLength
- assocRespPtr

Change-Id: I1de03b76b0070ee0b19d3d4672ed75614c013ac7
CRs-Fixed: 2364104
2018-12-11 10:18:23 -08:00
Jeff Johnson
219b6a0aae qcacld-3.0: Remove gDisableDfsJapanW53 remnants
Previously change I7f39ed0680919c6a383d9b8bae5864f979b6948c
("qcacld-3.0: Refactor more dfs cfg items") removed support for
gDisableDfsJapanW53. However some remants of that support were left
behind, so remove them.

Change-Id: Ic0ec3411621c87a66a2d2055ceeebc2ed027aa39
CRs-Fixed: 2364103
2018-12-11 10:18:19 -08:00
Jeff Johnson
9f158923b9 qcacld-3.0: Remove typedef tSap_DfsNolInfo
The only use of typedef tSap_DfsNolInfo is to define the unused
sapDfsNolInfo field in typedef tSap_Event. Since they serve no purpose
remove both the sapDfsNolInfo field and the tSap_DfsNolInfo typedef.

Change-Id: Ic63288c0ea59b4f26a20d65a3e41503e49efedbd
CRs-Fixed: 2364102
2018-12-11 10:18:16 -08:00
Jeff Johnson
4155a5ea6d qcacld-3.0: Remove assoId from tSap_StationAssocIndication
The typedef tSap_StationAssocIndication contains an assoId field that
isn't used, so remove it.

Change-Id: I2a4ba9bd7220cb0cebe891d7085d92e17361ed06
CRs-Fixed: 2364101
2018-12-10 20:21:43 -08:00
Jeff Johnson
405c998276 qcacld-3.0: Remove sessionID field from tSapCtxList
The sessionID field in tSapCtxList is written but never read, hence it
serves no purpose, so remove it.

Change-Id: I0c7a134dba75be905f85016a3db026132bbfa348
CRs-Fixed: 2364099
2018-12-10 20:21:38 -08:00
Jeff Johnson
5c859a5110 qcacld-3.0: Remove obsolete typedef tSap_SoftapStats
The typedef tSap_SoftapStats is unused, so remove it.

Change-Id: I641c5528a6794aa3721529e0fc0015bbb71499fd
CRs-Fixed: 2364098
2018-12-10 20:21:36 -08:00
gaurank kathpalia
379e05c97a qcacld-3.0: Update the sap channel only after sap start event
In the case of SAP restart due to a RADAR, or force SCC
due to STA vdev formed, in the SAP restart path
the driver updates the SAP channel in the global
AP context, and then sends the command to change the channel
to south bound layers to process, which may reject or accept
the command.
If the command has been accepted, the channel in the
global config would be the same as the channel configured
in the restart path, but for a case where the command was rejected
by the south bound, due to a concurrency check, or other reasons
the SAP remains on the previous channel in SCC, or MCC, with the
STA interface, but the channel in the global config is same as that
given in the restart path, so the real operating channel, and the
config channel are different.
Because of this if a fresh bringup of some vdev is to be done
according to the channel of the SAP, that would fail in some cases
( SAP on DFS channel, and STA coming, so the driver would reject MCC,
and SCC) which could be avoided if the channel of the SAP wouldnt be
configured in the restart path, and would be configured in the callback
of SAP.
Also the secondary channel of the SAP was configured as the secondary
channel configured at time of fresh SAP bringup, hence the sec channel
isn't updated after every restart of SAP.

Fix is to configure the channel of in the global AP context
only when the SAP START or CHANNEL CHANGE event comes for
the SAP. Also update the secondary channel after the CSA.

Change-Id: I6cbc31cae4958c0d7da79d4640e5ad8b1ce98338
CRs-Fixed: 2355420
2018-12-10 12:49:57 -08:00
Jeff Johnson
6d0b75be6e qcacld-3.0: Remove wlansap management frame registrar
The following wlansap management frame registration functions are
unused, so remove them:
- wlansap_register_mgmt_frame()
- wlansap_de_register_mgmt_frame()

Change-Id: Ib8865fbda4e65e7bbd39576a49423f60426d489a
CRs-Fixed: 2361909
2018-12-07 15:53:06 -08:00
Arif Hussain
224d38154f qcacld-3.0: Refactor more dfs cfg items
Refactor following DFS cfg items
CFG_DISABLE_DFS_CH_SWITCH
CFG_ENABLE_DFS_PHYERR_FILTEROFFLOAD_NAME
CFG_IGNORE_CAC_NAME
CFG_DFS_RADAR_PRI_MULTIPLIER_NAME
CFG_SAP_TX_LEAKAGE_THRESHOLD_NAME
CFG_DFS_BEACON_TX_ENHANCED
CFG_DISABLE_DFS_JAPAN_W53
CFG_ENABLE_NON_DFS_CHAN_ON_RADAR

Change-Id: I7f39ed0680919c6a383d9b8bae5864f979b6948c
CRs-Fixed: 2351995
2018-12-04 00:05:53 -08:00
Jeff Johnson
1856266cba qcacld-3.0: Replace hal in sap_module
Recently all instances of tHalHandle were replaced with mac_handle_t
to align with current usage and the Linux coding standard. To align
with the new naming now replace all instances of hal with mac_handle
in sap_module.

Change-Id: I8631e7b3cc4bdca564846bb2dee50e6c993087ef
CRs-Fixed: 2351898
2018-11-21 13:46:46 -08:00
Jeff Johnson
419348b1bc qcacld-3.0: Replace hHal in sap_module
Recently all instances of tHalHandle were replaced with mac_handle_t
to align with current usage and the Linux coding standard. To align
with the new naming now replace all instances of hHal with mac_handle
in sap_module.

Change-Id: I5422b4a7e1a464a8f870cea33069c47401c73bac
CRs-Fixed: 2349566
2018-11-15 15:18:10 -08:00
Jeff Johnson
6340ee0e43 qcacld-3.0: Replace tHalHandle in sap_api_link_cntl
I9d0d7d109621237f29d66f7b06c5b63c38f63fb2 (qcacld-3.0: Introduce
mac_handle_t) introduced a "better" name for tHalHandle, so replace
tHalHandle with mac_handle_t in sap_api_link_cntl.

Change-Id: I2d54133a841112486ecfd7a7971a1fcefa471cfc
CRs-Fixed: 2348553
2018-11-13 14:24:53 -08:00