During the review of "qcacld-3.0: lim: Replace tSirRetStatus with
QDF_STATUS" it was observed that the documentation for function
pe_process_messages() referenced an incorrect return type and return
value. While addressing this issue it was further observed that
pe_process_messages() was only being called from within lim_api.c by
pe_mc_process_handler(). Since these are both trivial functions,
consolidate them into one function.
Change-Id: Ia66088b79003e0c8c517a8e3ae32540c19fec070
CRs-Fixed: 2271550
A recent set of changes replaced all tSirRetStatus definitions with
QDF_STATUS. However some code comments were overlooked since they
incorrectly referred to eSirRetStatus instead of tSirRetStatus. Change
those comments to correctly reference QDF_STATUS.
Change-Id: I3b5779d0a09e594f1371362d161d3ea4c887110c
CRs-Fixed: 2271549
Currently lim_post_msg_api() and lim_post_msg_high_priority() are
defined to return a uint32_t status. This is an artifact of many
generations of driver changes. These functions now return QDF_STATUS,
so update the signatures as well as all callers to properly expect
this return type. In addition remove the legacy wrapper function
pe_post_msg_api() since it is unused.
Change-Id: I00f991d64e3542336526e7ed2ca36e4112918cb7
CRs-Fixed: 2271548
Add CDP API to set RX MIC key in datapath.
Required to perform RX demic of fragmented packets.
Change-Id: I3c05da62ff20f8551cdc5780ce2f7b8d23c73a37
CRs-Fixed: 2217884
Add ultra low verbosity level to distinguish datapackets and special
packets. And post TPUT event to DPTrace logic so
that it can disable data packet logging during TPUT scenarios.
Disable print and in memory logging when packets per second exceeds
4 packets.
Change-Id: I70c9368de4cb2423901449b267452a34d652213d
CRs-Fixed: 2185186
rx_thread can sustain the TCP DL KPIs with silver core.
So let system decide scheduling of rx_thread for TCP.
Move rx_thread to perf cluster only for UDP traffic exceeding
the threshold. This is achieved by having monitoring non
rx_offload traffic. This takes care of platform(such as ROME)
which doesnot support rx_offload and also cases when we don't
support rx_offload(SAP, concurrency etc..)
This rx_thread affinity can be overridden by INI configured
rx_thread CPU mask.
Change-Id: I0e47221a2491c67c8da4b331756a3b5a18a82e37
CRs-Fixed: 2185186
Add INI option to specify CPU mask for Rx_thread and affine
Find current online cores.
During high TPUT,
1) If user INI configured cores, affine to those cores
2) Otherwise perf cores.
3) Otherwise to all cores.
During low TPUT, set affinity to any core, let system decide.
Change-Id: I10e906d484e300bb32491d7d60d717e92b92aaef
CRs-Fixed: 2185186
Current NAPI IRQ affinity logic doesnot have way to specify
configurable CPU affinity option. Instead it starts affining them from
starting from biggest available core.
Current profiling experiment suggest that NAPI IRQ affinity is not
required, so set default as no affinity.
Change-Id: I0bea3389a7565f8ec157d4587a442b5e11c33fb2
CRs-Fixed: 2185186
This reverts The Change-Id: Ifa2872ef62925f99bf49ef504ade4a4bb431672b
because this change results slower down the downloading speed of file
from the server in weak signal (-70 RSSI) area.
Change-Id: Iec7423809f5225de9b5c4d08d7806a8a2a9dfe06
CRs-Fixed: 2270285
Add enum QDF_MCC_TO_SCC_WITH_PREFERRED_BAND(6) for this.
If ini gWlanMccToSccSwitchMode is selected to
QDF_MCC_TO_SCC_WITH_PREFERRED_BAND(6) then following will be the
behaviour of STA+SAP concurrency.
1. If second interface(SAP/STA) comes in same band as
first interface(STA/SAP) respectively then force SCC
irrespective of channel.
2. If second interface(SAP/STA) comes in other band as
first interface(STA/SAP) then dont force SCC allow
interband MCC or DBS based on DBS capability.
Allow interband MCC but not intraband MCC.
Change-Id: I91d41b4b0306ed4e362b5bcab9538f5fd5feea7d
CRs-Fixed: 2260672
Fix checkpatch issue introduced by change "qcacld-3.0:
separate HE caps per band", use new mac_handle_t instead
of tHalHandle in sme_update_tgt_he_cap param and fix
indent issue.
Change-Id: I91e11fd38ac72266b4afcf42d71340975127f559
CRs-Fixed: 2268400
Change "qcacld-3.0: Remap tSirRetStatus to QDF_STATUS" introduced a
set of macros to map tSirRetStatus to QDF_STATUS. All of the
tSirRetStatus identifiers have been renamed, so remove the now unused
macros.
Change-Id: Ie95c9806bdcc52e25e81c8adaecacbdc79207e37
CRs-Fixed: 2270654
The tSirRetStatus definitions are obsolete, so replace them with
QDF_STATUS definitions in the mac pe/lim folder.
Note that this change introduces some checkpatch issues, but due to
the number of pre-existing checkpatch issues in lim these are just
noise, and in order to have this change just address the issue at hand
any checkpatch issues will be addressed as part of a separate cleanup
activity.
Change-Id: I677292c208fe08f1bbba8bf294870cbc73cc3b5c
CRs-Fixed: 2270620
Clenaup legacy passive scan minimum channel time configuration
value and the code references related to the same.
Change-Id: I15d508484dde8f4db775a6fb263646a7af8e5f69
CRs-Fixed: 2262691
Clenaup legacy active scan minimum channel time
configuration item and the code references related
to the same.
Change-Id: I5eef7ec09345e199946700c033eaa85fbf69d289
CRs-Fixed: 2262691
The init thread takes the rtnl lock during initialization.
So use kernel API regulatory_set_wiphy_regd that does not
take the rtnl lock.
Change-Id: I50e7aa96dd8c819d1531b84b181a058197d9b24f
CRs-Fixed: 2265624
If wmi_ready is not set, we can infer that WMI_READY_EVENTID has not
been fully processed yet. Completion of WMI_READY_EVENTID is necessary
for any follow-on messages to be processed properly, since it builds
infrastructure on host. Therefore, serialize the follow-on message with
WMI_READY_EVENT if wmi_ready is not set yet.
CRs-Fixed: 2267180
Change-Id: I2e5df318f8e40a9487502a49539252c9fde9892b
While processing the WMA_ROAM_OFFLOAD_SYNCH_IND event, The
driver takes nearly 150 to 200 msec time to just write fatal,
error and info messages to the kmsg log buffer. Also to get
tx power supplicant runs another thread while roaming. These
cause more latency(300ms) to send WMA_ROAM_OFFLOAD_SYNCH_CNF
message to fw. To decrease roam latency, the driver should
write the only necessary error message to kmsg buffer.
The fix is to change irrelevant fatal, error and info message
type to debug add a check in __wlan_hdd_cfg80211_get_txpower
to reject the request to get Tx power while roaming in progress
otherwise driver will process this and will increase the roaming
latency.
Change-Id: I6c31637f21991b5b29c1e2dd2c2935ae7d4fc3d0
CRs-Fixed: 2251824
Emulation builds can be very slow, leading to watchdog timeout issues.
One specific issue involves the HDD inactivity watchdog timer. Scale the
HDD inactivity timer by the qdf timer multiplier to avoid false
positives on emulation setups.
Change-Id: Idc7f3d25f836ff5406d4fb5758e975ab5d83f596
CRs-Fixed: 2269834
If STA+SAP is doing SCC & g_sta_sap_scc_on_lte_coex_chan is set,
don't move SAP to a different channel when LTE channel avoidance
event comes.
Change-Id: I3dfdbb6d59769a8ff9b3b2e6d828feee94630569
CRs-Fixed: 2261795
If station connect with infrastructure network, might connect to AP
different with the hint bssid, if reassociate command issued, it will
invoke hdd_reassoc(). It might bring down connected station without
bring down vdev of the LFR2.0 path if the process of scanning for ssid
failed.
Add back logic of checking uOsRequestedHandoff and route to correct
LFR2.0 roaming path.
Change-Id: I406b55270dc70e5d3494250d6013f7d35824970f
CRs-Fixed: 2256194
Using netif_rx_ni for UDP packets has a lot of overhead because of the
softirq(NET_RX) used to process the backlog queue. Hence use
netif_receive_skb for UDP packets.
Change-Id: I02e4de17e55ce448a87b55075465003b03fcd5f5
CRs-Fixed: 2185186
The HDD Request Manager was replicated in the converged project as the
OSIF Request Manager so that the infrastructure could be used by the
converged code. Transition HDD to the OSIF Request Manager and remove
the now duplicated HDD Request Manager.
Change-Id: I2dfdd2da4f98e95a74ba13d04bb42d25a90c9ec8
CRs-Fixed: 2269909
The tSirRetStatus definitions are obsolete, so replace them with
QDF_STATUS definitions in the mac pe/rrm folder.
Change-Id: Iba8b15a3f17ee4bd827d384cf775ac0679590208
CRs-Fixed: 2269739
The tSirRetStatus definitions are obsolete, so replace them with
QDF_STATUS definitions in the mac pe/sch folder.
Change-Id: I7301c209adccdb63b1f1ac063d4590b5019f2e40
CRs-Fixed: 2269738
Currently mac_handle_t is defined as a void pointer. This is
convenient from an information hiding point of view since that means a
non-MAC component cannot dereference a MAC handle to access MAC
private data. However this is not convenient from a defect prevention
point of view since the C standard allows any other pointer type to be
freely and silently converted to and from a void pointer, and hence
the compiler is unable to detect when a MAC handle is used in a
context where a different pointer type is expected.
An example of multiple such defects was addressed by Change-Id
I01812b2390269805da4d1a5cb40a811d1e22ec56 (qcacld-3.0: Fix bad
pointers being passed from SME to WMA).
To help prevent these kinds of defects change the definition of
mac_handle_t to be a pointer to an opaque struct.
Change-Id: I72483bf0e693d6eca24355f31d3a1653b8f31302
CRs-Fixed: 2268814
Currently sme_qos_is_ts_info_ack_policy_valid() takes a tpAniSirGlobal
mac context param. However this is a global function that is called by
HDD, so it should be taking an opaque handle. Update the function and
all callers to use the appropriate type.
Change-Id: I71759ce184306a90f46e37d79d6bdd7a545c1bc2
CRs-Fixed: 2269181
Currently sme_process_ready_to_ext_wow() takes a tHalHandle context
param. However this is a static internal function, and hence it
should be using the "real" context pointer type tpAniSirGlobal instead
of the opaque reference tHalHandle, so update the API to expect
tpAniSirGlobal (which is what is already being passed by
sme_process_msg()).
Change-Id: I06a2c00334867902e185726d1c7b3ba8c8cb08f5
CRs-Fixed: 2269965
Update pld soc info by structure member to decouple between pld soc info
with platform soc info.
Change-Id: I0e62d4784d7bccfb2f08d3678e1c78e6baaa9ca9
CRs-Fixed: 2268191
Currently there is a chance that driver can access pCurRoamProfile
even after freeing it. While driver frees pCurRoamProfile as part of
csr_roam_process_command in mc thread context/user space context(if
there is no active command in sme queue), it can access the same
variable as part of __wlan_hdd_cfg80211_set_ext_roam_params in user
space context and can result in use after free.
Acquire lock before freeing roam profile to fix this issue.
Change-Id: I16863f35405fa41424060bb2d12c779681095a85
CRs-Fixed: 2265905