Currently csr_is_wapi_match() takes a tHalHandle context param.
However this is a static function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle, so update the API to expect tpAniSirGlobal.
Change-Id: I0befea1f804204bc5589d33cf2d5fe6fd5126bf1
CRs-Fixed: 2268180
Currently csr_get_wapi_information() takes a tHalHandle context param.
However this is a static function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle, so update the API to expect tpAniSirGlobal.
Change-Id: I54004093c729add183fc3e02033d78f829f47241
CRs-Fixed: 2268179
Currently csr_get_rsn_information() takes a tHalHandle context param.
However this is a static function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle. So update the API to expect tpAniSirGlobal.
Change-Id: I29ad553360eddcf2b990b83bb0d1418d744a85ec
CRs-Fixed: 2268178
Currently csr_is_rsn_match() takes a tHalHandle context param.
However this is a static function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle. So update the API to expect tpAniSirGlobal.
Change-Id: I33a73505039716a38ea94c19d12a0a3ce390b0b3
CRs-Fixed: 2268177
In both csr_create_roam_scan_offload_request() and
csr_neighbor_roam_indicate_disconnect() there is a call to
csr_neighbor_middle_of_roaming() where the MAC context is typecast to
tHalHandle as part of the function call. However these typecasts are
incorrect since csr_neighbor_middle_of_roaming() expects to get a MAC
context. Due to the manner in which tHalHandle is defined this does
not current cause a build issue, but an upcoming change will enforce
type checking so update these calls to remove the inappropriate
typecasts.
Change-Id: I7eeb3eb6b4502c1934a8cffdd1d7372f93ee8ccb
CRs-Fixed: 2268176
Currently csr_get_dot11_mode() takes a tHalHandle context param.
However this is a static function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle. In addition the only caller is already passing
the real context pointer type so update the API to expect
tpAniSirGlobal.
Change-Id: I4f57252f0c94949b3219b5c07143d2545c659871
CRs-Fixed: 2267444
lim_tx_complete() is currently defined to take a tHalHandle as the
first param. However the generic signature of a TX callback function
specifies that the first param should be a void *context. This
currently compiles because tHalHandle is defined to be a void *, but
this will soon be changed, so update lim_tx_complete() to explicitly
use a void *context.
Change-Id: I421e8acb25beed23d2f3803380a46db33b6f0964
CRs-Fixed: 2267443
The QoS callback is supposed to pass a mac_handle_t (aka tHalHandle)
to HDD, but in most cases what is actually passed is a tpAniSirGlobal.
Even though these ultimately reference the same structure, an upcoming
change will enforce type safety so update the bad callers to pass a
parameter of the correct type.
Change-Id: I5913c3cf577606f8c207b1e40897b8cbe681de48
CRs-Fixed: 2267442
Function sme_get_current_roam_state() takes a mac_handle_t (aka
tHalHandle) as the first parameter. However in some cases the caller
is actually passing a tpAniSirGlobal. Even though these ultimately
reference the same structure, an upcoming change will enforce type
safety so update the bad callers to pass a parameter of the correct
type.
Change-Id: I3e17de9656fd83598cfd35b63843dd3f7b25d072
CRs-Fixed: 2267441
Currently sme_process_ready_to_suspend() takes a tHalHandle context
param. However this is a static internal function, and hence it
should be using the "real" context pointer type tpAniSirGlobal instead
of the opaque reference tHalHandle, so update the API to expect
tpAniSirGlobal (which is what is already being passed by
sme_process_msg()).
Change-Id: Ic2f28613ce0f4df0a104aaa1ab23b311abe5e334
CRs-Fixed: 2267440
Currently sme_ibss_peer_info_response_handler() takes a tHalHandle
context param. However this is a static internal function, and hence
it should be using the "real" context pointer type tpAniSirGlobal
instead of the opaque reference tHalHandle, so update the API to
expect tpAniSirGlobal (which is what is already being passed by
sme_process_msg()).
Change-Id: I553b485f0e54f173d31e8931f3bda6bba8ede77d
CRs-Fixed: 2267439
Currently sme_tsm_ie_ind() takes a tHalHandle context param. However
this is a static internal function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle, so update the API to expect tpAniSirGlobal
(which is what is already being passed by sme_process_msg()).
Change-Id: Ica6add4b81ad7ffd664ee6e46f2e8b43a731771f
Crs-Fixed: 2267438
Currently sme_ft_send_update_key_ind() takes a tHalHandle context
param. However this is a static internal function, and hence it
should be using the "real" context pointer type tpAniSirGlobal instead
of the opaque reference tHalHandle, so update the API to expect
tpAniSirGlobal (which is what is already being passed by
sme_ft_update_key()).
Change-Id: I5309a6f9125684bc0d7766d5839f2296150b6834
CRs-Fixed: 2267437
Current driver keeps cmd_id as 0 for all non-scan commands which
makes serialization module's logic more complex in order to identify
between duplicate commands.
Add unique cmd_id and attach it to each legacy sme command to make
serialization module's logic easy to distinguish between duplicate
commands.
CRs-Fixed: 2267418
Change-Id: Id2ccb435137061c963120822326fe5b90f857eb7
In wlan_hdd_cfg80211_start_pending_acs() the result of calling
container_of() is NULL checked. The container of a work_struct is
always a valid pointer, so the NULL check is unnecessary. Remove this
resulting dead code.
Change-Id: Iac4d48037ee27bc5de4c5fbc7f91188d837c6d49
CRs-Fixed: 2267075
Currently fw_peer_count for HO failure is done in wma_roam_ho_fail_handler
which can lead to improper reset of the fw_peer_count if a HDD triggered
disassoc is in progress for the same peer leading to fw_peer_count going
to -1.
Reset the fw_peer_count for HO failure case in wma_delete_bss_ho_fail
API as this is called from the CSR/LIM for handling HO failure as
part of CSR disconnect.
Change-Id: I1526757b085086ca51eef9b9cca0ea757ed20b61
CRs-Fixed: 2266337
Map all module level log APIs to per-level log APIs
to compile out specific log level if required.
Change-Id: Icfcc28fb592ee99704d8fb23bc3cb45b6e4c9f53
CRs-Fixed: 2266718
If MCC to SCC switch is enabled, SAP is active and CSA
received for STA interface, then ignore the CSA if channel
is DFS/disabled.
CRs-Fixed: 2266838
Change-Id: I98b8d957766358ea86cc9f50339725cf4bf0038b
When HL Flow Control is enabled, check for per vdev limits for making
a decision on whether frames should be discarded.
Change-Id: Ifde5f763d253eb644f97afeab9e4e1365c23e672
CRs-fixed: 2236321
1) Add ol txrx function to set TX descriptor limits for a
vdev.
2) Set the TX descriptor limits for STA and AP mode.
Change-Id: Ie9b1e52c3aff05db99ba3748a94792cc8116cdca
CRs-fixed: 2236321
1) Restart high priority netdev queue when tx descriptors get freed
and the vdev->tx_desc_count < vdev->tx_desc_limit.
2) Restart normal priority netdev queues when tx descriptors get freed
and the vdev->tx_desc_count < vdev->queue_start_th.
Change-Id: I99cc159289bc31558294e02cd9213a18472563f6
CRs-fixed: 2236321
Add function: ol_txrx_set_vdev_os_queue_status() to update
OS queue stop/start status in TXRX module.
Also call cdp_hl_fc_set_os_queue_status() from 'flow control
resume timer' to update OS queue status in TXRX module.
Change-Id: I03260985a48084bc523a3814c93c0e6b213e1970
CRs-fixed: 2236321
1) Populate legacy flow control ops 'cdp_lflowctl_ops'
for HL netdev flow control.
2) Also call cdp_hl_fc_register() to register HL flow control
callback.
3) Increase number of netdev queues to 5
Change-Id: I6bdb015b3325e54386f2aad093c89f6f782c24ed
CRs-fixed: 2236321
Change "qcacld-3.0: Introduce mac_handle_t" introduced a modern
name for what was previously called the tHalHandle. Transition
wlan_hdd_ioctl to use the new naming.
Change-Id: I5b6a062e02dc6db387c0a4e4cc363cdac7013f45
CRs-Fixed: 2267221
Change "qcacld-3.0: Introduce mac_handle_t" introduced a modern
name for what was previously called the tHalHandle. Transition
wlan_hdd_hostapd to use the new naming.
Change-Id: I63b3bc8017de7f73a09599f9e8c9ef41009d6bc6
CRs-Fixed: 2267151
Change "qcacld-3.0: Introduce mac_handle_t" introduced a modern
name for what was previously called the tHalHandle. Transition
wlan_hdd_power to use the new naming.
Change-Id: I6729766eda0b6dc31d62028a8552c9fa9d7ce4f0
CRs-Fixed: 2267218
Change "qcacld-3.0: Introduce mac_handle_t" introduced a modern
name for what was previously called the tHalHandle. Transition
wlan_hdd_wmm to use the new naming.
Change-Id: I225c7b62b2b104941564856b3ed1ee20e3a8e1cd
CRs-Fixed: 2267123
Change "qcacld-3.0: Introduce mac_handle_t" introduced a modern
name for what was previously called the tHalHandle. Transition
wlan_hdd_cfg80211 to use the new naming.
Change-Id: Ia9a7014db052c46ee16d2cb834b46a0b7afafeee
CRs-Fixed: 2267223
Change "qcacld-3.0: Introduce mac_handle_t" introduced a modern
name for what was previously called the tHalHandle. Transition
wlan_hdd_wext to use the new naming.
Change-Id: I3cabec634252453b33c8f480ba785cc739e872df
CRs-Fixed: 2267115
Because a SAP vdev can be repurposed as a station adapter, there is a
case where a station vdev that was created as a SAP vdev will try to
access uninitialized completion variables. As these members are directly
attached to the adapter struct, always initialize them, regardless of
the vdev type at time of creation.
Change-Id: Ifc14ec677ffa76551e55fe982a58df21d430d6c6
CRs-Fixed: 2266419
Currently the function lim_process_assoc_req_frame uses frame_len
without validation to parse the IE buffer which could lead to
out-of-bounds memory access if the frame_len is less than or
equal to LIM_ASSOC_REQ_IE_OFFSET(4).
Add check to validate the frame_len with LIM_ASSOC_REQ_IE_OFFSET
before sending (frame_len - LIM_ASSOC_REQ_IE_OFFSET) to
cfg_get_vendor_ie_ptr_from_oui to parse only the IE buffer.
Change-Id: Iaa9e8db4a2605169c9ad3904878a2e626eb6de8b
CRs-Fixed: 2259707
Currently csr_is_pmf_capabilities_in_rsn_match() takes a tHalHandle
context param. However csr is internal to the UMAC, and hence it
should be using the "real" context pointer type tpAniSirGlobal instead
of the opaque reference tHalHandle, so update the API to expect
tpAniSirGlobal.
Change-Id: Ie13e86dac694bc1c17305f12aeb817387cc7c4bd
CRs-Fixed: 2266509
Currently csr_is_bss_description_wme() takes a tHalHandle context
param. However csr is internal to the UMAC, and hence it should be
using the "real" context pointer type tpAniSirGlobal instead of the
opaque reference tHalHandle, so update the API to expect
tpAniSirGlobal.
Change-Id: I2812f57e57a06a71a81bee20773587fa99189e40
CRs-Fixed: 2266506
Currently sme_unprotected_mgmt_frm_ind() takes a tHalHandle context
param. However this is a static function, and hence it should be
using the "real" context pointer type tpAniSirGlobal instead of the
opaque reference tHalHandle, so update the API to expect
tpAniSirGlobal.
Change-Id: I552cade9adf0bdc7a9cf38c76cd8786548dc7011
CRs-Fixed: 2266505
Currently in sme_update_config() the call to
rrm_change_default_config_param() is passing a mac_handle_t instead of
a tpAniSirGlobal. Change the call to pass the correct parameter.
Change-Id: I1490e3f491c1c8539acc0054343263366fb8bfca
CRs-Fixed: 2266503
Currently in multiple places calls to sme_ps_start_uapsd() are passing
a tpAniSirGlobal instead of a mac_handle_t. Change these calls to pass
the correct parameter.
Change-Id: I9cd30be8eb237423cb621b390be2bbc75ecebb92
CRs-Fixed: 2266502
Currently in sme_get_channel_bonding_mode5_g() and
sme_get_channel_bonding_mode24_g() the calls to sme_get_config_param()
are passing a tpAniSirGlobal instead of a tHalHandle. Change these
calls to pass the correct parameter.
Change-Id: I1fc1b357f96d29babc2bb8439b924fbd1fb74b62
CRs-Fixed: 2266455
In peer assoc command, the phy mode of peer is updated based on
the nw_type of pe session. So this value should accordingly as per
the new channel.
Change-Id: Ib596cb343f239456aba688b2b5ea7b19b3034a66
CRs-Fixed: 2161043
Recent num_vdevs configuration change involved the regression,
that num_vdevs in FTM mode isn't configured, and default 0 interface
allowed. This is blocking FTM initialized.
Though no vdev required for FTM, here use INI configuration
to bypass check as well.
CRs-Fixed: 2266815
Change-Id: I019814fb2c37f1f9b5922545769761bed7a0da52
Currently if the set mac adderess command comes, driver is
returning failure if any of the interface is using the MAC
address given in the command.
Return success if the same MAC address is passed in the command
for the same interface which is using this MAC currently.
Change-Id: Iaab6109aa015b6be525eba2bacbe05c3c796e033
CRs-Fixed: 2266755
Do not tie up names with mailbox.
This results from SDIO HIF refactoring.
See qcacmn: I12bdf8b07350411093ba35071411525a8333cf93
Change-Id: I99184fbfc95a601f09dba5891098c35d5aa794c5
CRs-Fixed: 2252448
Presently, while processing start_bss, after retrieving WPS IE from
the beacon frame, 15th byte of WPS IE is accessed to get WPS state,
without confirming IE length holds that much minimum length to access.
Before accessing 15th byte(WPS state) of WPS IE, make sure IE length
holds minimum length to access it.
Change-Id: Ic00c700a1fbf88183b8b2d834c9700b538700ce7
CRs-Fixed: 2239164
The tSirRetStatus definitions are obsolete, so replace them with
QDF_STATUS definitions in the cds folder.
Change-Id: I689e80fefa0068980a2bf78d2eff13d0892f8d95
CRs-Fixed: 2266521
Change "qcacld-3.0: Introduce mac_handle_t" introduced a modern name
for what was previously called the tHalHandle. Subsequently change
"qcacld-3.0: Use mac_handle_t in wlan_hdd_stats" transitioned
wlan_hdd_stats to use the new naming. But while that change was in the
pipeline a new instance of tHalHandle was added. So now transition the
instance recently added to wlan_hdd_clear_link_layer_stats().
Change-Id: I2d17c729a92eb5c545b829fc6699e34233116f94
CRs-Fixed: 2266545
No valid channel found when DUT as P2P GO and radar signal detected,
stop ap and then up layer start ap again, session id of adapter
changed to invalid since session id of sap context is invalid and
passed to adapter in hdd_hostapd_sap_event_cb with event
eSAP_START_BSS_EVENT. So, do not clear session id of sap context for
stopping ap due to invalid channel case.
Change-Id: I3d60ae9b4ec8223dff26ffd9078b31e02bf29ba2
CRs-Fixed: 2257932
Change "qcacld-3.0: Introduce mac_handle_t" introduced a modern
name for what was previously called the tHalHandle. Transition
wlan_hdd_cfg to use the new naming.
Change-Id: Ib3a9d26cb8966b52b71e97d7b9fb8f2cca9ed916
CRs-Fixed: 2266499
Change "qcacld-3.0: Introduce mac_handle_t" introduced a modern
name for what was previously called the tHalHandle. Transition
wlan_hdd_ext_scan to use the new naming.
Change-Id: I69f8a76ae798ed00953727b7687f53506acd22d3
CRs-Fixed: 2266498
The tSirRetStatus definitions are obsolete, so replace them with
QDF_STATUS definitions in the mac sys folder.
Change-Id: Ia1d4a570b7c79ea2bd0ad5f82d287c48f73051b9
CRs-Fixed: 2266497
The tSirRetStatus definitions are obsolete, so replace them with
QDF_STATUS definitions in the mac dph folder.
Change-Id: I150e024f9b764547267dc8b4673a95e3366c6b70
CRs-Fixed: 2266147
The tSirRetStatus definitions are obsolete, so replace them with
QDF_STATUS definitions in the mac pe/nan folder.
Change-Id: I762d963f5c19f797b9fe0bc933368d4d700de7b3
CRs-Fixed: 2266394
Change "qcacld-3.0: Introduce mac_handle_t" introduced a modern
name for what was previously called the tHalHandle. Transition
wlan_hdd_assoc to use the new naming.
Change-Id: I33e58d6c51124036d00e37fa3018379b7f99105a
CRs-Fixed: 2266433
While processing get_station cfg operation, HDD is using Nss
value, which gets updated during association, to calculate data
rate. So, there is a possibility of driver to report invalid
MCS index to upper layer if association happens with Nss 2 and
when data transmission is happening at Nss 1 rate.
On receiving GET STATS response, calculate Nss value based upon
the current data rate received from firmware, and pass it to HDD,
so that HDD can use the same Nss value to report valid MCS index
to the upper layer.
Change-Id: I62f029d53149a4747f619027ce69ce65fb280b8d
CRs-Fixed: 2250993
The SME message callback is currently being used in a manner that is
inconsistent with its signature. The signature specifies that a
tHalHandle should be passed but PE actually passes a tpAniSirGlobal.
Since this is a MAC internal interface update the logic to
consistently use a tpAniSirGlobal.
Change-Id: I8bf94a3dd603b76bdbe7c0db3555736692f64cb7
CRs-Fixed: 2266188
The function lim_handle_csa_offload_msg, posts the
eWNI_SME_CSA_OFFLOAD_EVENT msg to sme. The csa_offload_ind
allocated is not freed during failure cases and this will result
in memory leak during the failure cases.
Free the memory allocated for csa_offload_ind for the failure
cases.
CRs-Fixed: 2263376
Change-Id: I6e25500c0e3a0cc2fa71601d935ec9bbe866dc2b
In wma_is_ccmp_pn_replay_attack peer is used without taking the ref
count and thus this can lead to peer used after free.
Fix this by taking ref of peer before using the peer in
wma_is_ccmp_pn_replay_attack and release ref once access is done.
Change-Id: Iaa5936a1c7f6f8667a68fcb646eaec4cb3aa5469
CRs-Fixed: 2264434
Change "qcacld-3.0: Introduce mac_handle_t" introduced a modern
name for what was previously called the tHalHandle. Transition
wlan_hdd_p2p to use the new naming.
Change-Id: I93514340fcfcf136e6e635aa142209f7cf35a68f
CRs-Fixed: 2266176
The tSirRetStatus definitions are obsolete, so replace them with
QDF_STATUS definitions in the mac cfg folder.
Change-Id: Ia8a644bc80356cf1dcf7f688d7758902d38af57a
CRs-Fixed: 2266149
The tSirRetStatus definitions are obsolete, so replace them with
QDF_STATUS definitions in the sap folder.
Change-Id: I17482713977012d13e0fdb99b67e3f5f4a33efe9
CRs-Fixed: 2266146
The tSirRetStatus definitions are obsolete, so replace them with
QDF_STATUS definitions in the sme folder.
Change-Id: Ib47c297fb19c350f6ccb7d2c433ebb0eac36b2c4
CRs-Fixed: 2263024
Make sure to follow AP for NDI self peer creation so that self peer
creation and deletion can be symmetric.
Change-Id: Ie7f9c7b5500540c824a75758337967f8d4f6e692
CRs-Fixed: 2261713
Fix memory leak in function lim_send_sme_ndp_add_sta_rsp
where memoery for new peer indication for NDP is allocated
but not freed after use.
Change-Id: If5e2df154f5aab8cec21a54dd62a1c1af43e075a
CRs-Fixed: 2261712
Create NDI vdev after adapter is added to back of hdd adapter list,
so that vdev create completion callback can identify right adapter
and set corresponding completion variable.
Change-Id: If72f779fabc15a9c29f7d94bffa041f7d42db1f4
CRs-Fixed: 2252030
