One of the HDD functions with the highest cyclomatic complexity is
__wlan_hdd_cfg80211_wifi_configuration_set(). In order to reduce the
complexity there is a plan to replace the inline attribute handling
with a vtable-based approach.
As part of that goal refactor the following independent attribute
handling into a separate function and add that function to the vtable:
- QCA_WLAN_VENDOR_ATTR_CONFIG_FINE_TIME_MEASUREMENT
Change-Id: I8b9914936ed9077b487bb8092246a64a6c5f914b
CRs-Fixed: 2371560
One of the HDD functions with the highest cyclomatic complexity is
__wlan_hdd_cfg80211_wifi_configuration_set(). In order to reduce the
complexity there is a plan to replace the inline attribute handling
with a vtable-based approach.
The QCA_WLAN_VENDOR_ATTR_CONFIG_SCAN_DEFAULT_IES attribute handling is
already in a separate function, so add that function to the vtable
instead of calling it directly.
Change-Id: Id77d491ce90bbc1d2a0569af37bba55aeeaa0295
CRs-Fixed: 2371559
One of the HDD functions with the highest cyclomatic complexity is
__wlan_hdd_cfg80211_wifi_configuration_set(). In order to reduce the
complexity there is a plan to replace the inline attribute handling
with a vtable-based approach
As the first step of this refactoring add the actual vtable
infrastructure. Later changes will refactor the attribute handling
and populate the vtables.
Change-Id: If79fc61f84bf17a39e300c18681961a4a0e01408
CRs-Fixed: 2371558
Dump DPT and MAC trace after LIM detects disconnection caused by
deauth or disassoc such that in case of RX data stall we can get
all required logs.
Change-Id: I28b129e5b787391e0064a16d9750c463f2310199
CRs-Fixed: 2371708
The driver currently defines three different data structures to hold
mobility domain information:
- tSirMobilityDomainInfo
- tCsrMobilityDomainInfo
- struct mobility_domain_info
To align with the converged software architecture remove the two
legacy typedefs and exclusively use the unified WMI structure.
Change-Id: I317b90e47c3db8b74a76c297f6bc42301fa2f80e
CRs-Fixed: 2369476
Replace legacy isRoamOffloadEnabled from csr_config with
converged flag lfr3_roaming_offload.
Fix CamelCase issues for roam offload part.
Change-Id: I89ceda876d5549e9b0959e7e25e317c9667594b5
CRs-Fixed: 2367873
Use policy manager to set and update the NAN Discovery
related connection info. Disable NAN Discovery
explicitly for unsupported concurrencies.
Handle concurrencies with NAN Discovery interface.
Change-Id: I8c9450b034983ef0402fdc878d8b525bedac9f0b
CRs-Fixed: 2358180
After replace CONFIG_MCL with WLAN_FEATURE_ROAM_OFFLOAD in
struct roam_offload_scan_params, roam_offload_params is only
defined under MACRO WLAN_FEATURE_ROAM_OFFLOAD, any access to
roam_offload_params should be under WLAN_FEATURE_ROAM_OFFLOAD.
Refactor function wma_roam_scan_offload_mode, separate roam scan
offload parameters config to another function.
Change-Id: I3b9306ef3c3ad9c451ffb450df9521cde609bca4
CRs-Fixed: 2367841
Reject con mode handler after driver is unloaded. Proper order is
Driver needs to be re-loaded again and then con mode change handler
needs to be invoked.
Change-Id: Ibc3dfbae1ba3953af537f2d5f50748598a4fe3e1
CRs-Fixed: 2369284
When STA connect and target AP isn't in scan cache, specific
scan for AP ssid will happen, and roam profile is saved in
scan info.
When scan complete, in registered csr scan callback, if connect
need HW mode change, HW mode change is sent to F/W, and roam
profile in scan info is freed at once.
In HW mode change response handler, if roam profile in scan info
is found to be freed, failed to start connect.
Fix:
Make sure roam profile not freed before issue connect.
In specific scan result callback, before issue connect, check
whether need HW mode change.
1. If HW mode change is unneeded or return FAILED, free roam
profile in scan info.
2. If HW mode change return SUCCESS, when cmd is finished or
cancelled, in csr_free_cmd_memory, free roam profile when
cmd is e_sme_command_set_hw_mode with reason
POLICY_MGR_UPDATE_REASON_HIDDEN_STA.
Change-Id: I3f87996de4142baea33dd0f56cb2a892f0387336
CRs-Fixed: 2369154
Change I5afd04a5ed5d4d0bd3438d95cc4f6c214ad4bc3d ("qcacld-3.0: Remove
sme_set_tm_level()") removed the last usage of tAniSetTmLevelReq.
Since it is obsolete, remove it.
Change-Id: I2a44f2a3b5f0e924d4dc0d9a9563b359a0366577
CRs-Fixed: 2371206
Field mgmtFrameSessionId in tAniSirLim is initialized but is otherwise
never referenced. Since the field is unused, remove it.
Change-Id: I27239cbe92d9b1de32fe003cd977e2c8ccc18017
CRs-Fixed: 2371202
Change Idf75957707c3799add0c59fdd532fe0c24d27117 ("qcacld-3.0: Remove
obsolete STA support for SIOCSIWESSID") removed the last client of
hdd_wmm_get_uapsd_mask(). Since this function is now unused, remove
it.
Change-Id: I28b1909690e1f1c813f4169b6429a7faecdac7d6
CRs-Fixed: 2371200
Change I1d45de261c50f1835379a9cc1df4631f3e32f459 ("qcacld-3.0: Purge
all serialization commands on csr stop") removed the only client of
csr_purge_vdev_all_ser_cmd_list(). Since this function is now unused,
remove it.
Change-Id: I62ff513aa817d9b7fd4dcec156d53c02a1de40e2
CRs-Fixed: 2371198
Change I913b6e769f282a0f5a0ddb40e54d294ae07deb55 ("qcacld-3.0: Remove
unused concurrency ini parameters") removed the last client of
csr_is_sta_session_connected(). Since this function is unused, remove
it.
Change-Id: I6c14227fb1364b37dd570cd658aedb0b5b10b341
CRs-Fixed: 2371197
Change Ib9cdaf7e8aa019002b9fc02d8ffacfcdb28fc121 ("qcacld-3.0:
Remove sme_ipa_uc_stat_request()") removed the last client of
wma_ipa_uc_stat_request(). Since this function is now obsolete,
remove it.
Change-Id: I965ccad2e94246c0d7d57e85c1fa433eeb5c136e
CRs-Fixed: 2371196
Change Ief51bcf611d5d5759fa04e05c0bb4d96e44c7a29 ("qcacld-3.0:
Remove sme_get_wcnss_*_version()") removed the last client of
wma_get_wcnss_software_version(). Since this function is obsolete,
remove it.
Change-Id: Ie3e8fcb48e45deebc750c9886f268d5306a7b705
CRs-Fixed: 2371195
Change Id39629e33e87ffe6ed58f375609a55e324618693 ("qcacld-3.0: Apply
second part of LFR INIs changes in HDD layer") removed the last client
of sme_set_neighbor_scan_min_period()"). Since this function is
unused, remove it.
Change-Id: I305b9d78582b5e633079daeb864da703428314d8
CRs-Fixed: 2371192
Change Idf75957707c3799add0c59fdd532fe0c24d27117 ("qcacld-3.0: Remove
obsolete STA support for SIOCSIWESSID") removed the only client of
sme_set_dhcp_till_power_active_flag(). Since this function is now
unused, remove it.
Change-Id: I161122772fbc6e588384ac10382885cafdadbc3e
CRs-Fixed: 2371191
Change Ifff2ef2c8790994a68e676b8bba2fb03c21370d4 ("qcacld-3.0: Enable
station SMPS only if the session supported NSS > 1") introduced
function sme_is_sta_smps_allowed(). However this function has
subsequently never been used, so remove it.
Change-Id: I0a4d134986dd3a03d12e907f6df6ecb29b268eb3
CRs-Fixed: 2371155
The following legacy functions are unused, so remove them:
- sme_is11d_supported()
- sme_is11h_supported()
- sme_is_wmm_supported()
Change-Id: I50016f7695d873f551f214504b54c0cbeb40564f
CRs-Fixed: 2371154
Change Id4691e0f490c2f9bd9ccc8d5225be32002a5df9e ("qcacld-3.0:
Remove legacy IPA code from HDD") removed the last client of
sme_ipa_uc_stat_request(). Since the function is unused, remove it.
Change-Id: Ib9cdaf7e8aa019002b9fc02d8ffacfcdb28fc121
CRs-Fixed: 2371153
Change I994e53b17788472de979df9dce9e18c6f68de850 ("qcacld-3.0: Add
support for regulatory component ucfg apis") removed the last client
of sme_handle_dfs_chan_scan(). Since this function is now unused,
remove it.
Change-Id: Id4bad555c0cd52c736c7c934e4892953dc27c582
CRs-Fixed: 2371151
Change Ib37eff0591d9c043e62883329c12410fcca67223 ("qcacld-3.0: Remove
sme_get_infra_session_id()") removed the only client of
csr_get_infra_session_id(). Since this function is now unused, remove
it.
Change-Id: I32d0875087ad1f55ec8e8ee2985f7397fefb525d
CRs-Fixed: 2371149
Change I0ded9473083418f6bb33cec4fa43a17c8c281177 ("qcacld-3.0: Remove
hdd_exchange_version_and_caps()") removed the only client of
sme_feature_caps_exchange(). Since this function is an obsolete stub,
remove it.
Change-Id: I0899e4befbf995436729c90caeda982e8b5ec1ff
CRs-Fixed: 2371146
Change I0ded9473083418f6bb33cec4fa43a17c8c281177 ("qcacld-3.0: Remove
hdd_exchange_version_and_caps()") removed the only client of
sme_disable_feature_capablity(). Since this function is an obsolete
stub, remove it.
Change-Id: I8cf83e7f370a644c6e814aa7b4aedad1f7fec88f
CRs-Fixed: 2371145
Change Ia0fa016b174ef4b50e2cc339e4e476ec65642dbf ("qcacld-3.0:
Use dfs component support") removed the last client of
sap_dfs_is_channel_in_preferred_location(). Since this function
is now obsolete, remove it.
Change-Id: I137a00699511c7f019f6cf3b8f0579aeb52c7778
CRs-Fixed: 2371144
Change I92f79f595e881fccb6eb5e87fcfa29e8f26fa1a5 ("qcacld-3.0:
Remove sme_store_joinreq_param()") removed the last client of
csr_store_joinreq_param(). Since this function is now unused,
remove it.
Change-Id: Ie3f7a8a581a505a29ddb96825eafe265c6d01479
CRs-Fixed: 2371142
Change I3050cd9a704f9c2489a11c75cd439224e44b8748 ("qcacld-3.0: Remove
csr_roam_connect_to_last_profile()") removed the last client of
csr_move_bss_to_head_from_bssid(). Since this function is now unused,
remove it.
Change-Id: Ib83c7fa596d589ba9eed5803701f24d4634ad645
CRs-Fixed: 2371141
Change I795bfd1d19f81d703bd9d903ebc53e61b014c5c3 ("qcacld-3.0:
Remove sme_clear_joinreq_param()") removed the last client of
csr_clear_joinreq_param(). Since this function is now unused,
remove it.
Change-Id: I8482ddb4c2410c93fc7d982d6f1cd024b4d66d17
CRs-Fixed: 2371140
Change I6cb9fe12bee3702556c9b52e7ccb7c69c762d8de ("qcacld-3.0: Remove
legacy code for policy manager restructuring") removed the last client
of sme_clear_joinreq_param(). Since this function is now unused,
remove it.
Change-Id: I795bfd1d19f81d703bd9d903ebc53e61b014c5c3
CRs-Fixed: 2371139
Change I360a0c0f7508026f1889e1998eeaac01464382de ("qcacld-3.0: Remove
sme_issue_stored_joinreq()") removed the last client of
csr_issue_stored_joinreq(). Since the function is now unused, remove
it.
Change-Id: I0ec6ae46c5b90ab6619f03ab76d95ca4e45ad450
CRs-Fixed: 2371138
Change I913b6e769f282a0f5a0ddb40e54d294ae07deb55 ("qcacld-3.0: Remove
unused concurrency ini parameters") removed the last client of
csr_is_p2p_session_connected(). Since this function is now unused,
remove it.
Change-Id: Ifd4f4f52bfe6e5be4b472a47cfea765b336a8daf
CRs-Fixed: 2371137
