All WNI configurations will be cleanup based on new cfg framework, so
change Change WNI_CFG_COUNTRY_CODE_LEN to CFG_COUNTRY_CODE_LEN.
Change-Id: I786b62e2c0aff08a89fc3c8a3359e2ffb4044269
CRs-Fixed: 2380488
All WNI configurations will be cleanup based on new cfg framework, so
change Change WNI_VALID_CHANNEL_LIST_LEN to VALID_CHANNEL_LIST_LEN.
Change-Id: I805be88ecdcca90cf3a19d1784bf8f8c261b6ca4
CRs-Fixed: 2379748
Change to avoid potential out of bound issue
when unsafe channel numbers parameter is invalid.
Change-Id: I0c2cdac844c5fd644fce61d3d69fefcecdb62f19
CRs-Fixed: 2374986
In SSR, after reinit, there is still memory leak
for gp_sap_ctx; As in multi SSR test, memory leak
detection is disabled in recovery mode, it is a
little late to get the issue moment.
Check gp_sap_ctx after stopping all adapter in
hdd_is_interface_down_during_ssr.
Change-Id: I77708d296fb218ca53ac656f844d02f58e23d241
CRs-Fixed: 2377718
Change I3226438b908a96f1b1bd3c2968a0c20eef81a799 ("qcacld-3.0:
Populate correct supported rates from hostapd.conf file") removed
the logic which previously utilized the supp_rate_set and
extended_rate_set fields in struct sap_context. Since these fields
are now obsolete, remove them.
Change-Id: Id433659da18d61217b45a839aaddcfbae329143d
CRs-Fixed: 2378327
Change I83a704d3f03e9cb9e6a7420f32d609a323799a12 ("qcacld-3.0: Remove
legacy P2P codes in SAP") removed the usage of the sap_roc_ind field
in tSap_Event. Since it is obsolete, remove the field along with the
underlying struct sap_roc_ready_ind_s.
Change-Id: I6101ec7874825b8e4e2e891c3f8ae084486eef87
CRs-Fixed: 2378326
currently the driver just ignore the channel numbers greater
than 165 for 80MHZ channel bonding, which results in best
channel selected as 169, 173 in 20MHZ bandwidth as the
respective channels does not support 80, or even 40 MHZ
channel bandwidth.
Fix is to assign the maximum weight to channel numbers greater
than 165, so that they do not get selected as best channel
for 80MHZ bandwidth operation.
Change-Id: I44c5073a806f39d98103681267faa317a6b6d73b
CRs-Fixed: 2375375
sapDfsChannelNolList and numCurrentRegDomainDfsChannels
fields in sap dfs info is not populated and is used in
csr_is_valid_channel.
Fix is to remove the redundant logic in csr_is_valid_channel.
Change-Id: Ib98423ba910a1947a908f4a74762f82183aa89d5
CRs-Fixed: 2374080
Make changes to the legacy code to support the
new SET KEY converged infrastructure.
Change-Id: Ic5359e3a9035ac5f2a937a9a1013fa92764cda9d
CRs-Fixed: 2358795
Change "I9d05cd7b8e051c4e9e4912cf866206ae32ec293d" ("qcacld-3.0:
Define data structures for new AP requirements") added the
vendor_ie_access_policy field to struct sap_config, but subsequently
no code was added which actually utilizes this field. Since it is
unused, remove it, along with the underlying enumeration.
Change-Id: I7a3661a50ef17b0452e87e0ed86c3826b3bd199d
CRs-Fixed: 2375528
Change I9d83f66bce4ec66bc131747254a45d8b6afb5cbb ("qcacld-3.0:
Remove eSAP_GET_WPSPBC_SESSION_EVENT") removed the references
to the sapGetWPSPBCSessionEvent field in typedef tSap_Event.
Since this field is obsolete, remove it, along with the underlying
tSap_GetWPSPBCSessionEvent typedef which is also now obsolete.
Change-Id: I20dbc1635430f8148f997aeb15df4ddb7e06ceef
CRs-Fixed: 2375527
Change I5a07c44ca4138af5494d1a6f6e1d08158d244be2 ("qcacld-3.0: Remove
SapAllChnlList from struct sap_context") removed the last reference to
typedef tChannelInfo. Since this typedef is now obsolete, remove it.
Change-Id: Ib38c9744c9419ce91b94956b5da78cc7bcc440c5
CRs-Fixed: 2375526
Change I2c3b96e1f2ee44c9f1158108d4b5e48495222080 ("qcacld-3.0: Make
SAP open()-close() & start()-stop() symmetrical") removed the last
reference to typedef tSapChannelListInfo. Since the typedef is
obsolete, remove it.
Change-Id: I4fc7cf83f41ad0192b971513f0456cf211fabb54
CRs-Fixed: 2375525
The parameter identifiers used in the implementation of
sap_get_channel_list() differ from the ones used in the forward
reference. Since this can be confusing for both humans and code
analysis tools, harmonize on the parameters used in the
implementation.
Change-Id: I356740677e790e48b0c28d5ca694be3ae3835d59
CRs-Fixed: 2375524
Change I3c4f8da14dbc70a3102fb1892bb101eb1a90a00d ("qcacld-3.0: Fix
firmware assertion caused by vdev delete") removed all usage of field
isScanSessionOpen in struct sap_context. Since it is obsolete, remove
it.
Change-Id: I30eb9d3b4ca39a5f14dafe9559d025cb361372b5
CRs-Fixed: 2375522
The implementation of sap_channel_matrix_check() is no longer part of
the driver, but the prototype is still present. Since the prototype is
obsolete, remove it.
Change-Id: I689c4360776a2b46d723c48dd5bb8a61da5c95cd
CRs-Fixed: 2375521
Change I76e78824cdc7acad87e60310d53225596630ea94 ("qcacld-3.0: Remove
SAP FSM dependency from CSA") removed all logic which used the
stop_bss_in_progress field in struct sap_context. Since this field is
now obsolete, remove it.
Change-Id: I9867bcf7d8021e7173c679d3e20e16ca8bdbc5cc
CRs-Fixed: 2375520
Change Ia0fa016b174ef4b50e2cc339e4e476ec65642dbf ("qcacld-3.0: Use dfs
component support") removed the logic that utilized the SapAllChnlList
in struct sap_context. Since this field is now obsolete, remove it,
along with the underlying tAll5GChannelList typedef that is also now
obsolete.
Change-Id: I5a07c44ca4138af5494d1a6f6e1d08158d244be2
CRs-Fixed: 2374834
The ap_table_max_size and ap_table_expiration_time fields in struct
sap_config are unused, so remove them.
Change-Id: I24aabe78b0da45c3dde19b444f94222eb874477d
CRs-Fixed: 2374831
Field ucSecEnabled in struct sap_context is initialized, but is
otherwise unused, so remove it.
Change-Id: I4b947be54d86e0e7e272b97427efd7acb4658fe6
CRs-Fixed: 2374275
The ownSsid and ownSsidLen fields in struct sap_context are unused, so
remove them.
Change-Id: I405f0c7c47e163a962bc3db19d88d5b69ca95ac7
CRs-Fixed: 2374274
In wlansap_update_csa_channel_params if channel is not present in
op class table the for loop become infinite.
Add check to break the loop if BW is 20 and still entry is not found
in op class table.
Change-Id: I6ef6bc138a8df0e18b54bd16a47eba23b437616d
CRs-Fixed: 2373915
Currently the driver doesn't set the passive scan req flag
as false which results in passive scan, and thus introduces
latency.
Fix is to set passive scan as false in ACS scan req.
Change-Id: I1274a4ccb9d99d568c32aeea1a65e4637a82b9c8
CRs-Fixed: 2372103
Change Ia0fa016b174ef4b50e2cc339e4e476ec65642dbf ("qcacld-3.0:
Use dfs component support") removed the last client of
sap_dfs_is_channel_in_preferred_location(). Since this function
is now obsolete, remove it.
Change-Id: I137a00699511c7f019f6cf3b8f0579aeb52c7778
CRs-Fixed: 2371144
Currently the driver scans for the channels as part of ACS
algorithm, to select the best channel for SAP bringup.
But the active dwell time set in the scan request is Zero,
hence the active probe is not sent to the AP, and the DUT
(SAP in this case), just passively scans the channels for BSS,
which causes latency in SAP bringup.
Fix is to initialize the default active dwell time in case of
ACS scan, and set broadcast probe to true.
Change-Id: If4f001a9b272a7894125d81f2895cfa6f6ca2bc4
CRs-Fixed: 2363789
The typedef tSap_StationAssocReassocCompleteEvent contains the
following fields that are not being used, so remove them:
- SapAuthType
- beaconLength
- beaconPtr
- assocReqLength
- assocReqPtr
- assocRespLength
- assocRespPtr
Change-Id: I1de03b76b0070ee0b19d3d4672ed75614c013ac7
CRs-Fixed: 2364104
Previously change I7f39ed0680919c6a383d9b8bae5864f979b6948c
("qcacld-3.0: Refactor more dfs cfg items") removed support for
gDisableDfsJapanW53. However some remants of that support were left
behind, so remove them.
Change-Id: Ic0ec3411621c87a66a2d2055ceeebc2ed027aa39
CRs-Fixed: 2364103
The only use of typedef tSap_DfsNolInfo is to define the unused
sapDfsNolInfo field in typedef tSap_Event. Since they serve no purpose
remove both the sapDfsNolInfo field and the tSap_DfsNolInfo typedef.
Change-Id: Ic63288c0ea59b4f26a20d65a3e41503e49efedbd
CRs-Fixed: 2364102
The typedef tSap_StationAssocIndication contains an assoId field that
isn't used, so remove it.
Change-Id: I2a4ba9bd7220cb0cebe891d7085d92e17361ed06
CRs-Fixed: 2364101
The sessionID field in tSapCtxList is written but never read, hence it
serves no purpose, so remove it.
Change-Id: I0c7a134dba75be905f85016a3db026132bbfa348
CRs-Fixed: 2364099
Hostapd is expected to use country code already programmed in the driver.
Therefore, validate the country code sent by hostapd. Enable SAP 11d only
if country code from hostapd is same as driver country code.
Change-Id: I88d6603f4e696c86ffb85b798221d750f71b741b
CRs-Fixed: 2359333
In the case of SAP restart due to a RADAR, or force SCC
due to STA vdev formed, in the SAP restart path
the driver updates the SAP channel in the global
AP context, and then sends the command to change the channel
to south bound layers to process, which may reject or accept
the command.
If the command has been accepted, the channel in the
global config would be the same as the channel configured
in the restart path, but for a case where the command was rejected
by the south bound, due to a concurrency check, or other reasons
the SAP remains on the previous channel in SCC, or MCC, with the
STA interface, but the channel in the global config is same as that
given in the restart path, so the real operating channel, and the
config channel are different.
Because of this if a fresh bringup of some vdev is to be done
according to the channel of the SAP, that would fail in some cases
( SAP on DFS channel, and STA coming, so the driver would reject MCC,
and SCC) which could be avoided if the channel of the SAP wouldnt be
configured in the restart path, and would be configured in the callback
of SAP.
Also the secondary channel of the SAP was configured as the secondary
channel configured at time of fresh SAP bringup, hence the sec channel
isn't updated after every restart of SAP.
Fix is to configure the channel of in the global AP context
only when the SAP START or CHANNEL CHANGE event comes for
the SAP. Also update the secondary channel after the CSA.
Change-Id: I6cbc31cae4958c0d7da79d4640e5ad8b1ce98338
CRs-Fixed: 2355420
The following wlansap management frame registration functions are
unused, so remove them:
- wlansap_register_mgmt_frame()
- wlansap_de_register_mgmt_frame()
Change-Id: Ib8865fbda4e65e7bbd39576a49423f60426d489a
CRs-Fixed: 2361909
To align with the Linux coding style replace tpAniSirGlobal with
struct mac_context * in:
sap_api_link_cntl.c
sap_ch_select.c
sap_fsm.c
sap_internal.h
sap_module.c
Change-Id: Iec4f67fc3ba08cf046d00136fb0f4edf37d65d64
CRs-Fixed: 2360297
The inline function MAC_CONTEXT() is the preferred mechanism for
converting a MAC handle into a MAC context, so replace all instances
of the legacy macro PMAC_STRUCT().
Change-Id: Ieb29696c79b729648462be699892607484c2f301
CRs-Fixed: 2357873
When CONFIG_MOBILE_ROUTER is enabled there are build failures
due to improper featurization of mobile router, so fix the
featurization.
Change-Id: Ic9e1f608bc631409fbb5bcf84fc3f4520d69a7c9
CRs-Fixed: 2355786
Per the Linux coding style "mixed-case names are frowned upon" and
"so-called Hungarian notation [...] is brain damaged." One identifier
used extensively throughout the driver that violates both of these
tenants is "pMac." In order to be compliant with the Linux coding
style there is a campaign to rename all instances of this identifier.
For this change rename all instances of "pMac" to "mac" in:
sap_ch_select.c
sap_fsm.c
sap_module.c
Change-Id: Iaf300b458fb89550d2e3a90f98ed6aabecd98024
CRs-Fixed: 2355451
Recently all instances of tHalHandle were replaced with mac_handle_t
to align with current usage and the Linux coding standard. To align
with the new naming now replace all instances of hal with mac_handle
in sap_module.
Change-Id: I8631e7b3cc4bdca564846bb2dee50e6c993087ef
CRs-Fixed: 2351898
Recently all instances of tHalHandle were replaced with mac_handle_t
to align with current usage and the Linux coding standard. To align
with the new naming now replace all instances of hal with mac_handle
in sap_fsm.
Change-Id: I560f99110bd38815c6e515006245f538d3dc6482
CRs-Fixed: 2351897
Recently all instances of tHalHandle were replaced with mac_handle_t
to align with current usage and the Linux coding standard. To align
with the new naming now replace all instances of halHandle with
mac_handle in sap_ch_select.
Change-Id: I4306005fb2677b1892272e2176e8cc73cb927d29
CRs-Fixed: 2351894
If the STA is already present, and a SAP has to come up,
return the STA channel as the best channel, and skip ACS,
if the Hw_mode is set according to the STA channel
Eg:- STA on channel 1, and hw_mode is 11B, or 11G.
Also the driver doesnt check the DFS master mode, and
includes the DFS channels in the ACS scan list, which
may result in SAP bringup on a DFS channel
Check the conc_channel, and acs_policy ini, and return the
best channel as the STA channel.
Also exclude the DFS channels from the ACS scan list if
DFS master mode is disabled.
Change-Id: I70951d7b51b620db8cda7ed771d5c36a7571a125
CRs-Fixed: 2340965
Recently all instances of tHalHandle were replaced with mac_handle_t
to align with current usage and the Linux coding standard. To align
with the new naming now replace all instances of hHal with mac_handle
in sap_module.
Change-Id: I5422b4a7e1a464a8f870cea33069c47401c73bac
CRs-Fixed: 2349566
