In lim_send_probe_req_mgmt_frame() there is logic to change the
dot11mode from 11ac to 11n when operating in 2.4GHz unless VHT
operation in 2.4GHz has been enabled in the INI. However the
associated comment has a typo, referring to enableVhtFor24GHz instead
of the correct name, gEnableVhtFor24GHzBand, so fix the comment.
Change-Id: I56c569d85cac7e00347bea522d2f6f133e276cfb
CRs-Fixed: 2382130
Change I1f668fff633a5e5cdfc478e7f619e9600930b333 ("qcacld-3.0: Use wma
callback to get vdev dp handle") removed the implementation of
pmo_ucfg_vdev_update_dp_handle(), but left behind the stub
implementation for use when PMO is disabled. This stub, since renamed
to ucfg_pmo_vdev_update_dp_handle(), is unused, so remove it.
Change-Id: I042ea081a4c2e5288963f7882129d06667e5b707
CRs-Fixed: 2380780
Change I5c873b9571228f0d2b4fcd4782267a2cc40fc20a ("qcacld-3.0: Remove
the deprecated IOCTL in TDLS") removed the implementation of function
sme_update_fw_tdls_state(). However it left behind the prototype,
which is now obsolete, so remove it.
Change-Id: I57731f12761cfd564d949ec582eb4d45302e75d1
CRs-Fixed: 2380779
The driver contains a sme_set_host_power_save() prototype but no
implementation. Since the prototype is obsolete, remove it.
Change-Id: I5631a5f23dd61380af0cacb037f673c585ae575f
CRs-Fixed: 2380778
Change Iebda5bbb3c5c68b922b7f6ac1adaf25cccf903a6 ("qcacld-3.0: Apply
mlme lfr configuraions") removed the implementation of function
sme_update_roam_offload_enabled(). However it left behind the
prototype, which is now obsolete, so remove it.
Change-Id: I64391c654e50fa8220beee5ad225c66158057d5b
CRs-Fixed: 2380777
Change I7e04b4488b10021d6815e76d0a55e040756b1794 ("qcacld-3.0: Remove
unused SCAN code under NAPIER_SCAN define") removed the last logic
that used the scanProfile field in struct csr_scanstruct. Since this
field is now obsolete, remove it, along with the underlying struct
scan_profile.
Change-Id: Ica60cc075f9768dbd86bcae6a2145c6594bc8595
CRs-Fixed: 2380776
Change I8ba344ce5593df44bd15527e2ff68e872b6d23b8 ("qcacld-3.0: TDLS:
remove legacy core functions") removed the last usage of typedefs
tCsrTdlsLinkEstablishParams and tCsrTdlsSendMgmt. Since these typedefs
are now obsolete, remove them.
Change-Id: I666c3180beb7fb0a230ba6c97a93666ff9ba886e
CRs-Fixed: 2380775
Change I8cd30439d7ac3de7b550aa5042353cf30e04cbda ("qcacld-3.0:
Refactor MLME CFG items and APIs for VHT") removed the usage of the
enableVhtFor24GHz field in tCsrConfigParam, but failed to remove the
actual field, so remove it now.
Change-Id: Id80c1a85c9269b3bcc6019426f5321665bc93f2e
CRs-Fixed: 2380774
Change Ib83700825112cc52dade594909bfa8993909ac29 ("qcacld-3.0: Send
management frame indication directly to HDD from PE") removed the
usage of tSap_ManagementFrameInfo. Since this struct is obsolete,
remove it.
Change-Id: Ic10c150286fe9f998884cdfcb8da2edadee7e156
CRs-Fixed: 2380771
Change I9d05cd7b8e051c4e9e4912cf866206ae32ec293d ("qcacld-3.0: Define
data structures for new AP requirements") added the ampdu_size field
to struct sap_config. However logic to use this field was never added,
so remove the field since it is unused.
Change-Id: I183766da3af3a3e9c609ccde95a0cca561813226
CRs-Fixed: 2380767
The SCH_BEACON_LEN_DELTA and CW_GET macros in sch_beacon_process.c are
unused, so remove them.
Change-Id: I539f637534f576f2bab6fd432d0a365ec62b8a6b
CRs-Fixed: 2380766
As part of change in bandwidth in HT cap of beacon from AP.
Driver triggers the vdev restart, but if there are any
TDLS connections present then TDLS peers are not removed.
This can lead to inconsistency between host and FW as FW
deletes tdls peers as part of vdev restart.
Remove TDLS peers before restarting vdev.
Change-Id: Ibeab1e4bcda9229ed936ffe05be9ecdfeb260eef
CRs-Fixed: 2380440
If STA is trying to connect and same time SAP initiate the
change channel the HW mode calculated during connection start will
may not be valid for some STA's candidate and thus, it will avoid
connecting to these candidate leading to recursive calling of CSR
roam API.
To fix this while selecting the candidate skip the candidate itself
even before trying to connect if the candidate channel is not allowed
for current HW mode. Also block SAP channel change from user
space during connection.
Change-Id: Ic04aa983d95986f05d6359eb112d489e8ef80478
CRs-Fixed: 2380459
There are two issue in the driver during SSR:
1. Currently in driver if SSR happens in SAP mode and during
re-probe if any pending acs delayed work is scheduled, it
results in NULL pointer access at sap_init_dfs_channel_nol_list
api as pdev is not initialized yet.
2. disconnection_status_lock is not getting initialized for
SAP interface and this is getting used inside
hdd_set_disconnect_status api which is getting invoked
for all interfaces at reset all adapters during SSR
shutdown, which results in uninitialized lock access.
To address these issue below measures are taken care:
1. Add SSR protection for pending acs and flush
pending acs delayed work during SSR shutdown.
2. During SSR shutdown don't invoke hdd_set_disconnect_status
api for SAP interface.
Change-Id: I5181deffed28ecbc5708f970c9ca7f8ad2241011
CRs-fixed: 2379280
Set the RSN capabilities to crypto component which is used to
construct the RSN IE with right capabilities during connection.
Change-Id: Ia21e7f5592eef53d3eb90752e328de6fdbd80aea
CRs-Fixed: 2377823
hdd_override_all_ps() has been changed to override ini setting by
calling ucfg_mlme_override_bmps_imps(), which need a valid psoc, so move
it after hdd_objmgr_create_and_store_psoc(). Looks put it in
hdd_override_ini_config() is a good choice.
Change-Id: Ia902a5a94ae2e06f984473fc69628c114f35b052
CRs-Fixed: 2381140
The WLAN_SOFTAP_FW_BEACON_TX_PRNT_LOG feature wraps a single log which
references a non-existent TimIeOffset beaconParams field. Since the
driver will not build if this feature is enabled, remove it.
Change-Id: I607b55b82e8ae1d304ac8203395cffe384c8bb74
CRs-Fixed: 2380121
Macro HAL_TDLS_PEER_STA_MASK is unused, and appears to conflict with
macro HAL_USE_PEER_STA_REQUESTED_MASK, so remove it.
Change-Id: Idb28362772b0b1219bb75dbd1a99927667c608ab
CRs-Fixed: 2380120
The qType parameter to function lim_sys_process_mmh_msg_api() is
unused, so remove it. In addition, since this function is just a
wrapper, turn it into a static inline to to eliminate an unnecessary
function call at every call site.
Change-Id: If3e95855361bd9efd90b426c698982773b4677da
CRs-Fixed: 2380118
The following macros are unused, so remove them:
- WNI_CFG_TDLS_LINK_SETUP_CNF_TIMEOUT
- WNI_CFG_TDLS_LINK_SETUP_RSP_TIMEOUT
Change-Id: Ibae6895881ef1ad831ecb405b510f04d40da7c14
CRs-Fixed: 2380116
Currently the lim_populate_matching_rate_set() prototype uses
different parameter identifiers than the implementation. Since this
can be confusing for both humans and code analysis tools, update the
prototype to match the implementation.
Change-Id: Ic96e47e82f3c6ab873a87f570fca81659d87a52b
CRs-Fixed: 2380114
Currently the SCH global context contains a single field which is
itself a struct. That struct, in turn, contains multiple fields with
naming that does not conform to the Linux coding style. Having a
single struct within a struct is pointless, so consolidate the two
structs into one, and update the field names to conform to the coding
standard.
Change-Id: Ibabb32440a833357a50933d399406113cf6f271b
CRs-Fixed: 2380113
Currently the rrm_process_radio_measurement_request() prototype uses
different parameter identifiers than the implementation. Since this
can be confusing for both humans and code analysis tools, update the
prototype to match the implementation.
Change-Id: I904d39ad37293ab012062c6a5e78d33cf42e8973
CRs-Fixed: 2380112
Currently the rrm_process_beacon_report_xmit() prototype uses
different parameter identifiers than the implementation. Since this
can be confusing for both humans and code analysis tools, update the
prototype to match the implementation.
Change-Id: Id6d671dcc6e7f0dc3db9f5a07ca3ea74b45e2b41
CRs-Fixed: 2380111
As part of change I71de90d5fb88462e52148a434d43ea80c41cfe36
("qcacld-3.0: Move Channel convert and frame indication logic to
lim_utils.c") the usage of field p2pGoPsNoaStartInd in struct
pe_session was removed. However the field itself was left behind, so
remove it now.
Change-Id: I1d6965587b0387ecd6e1822a774f874d922d90c0
CRs-Fixed: 2380110
Change I8876a4d4b99948cd9ab3ccec403cf5e4050b1cff ("qcacld-3.0: Fix
layering violation while handling management frames") removed the only
usage of tDphHashNode field proct_deauh_disassoc_cnt. Since it is
obsolete, remove it.
Change-Id: If4adb4bfb704cc6721796faca9dce2dfff844b6b
CRs-Fixed: 2380108
There are currently two separate MAC Trace APIs, mac_trace() and
mac_trace_new(). Since these ultimately result in a call to
qdf_trace(), and since only mac_trace() is widely called, consolidate
these two APIs into a single mac_trace() API. In addition, make this a
static inline to eliminate an unnecessary function call at every call
site and to fully take advantage of the conditional expansion of
qdf_trace().
Change-Id: I71101cc076a19ae8dad26c743f726c94571ae8a1
CRs-Fixed: 2380107
Change I67a589133e58fd7740d7edc93d32a2d9fcd14c5a ("qcacld-3.0: Cleanup
unused scan params and ini") removed the following legacy CFG items:
- WNI_CFG_ACTIVE_MAXIMUM_CHANNEL_TIME
- WNI_CFG_PASSIVE_MAXIMUM_CHANNEL_TIME
However this change left behind the associated MIN/MAX/DEF macros
which are now unused, so remove the following:
- WNI_CFG_ACTIVE_MAXIMUM_CHANNEL_TIME_STAMIN
- WNI_CFG_ACTIVE_MAXIMUM_CHANNEL_TIME_STAMAX
- WNI_CFG_ACTIVE_MAXIMUM_CHANNEL_TIME_STADEF
- WNI_CFG_PASSIVE_MAXIMUM_CHANNEL_TIME_STAMIN
- WNI_CFG_PASSIVE_MAXIMUM_CHANNEL_TIME_STAMAX
- WNI_CFG_PASSIVE_MAXIMUM_CHANNEL_TIME_STADEF
Change-Id: I0da08ee379b754f7724754b497825de2372685c4
CRs-Fixed: 2380106
The macros WLAN_WAIT_TIME_POWER and WLAN_WAIT_TIME_POWER_STATS are
unused, so remove them.
Change-Id: Idb9e39036688a2f02d33e08acc488798553bac36
CRs-Fixed: 2380104
In function wma_update_hw_mode_list, hw_config_type should be read from
the same mac-phy config array to check if next array could be for used
for MAC1 SS_bw settings bas on hw_config_type.
Change-Id: If787b127b5cf0f811344b3322ba84c2956543e14
CRs-Fixed: 2381784
WIPHY features are populated before FW offload object is
initialized. Thus use direct config values for SAE and GCMP
WIPHY features.
Change-Id: Ic1b84c8709a0347fa22773786c0d5af32426e8fc
CRs-fixed: 2376983
