Clenaup legacy active scan minimum channel time
configuration item and the code references related
to the same.
Change-Id: I5eef7ec09345e199946700c033eaa85fbf69d289
CRs-Fixed: 2262691
While processing the WMA_ROAM_OFFLOAD_SYNCH_IND event, The
driver takes nearly 150 to 200 msec time to just write fatal,
error and info messages to the kmsg log buffer. Also to get
tx power supplicant runs another thread while roaming. These
cause more latency(300ms) to send WMA_ROAM_OFFLOAD_SYNCH_CNF
message to fw. To decrease roam latency, the driver should
write the only necessary error message to kmsg buffer.
The fix is to change irrelevant fatal, error and info message
type to debug add a check in __wlan_hdd_cfg80211_get_txpower
to reject the request to get Tx power while roaming in progress
otherwise driver will process this and will increase the roaming
latency.
Change-Id: I6c31637f21991b5b29c1e2dd2c2935ae7d4fc3d0
CRs-Fixed: 2251824
If station connect with infrastructure network, might connect to AP
different with the hint bssid, if reassociate command issued, it will
invoke hdd_reassoc(). It might bring down connected station without
bring down vdev of the LFR2.0 path if the process of scanning for ssid
failed.
Add back logic of checking uOsRequestedHandoff and route to correct
LFR2.0 roaming path.
Change-Id: I406b55270dc70e5d3494250d6013f7d35824970f
CRs-Fixed: 2256194
Currently sme_qos_is_ts_info_ack_policy_valid() takes a tpAniSirGlobal
mac context param. However this is a global function that is called by
HDD, so it should be taking an opaque handle. Update the function and
all callers to use the appropriate type.
Change-Id: I71759ce184306a90f46e37d79d6bdd7a545c1bc2
CRs-Fixed: 2269181
Currently sme_process_ready_to_ext_wow() takes a tHalHandle context
param. However this is a static internal function, and hence it
should be using the "real" context pointer type tpAniSirGlobal instead
of the opaque reference tHalHandle, so update the API to expect
tpAniSirGlobal (which is what is already being passed by
sme_process_msg()).
Change-Id: I06a2c00334867902e185726d1c7b3ba8c8cb08f5
CRs-Fixed: 2269965
Currently there is a chance that driver can access pCurRoamProfile
even after freeing it. While driver frees pCurRoamProfile as part of
csr_roam_process_command in mc thread context/user space context(if
there is no active command in sme queue), it can access the same
variable as part of __wlan_hdd_cfg80211_set_ext_roam_params in user
space context and can result in use after free.
Acquire lock before freeing roam profile to fix this issue.
Change-Id: I16863f35405fa41424060bb2d12c779681095a85
CRs-Fixed: 2265905
Remove the obsolete logic in the SME QOS module.
QDF_STATUS_PMC_PENDING status is not used, so remove the
obsolete code based on this status.
Change-Id: Ie891eddad2b536e43f5f933c8683d41b096bf578
CRs-Fixed: 2269866
SME_QOS_CSR_HANDOFF_FAILURE event is not used and the event
handler is obosolete. Remove the obsolete functionality
Change-Id: I7d3c9732b0550bdedb1c2b06b9d31e2ee3db2480
CRs-Fixed: 2269866
The csr_linked_list implementation has remnants of a command debugging
infrastructure that is no longer used, so remove those remnants.
Change-Id: Ic217c99b755744eed36c153a4183ed98724e86d7
CRs-Fixed: 2269026
The HDD handle hHdd in struct tDblLinkList is never referenced, so
remove it from the struct. In addition remove the hHdd parameter from
csr_ll_open() since it is only being used to populate this field.
Change-Id: I6c123c5338feb795fdaea194c2cb7f9bd7a36093
CRs-Fixed: 2269025
Currently, discon_in_progress flag is set in SME from HDD when
there is a disconnection request. But after setting the flag it
may wait for any on-going roaming to complete.Doing this may
unnecessarily stop the on-going roaming process. Hence set the
flag after completing the wait time and during the actual time
when the disconnection is about to be started in SME layer.
Change-Id: Ie91049ef2e385ff86d8aa6881799caf432a7e8a5
CRs-Fixed: 2266432
The sme scan APIs sme_scan_get_result(), sme_scan_result_get_first(),
sme_scan_result_get_next() all take a mac_handle_t (aka tHalHandle) as
the first parameter. However in sme_rrm_send_scan_result() currently a
tpAniSirGlobal is being passed. Even though these ultimately reference
the same structure, an upcoming change will enforce type safety so
update the code to pass a parameter of the correct type.
Change-Id: I83e585bc91cbd9eeab5ecdeae0274196c98f3b4f
CRs-Fixed: 2268812
The sme cfg APIs sme_cfg_get_int(), sme_cfg_set_int(),
sme_cfg_get_str(), and sme_cfg_set_str() all take a mac_handle_t (aka
tHalHandle) as the first parameter. However in some cases the caller
is actually passing a tpAniSirGlobal. Even though these ultimately
reference the same structure, an upcoming change will enforce type
safety so update the bad callers to pass a parameter of the correct
type.
Change-Id: I7f602c2c6c25f15efe239cb1ba2c0c8e5bfd3e0a
CRs-Fixed: 2268811
Currently csr_set_channels() takes a tHalHandle context param.
However csr is internal to the UMAC, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle, so update the API to expect tpAniSirGlobal.
Change-Id: Idf260cce60cd436ac871b4df3620cf1baf2b06c3
CRs-Fixed: 2268810
Currently csr_dump_connection_stats() passes a tpAniSirGlobal to
sme_get_rssi_snr_by_bssid() but a tHalHandle is expected, so correct
the call to pass the correct parameter.
Change-Id: I51216e2636a88fea30b007dcc5eee95000cafe60
CRs-Fixed: 2268809
In csr_roam_call_callback() there is a call to
csr_parse_bss_description_ies() where the MAC context is typecast to
tHalHandle as part of the function call. However this typecast is
incorrect since csr_parse_bss_description_ies() expects to get a MAC
context. Due to the manner in which tHalHandle is defined this does
not current cause a build issue, but an upcoming change will enforce
type checking so update this call to remove the inappropriate
typecasts.
Change-Id: I16e1f33e6f00ed1c610511a60f5974f0f0d71cd5
CRs-Fixed: 2268807
Currently sme_neighbor_report_request() passes a tHalHandle to
sme_rrm_neighbor_report_request(), but a tpAniSirGlobal is expected,
so correct the call to pass the correct parameter.
Change-Id: I4a9ba52ef0a6e345d784937f645cf926bebf8919
CRs-Fixed: 2268806
Currently csr passes a tpAniSirGlobal to sme_ft_open() and
sme_ft_close() but a tHalHandle is expected, so correct the calls to
pass the correct parameter.
Change-Id: I1b33aff2aa9f9ca09384e643aad4e36e79c52af3
CRs-Fixed: 2268804
Currently sme_scan_flush_p2p_result() passes a tHalHandle to
csr_scan_flush_selective_result(), but a tpAniSirGlobal is expected,
so correct the call to pass the correct parameter.
Change-Id: Ibee01bb0606fc3d8a294b455f09c76823b8043bc
CRs-Fixed: 2268803
Currently sme_scan_flush_result() passes a tHalHandle to
csr_scan_flush_result(), but a tpAniSirGlobal is expected,
so correct the call to pass the correct parameter.
Change-Id: I618ed5e16752eb6910060389f7c645b4e9ef5c83
CRs-Fixed: 2268802
Currently sme_scan_get_result_for_bssid() passes a tHalHandle to
csr_scan_get_result_for_bssid(), but a tpAniSirGlobal is expected, so
correct the call to pass the correct parameter.
Change-Id: I7fd7c06f320e14278cb621415bc4631d9c83b5d4
CRs-Fixed: 2268801
In sme_scan_get_result() when calling csr_scan_get_result() a
tHalHandle is currently being passed as the context parameter.
csr_scan_get_result() is expecting a tpAniSirGlobal so pass the
correct parameter.
Change-Id: I6b704f4e1074b15cfbe86a539ac2dee60789e9e0
CRs-Fixed: 2268183
Currently csr_is_mcc_channel() takes a tHalHandle context param.
However csr is internal to the UMAC, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle, so update the API to expect tpAniSirGlobal.
Change-Id: I4feecd5dbc056929ee406e8794e2b284b0b40f21
CRs-Fixed: 2268182
Currently csr_validate_any_default() takes a tHalHandle context param.
However this is a static function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle, so update the API to expect tpAniSirGlobal.
Change-Id: I6bbfe2329e776e1438dca06ad7642cb870796ff6
CRs-Fixed: 2268181
Currently csr_is_wapi_match() takes a tHalHandle context param.
However this is a static function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle, so update the API to expect tpAniSirGlobal.
Change-Id: I0befea1f804204bc5589d33cf2d5fe6fd5126bf1
CRs-Fixed: 2268180
Currently csr_get_wapi_information() takes a tHalHandle context param.
However this is a static function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle, so update the API to expect tpAniSirGlobal.
Change-Id: I54004093c729add183fc3e02033d78f829f47241
CRs-Fixed: 2268179
Currently csr_get_rsn_information() takes a tHalHandle context param.
However this is a static function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle. So update the API to expect tpAniSirGlobal.
Change-Id: I29ad553360eddcf2b990b83bb0d1418d744a85ec
CRs-Fixed: 2268178
Currently csr_is_rsn_match() takes a tHalHandle context param.
However this is a static function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle. So update the API to expect tpAniSirGlobal.
Change-Id: I33a73505039716a38ea94c19d12a0a3ce390b0b3
CRs-Fixed: 2268177
In both csr_create_roam_scan_offload_request() and
csr_neighbor_roam_indicate_disconnect() there is a call to
csr_neighbor_middle_of_roaming() where the MAC context is typecast to
tHalHandle as part of the function call. However these typecasts are
incorrect since csr_neighbor_middle_of_roaming() expects to get a MAC
context. Due to the manner in which tHalHandle is defined this does
not current cause a build issue, but an upcoming change will enforce
type checking so update these calls to remove the inappropriate
typecasts.
Change-Id: I7eeb3eb6b4502c1934a8cffdd1d7372f93ee8ccb
CRs-Fixed: 2268176
Currently csr_get_dot11_mode() takes a tHalHandle context param.
However this is a static function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle. In addition the only caller is already passing
the real context pointer type so update the API to expect
tpAniSirGlobal.
Change-Id: I4f57252f0c94949b3219b5c07143d2545c659871
CRs-Fixed: 2267444
The QoS callback is supposed to pass a mac_handle_t (aka tHalHandle)
to HDD, but in most cases what is actually passed is a tpAniSirGlobal.
Even though these ultimately reference the same structure, an upcoming
change will enforce type safety so update the bad callers to pass a
parameter of the correct type.
Change-Id: I5913c3cf577606f8c207b1e40897b8cbe681de48
CRs-Fixed: 2267442
Function sme_get_current_roam_state() takes a mac_handle_t (aka
tHalHandle) as the first parameter. However in some cases the caller
is actually passing a tpAniSirGlobal. Even though these ultimately
reference the same structure, an upcoming change will enforce type
safety so update the bad callers to pass a parameter of the correct
type.
Change-Id: I3e17de9656fd83598cfd35b63843dd3f7b25d072
CRs-Fixed: 2267441
Currently sme_process_ready_to_suspend() takes a tHalHandle context
param. However this is a static internal function, and hence it
should be using the "real" context pointer type tpAniSirGlobal instead
of the opaque reference tHalHandle, so update the API to expect
tpAniSirGlobal (which is what is already being passed by
sme_process_msg()).
Change-Id: Ic2f28613ce0f4df0a104aaa1ab23b311abe5e334
CRs-Fixed: 2267440
Currently sme_ibss_peer_info_response_handler() takes a tHalHandle
context param. However this is a static internal function, and hence
it should be using the "real" context pointer type tpAniSirGlobal
instead of the opaque reference tHalHandle, so update the API to
expect tpAniSirGlobal (which is what is already being passed by
sme_process_msg()).
Change-Id: I553b485f0e54f173d31e8931f3bda6bba8ede77d
CRs-Fixed: 2267439
Currently sme_tsm_ie_ind() takes a tHalHandle context param. However
this is a static internal function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle, so update the API to expect tpAniSirGlobal
(which is what is already being passed by sme_process_msg()).
Change-Id: Ica6add4b81ad7ffd664ee6e46f2e8b43a731771f
Crs-Fixed: 2267438
Currently sme_ft_send_update_key_ind() takes a tHalHandle context
param. However this is a static internal function, and hence it
should be using the "real" context pointer type tpAniSirGlobal instead
of the opaque reference tHalHandle, so update the API to expect
tpAniSirGlobal (which is what is already being passed by
sme_ft_update_key()).
Change-Id: I5309a6f9125684bc0d7766d5839f2296150b6834
CRs-Fixed: 2267437
Current driver keeps cmd_id as 0 for all non-scan commands which
makes serialization module's logic more complex in order to identify
between duplicate commands.
Add unique cmd_id and attach it to each legacy sme command to make
serialization module's logic easy to distinguish between duplicate
commands.
CRs-Fixed: 2267418
Change-Id: Id2ccb435137061c963120822326fe5b90f857eb7
Currently csr_is_pmf_capabilities_in_rsn_match() takes a tHalHandle
context param. However csr is internal to the UMAC, and hence it
should be using the "real" context pointer type tpAniSirGlobal instead
of the opaque reference tHalHandle, so update the API to expect
tpAniSirGlobal.
Change-Id: Ie13e86dac694bc1c17305f12aeb817387cc7c4bd
CRs-Fixed: 2266509
Currently csr_is_bss_description_wme() takes a tHalHandle context
param. However csr is internal to the UMAC, and hence it should be
using the "real" context pointer type tpAniSirGlobal instead of the
opaque reference tHalHandle, so update the API to expect
tpAniSirGlobal.
Change-Id: I2812f57e57a06a71a81bee20773587fa99189e40
CRs-Fixed: 2266506
Currently sme_unprotected_mgmt_frm_ind() takes a tHalHandle context
param. However this is a static function, and hence it should be
using the "real" context pointer type tpAniSirGlobal instead of the
opaque reference tHalHandle, so update the API to expect
tpAniSirGlobal.
Change-Id: I552cade9adf0bdc7a9cf38c76cd8786548dc7011
CRs-Fixed: 2266505
Currently in sme_update_config() the call to
rrm_change_default_config_param() is passing a mac_handle_t instead of
a tpAniSirGlobal. Change the call to pass the correct parameter.
Change-Id: I1490e3f491c1c8539acc0054343263366fb8bfca
CRs-Fixed: 2266503
Currently in multiple places calls to sme_ps_start_uapsd() are passing
a tpAniSirGlobal instead of a mac_handle_t. Change these calls to pass
the correct parameter.
Change-Id: I9cd30be8eb237423cb621b390be2bbc75ecebb92
CRs-Fixed: 2266502
Currently in sme_get_channel_bonding_mode5_g() and
sme_get_channel_bonding_mode24_g() the calls to sme_get_config_param()
are passing a tpAniSirGlobal instead of a tHalHandle. Change these
calls to pass the correct parameter.
Change-Id: I1fc1b357f96d29babc2bb8439b924fbd1fb74b62
CRs-Fixed: 2266455
In peer assoc command, the phy mode of peer is updated based on
the nw_type of pe session. So this value should accordingly as per
the new channel.
Change-Id: Ib596cb343f239456aba688b2b5ea7b19b3034a66
CRs-Fixed: 2161043
While processing get_station cfg operation, HDD is using Nss
value, which gets updated during association, to calculate data
rate. So, there is a possibility of driver to report invalid
MCS index to upper layer if association happens with Nss 2 and
when data transmission is happening at Nss 1 rate.
On receiving GET STATS response, calculate Nss value based upon
the current data rate received from firmware, and pass it to HDD,
so that HDD can use the same Nss value to report valid MCS index
to the upper layer.
Change-Id: I62f029d53149a4747f619027ce69ce65fb280b8d
CRs-Fixed: 2250993
The SME message callback is currently being used in a manner that is
inconsistent with its signature. The signature specifies that a
tHalHandle should be passed but PE actually passes a tpAniSirGlobal.
Since this is a MAC internal interface update the logic to
consistently use a tpAniSirGlobal.
Change-Id: I8bf94a3dd603b76bdbe7c0db3555736692f64cb7
CRs-Fixed: 2266188
The tSirRetStatus definitions are obsolete, so replace them with
QDF_STATUS definitions in the sme folder.
Change-Id: Ib47c297fb19c350f6ccb7d2c433ebb0eac36b2c4
CRs-Fixed: 2263024
Currently in sme_qos_internal_release_req() and
sme_qos_process_disconnect_ev() the calls to sme_ps_uapsd_disable()
are passing a tpAniSirGlobal instead of a mac_handle_t. Change these
calls to pass the correct parameter.
Change-Id: I93784796753422988a40c4f0f51bdac92b603a43
CRs-Fixed: 2265633
