One of the HDD functions with the highest cyclomatic complexity is
__wlan_hdd_cfg80211_wifi_configuration_set(). In order to reduce the
complexity there is a plan to replace the inline attribute handling
with a vtable-based approach
As the first step of this refactoring add the actual vtable
infrastructure. Later changes will refactor the attribute handling
and populate the vtables.
Change-Id: If79fc61f84bf17a39e300c18681961a4a0e01408
CRs-Fixed: 2371558
Dump DPT and MAC trace after LIM detects disconnection caused by
deauth or disassoc such that in case of RX data stall we can get
all required logs.
Change-Id: I28b129e5b787391e0064a16d9750c463f2310199
CRs-Fixed: 2371708
The driver currently defines three different data structures to hold
mobility domain information:
- tSirMobilityDomainInfo
- tCsrMobilityDomainInfo
- struct mobility_domain_info
To align with the converged software architecture remove the two
legacy typedefs and exclusively use the unified WMI structure.
Change-Id: I317b90e47c3db8b74a76c297f6bc42301fa2f80e
CRs-Fixed: 2369476
Replace legacy isRoamOffloadEnabled from csr_config with
converged flag lfr3_roaming_offload.
Fix CamelCase issues for roam offload part.
Change-Id: I89ceda876d5549e9b0959e7e25e317c9667594b5
CRs-Fixed: 2367873
Use policy manager to set and update the NAN Discovery
related connection info. Disable NAN Discovery
explicitly for unsupported concurrencies.
Handle concurrencies with NAN Discovery interface.
Change-Id: I8c9450b034983ef0402fdc878d8b525bedac9f0b
CRs-Fixed: 2358180
After replace CONFIG_MCL with WLAN_FEATURE_ROAM_OFFLOAD in
struct roam_offload_scan_params, roam_offload_params is only
defined under MACRO WLAN_FEATURE_ROAM_OFFLOAD, any access to
roam_offload_params should be under WLAN_FEATURE_ROAM_OFFLOAD.
Refactor function wma_roam_scan_offload_mode, separate roam scan
offload parameters config to another function.
Change-Id: I3b9306ef3c3ad9c451ffb450df9521cde609bca4
CRs-Fixed: 2367841
Reject con mode handler after driver is unloaded. Proper order is
Driver needs to be re-loaded again and then con mode change handler
needs to be invoked.
Change-Id: Ibc3dfbae1ba3953af537f2d5f50748598a4fe3e1
CRs-Fixed: 2369284
When STA connect and target AP isn't in scan cache, specific
scan for AP ssid will happen, and roam profile is saved in
scan info.
When scan complete, in registered csr scan callback, if connect
need HW mode change, HW mode change is sent to F/W, and roam
profile in scan info is freed at once.
In HW mode change response handler, if roam profile in scan info
is found to be freed, failed to start connect.
Fix:
Make sure roam profile not freed before issue connect.
In specific scan result callback, before issue connect, check
whether need HW mode change.
1. If HW mode change is unneeded or return FAILED, free roam
profile in scan info.
2. If HW mode change return SUCCESS, when cmd is finished or
cancelled, in csr_free_cmd_memory, free roam profile when
cmd is e_sme_command_set_hw_mode with reason
POLICY_MGR_UPDATE_REASON_HIDDEN_STA.
Change-Id: I3f87996de4142baea33dd0f56cb2a892f0387336
CRs-Fixed: 2369154
Change I5afd04a5ed5d4d0bd3438d95cc4f6c214ad4bc3d ("qcacld-3.0: Remove
sme_set_tm_level()") removed the last usage of tAniSetTmLevelReq.
Since it is obsolete, remove it.
Change-Id: I2a44f2a3b5f0e924d4dc0d9a9563b359a0366577
CRs-Fixed: 2371206
Field mgmtFrameSessionId in tAniSirLim is initialized but is otherwise
never referenced. Since the field is unused, remove it.
Change-Id: I27239cbe92d9b1de32fe003cd977e2c8ccc18017
CRs-Fixed: 2371202
Change Idf75957707c3799add0c59fdd532fe0c24d27117 ("qcacld-3.0: Remove
obsolete STA support for SIOCSIWESSID") removed the last client of
hdd_wmm_get_uapsd_mask(). Since this function is now unused, remove
it.
Change-Id: I28b1909690e1f1c813f4169b6429a7faecdac7d6
CRs-Fixed: 2371200
Change I1d45de261c50f1835379a9cc1df4631f3e32f459 ("qcacld-3.0: Purge
all serialization commands on csr stop") removed the only client of
csr_purge_vdev_all_ser_cmd_list(). Since this function is now unused,
remove it.
Change-Id: I62ff513aa817d9b7fd4dcec156d53c02a1de40e2
CRs-Fixed: 2371198
Change I913b6e769f282a0f5a0ddb40e54d294ae07deb55 ("qcacld-3.0: Remove
unused concurrency ini parameters") removed the last client of
csr_is_sta_session_connected(). Since this function is unused, remove
it.
Change-Id: I6c14227fb1364b37dd570cd658aedb0b5b10b341
CRs-Fixed: 2371197
Change Ib9cdaf7e8aa019002b9fc02d8ffacfcdb28fc121 ("qcacld-3.0:
Remove sme_ipa_uc_stat_request()") removed the last client of
wma_ipa_uc_stat_request(). Since this function is now obsolete,
remove it.
Change-Id: I965ccad2e94246c0d7d57e85c1fa433eeb5c136e
CRs-Fixed: 2371196
Change Ief51bcf611d5d5759fa04e05c0bb4d96e44c7a29 ("qcacld-3.0:
Remove sme_get_wcnss_*_version()") removed the last client of
wma_get_wcnss_software_version(). Since this function is obsolete,
remove it.
Change-Id: Ie3e8fcb48e45deebc750c9886f268d5306a7b705
CRs-Fixed: 2371195
Change Id39629e33e87ffe6ed58f375609a55e324618693 ("qcacld-3.0: Apply
second part of LFR INIs changes in HDD layer") removed the last client
of sme_set_neighbor_scan_min_period()"). Since this function is
unused, remove it.
Change-Id: I305b9d78582b5e633079daeb864da703428314d8
CRs-Fixed: 2371192
Change Idf75957707c3799add0c59fdd532fe0c24d27117 ("qcacld-3.0: Remove
obsolete STA support for SIOCSIWESSID") removed the only client of
sme_set_dhcp_till_power_active_flag(). Since this function is now
unused, remove it.
Change-Id: I161122772fbc6e588384ac10382885cafdadbc3e
CRs-Fixed: 2371191
Change Ifff2ef2c8790994a68e676b8bba2fb03c21370d4 ("qcacld-3.0: Enable
station SMPS only if the session supported NSS > 1") introduced
function sme_is_sta_smps_allowed(). However this function has
subsequently never been used, so remove it.
Change-Id: I0a4d134986dd3a03d12e907f6df6ecb29b268eb3
CRs-Fixed: 2371155
The following legacy functions are unused, so remove them:
- sme_is11d_supported()
- sme_is11h_supported()
- sme_is_wmm_supported()
Change-Id: I50016f7695d873f551f214504b54c0cbeb40564f
CRs-Fixed: 2371154
Change Id4691e0f490c2f9bd9ccc8d5225be32002a5df9e ("qcacld-3.0:
Remove legacy IPA code from HDD") removed the last client of
sme_ipa_uc_stat_request(). Since the function is unused, remove it.
Change-Id: Ib9cdaf7e8aa019002b9fc02d8ffacfcdb28fc121
CRs-Fixed: 2371153
Change I994e53b17788472de979df9dce9e18c6f68de850 ("qcacld-3.0: Add
support for regulatory component ucfg apis") removed the last client
of sme_handle_dfs_chan_scan(). Since this function is now unused,
remove it.
Change-Id: Id4bad555c0cd52c736c7c934e4892953dc27c582
CRs-Fixed: 2371151
Change Ib37eff0591d9c043e62883329c12410fcca67223 ("qcacld-3.0: Remove
sme_get_infra_session_id()") removed the only client of
csr_get_infra_session_id(). Since this function is now unused, remove
it.
Change-Id: I32d0875087ad1f55ec8e8ee2985f7397fefb525d
CRs-Fixed: 2371149
Change I0ded9473083418f6bb33cec4fa43a17c8c281177 ("qcacld-3.0: Remove
hdd_exchange_version_and_caps()") removed the only client of
sme_feature_caps_exchange(). Since this function is an obsolete stub,
remove it.
Change-Id: I0899e4befbf995436729c90caeda982e8b5ec1ff
CRs-Fixed: 2371146
Change I0ded9473083418f6bb33cec4fa43a17c8c281177 ("qcacld-3.0: Remove
hdd_exchange_version_and_caps()") removed the only client of
sme_disable_feature_capablity(). Since this function is an obsolete
stub, remove it.
Change-Id: I8cf83e7f370a644c6e814aa7b4aedad1f7fec88f
CRs-Fixed: 2371145
Change Ia0fa016b174ef4b50e2cc339e4e476ec65642dbf ("qcacld-3.0:
Use dfs component support") removed the last client of
sap_dfs_is_channel_in_preferred_location(). Since this function
is now obsolete, remove it.
Change-Id: I137a00699511c7f019f6cf3b8f0579aeb52c7778
CRs-Fixed: 2371144
Change I92f79f595e881fccb6eb5e87fcfa29e8f26fa1a5 ("qcacld-3.0:
Remove sme_store_joinreq_param()") removed the last client of
csr_store_joinreq_param(). Since this function is now unused,
remove it.
Change-Id: Ie3f7a8a581a505a29ddb96825eafe265c6d01479
CRs-Fixed: 2371142
Change I3050cd9a704f9c2489a11c75cd439224e44b8748 ("qcacld-3.0: Remove
csr_roam_connect_to_last_profile()") removed the last client of
csr_move_bss_to_head_from_bssid(). Since this function is now unused,
remove it.
Change-Id: Ib83c7fa596d589ba9eed5803701f24d4634ad645
CRs-Fixed: 2371141
Change I795bfd1d19f81d703bd9d903ebc53e61b014c5c3 ("qcacld-3.0:
Remove sme_clear_joinreq_param()") removed the last client of
csr_clear_joinreq_param(). Since this function is now unused,
remove it.
Change-Id: I8482ddb4c2410c93fc7d982d6f1cd024b4d66d17
CRs-Fixed: 2371140
Change I6cb9fe12bee3702556c9b52e7ccb7c69c762d8de ("qcacld-3.0: Remove
legacy code for policy manager restructuring") removed the last client
of sme_clear_joinreq_param(). Since this function is now unused,
remove it.
Change-Id: I795bfd1d19f81d703bd9d903ebc53e61b014c5c3
CRs-Fixed: 2371139
Change I360a0c0f7508026f1889e1998eeaac01464382de ("qcacld-3.0: Remove
sme_issue_stored_joinreq()") removed the last client of
csr_issue_stored_joinreq(). Since the function is now unused, remove
it.
Change-Id: I0ec6ae46c5b90ab6619f03ab76d95ca4e45ad450
CRs-Fixed: 2371138
Change I913b6e769f282a0f5a0ddb40e54d294ae07deb55 ("qcacld-3.0: Remove
unused concurrency ini parameters") removed the last client of
csr_is_p2p_session_connected(). Since this function is now unused,
remove it.
Change-Id: Ifd4f4f52bfe6e5be4b472a47cfea765b336a8daf
CRs-Fixed: 2371137
Change I2b469c6cb2e6bdfc735b04e9bd6f12ba0d41fea4 ("qcacld-3.0: Remove
sme_is_sta_p2p_client_connected()") removed the last client of
csr_is_infra_connected(). Since the function is now obsolete, remove
it.
Change-Id: I5a71cad7414aee56a981e640ef66687fe0433b4f
CRs-Fixed: 2371135
Change Ia95c4911600a45d1004b9e6148b1b04f414e2475 ("qcacld-3.0: Remove
support for eWNI_SME_GET_WPSPBC_SESSION_REQ") removed the last client
of lim_get_wpspbc_sessions(). Since this function is now obsolete,
remove it.
Change-Id: I2df051e00dd788767c4f176395a50ea2a16eead2
CRs-Fixed: 2371102
Field gLimHeartBeatCount in tAniSirLim is initialized but is otherwise
never used, so remove it.
Change-Id: I02c30aa599c1c43bab4cce6f8fff386696e74a96
CRs-Fixed: 2371101
Change I8beb48c378e532c27f317d946bdf58b2aa512c14 ("qcacld-3.0:
Remove csr_roam_get_associated_stas()") removed the last client of
csr_send_mb_get_associated_stas_req_msg(). Since this function is
obsolete, remove it.
Change-Id: I050383ce7e922fe4e42e1f5c4d2a8260dddbd4bb
CRs-Fixed: 2371100
Change I913b6e769f282a0f5a0ddb40e54d294ae07deb55 ("qcacld-3.0: Remove
unused concurrency ini parameters") removed the last client of
csr_is_concurrent_infra_connected(). Since it is obsolete, remove it.
Change-Id: Ibec4e93c2da7411544c491e08198b146074a1779
CRs-Fixed: 2371097
Change Ia95c4911600a45d1004b9e6148b1b04f414e2475 ("qcacld-3.0: Remove
support for eWNI_SME_GET_WPSPBC_SESSION_REQ") removed the last client
of lim_remove_pbc_sessions(). Since the function is now obsolete,
remove it.
Change-Id: Icacb3f2d2097d3f9866251740855770b86ec19bf
CRs-Fixed: 2371093
Change I64d0b71853004679ae694bcd6ca7a2f2347adc84 ("qcacld-3.0:
Remove legacy P2P codes in MAC") removed the last client of
lim_populate_p2p_mac_header(). Since this function is now
obsolete, remove it.
Change-Id: I3adb55dcf3eb3b14c6f7d6a82e686f13c3d955a1
CRs-Fixed: 2371092
Change I8a4cf81d4a2f561e2464b3e32c21202b5779de07 ("qcacld-3.0:
Remove sme_scan_flush_p2p_result()" removed the last client of
csr_scan_flush_selective_result(). Since this function is now
obsolete, remove it.
Change-Id: I42d5d020e2320a490c38dd7d021dd7ac395717c2
CRs-Fixed: 2370968
Change I98ef4dc56bd820849b038de5b33665f3bb7b01b4 ("qcacld-3.0: Remove
sme_roam_get*_pmkid_cache()") removed the only clients for the
associated CSR functions, so remove the following now obsolete
functions:
- csr_roam_get_pmkid_cache()
- csr_roam_get_num_pmkid_cache()
Change-Id: Id535e5b863e3cd2f2ec538159bc5dac13cc8d568
CRs-Fixed: 2370967
Change Ieff533b5abca419fa2ffeabfcbfe9b2cf8eb5879 ("qcacld-3.0: Remove
sme_roam_get_connect_state()") removed the only client of
csr_roam_get_connect_state(). Since this function is now obsolete,
remove it.
Change-Id: If0f8ceaaf0ccddad5e0248b7f5d9cd1c58d5c253
CRs-Fixed: 2370966
Change I55b6604b17c736d513dc9baf9045fb634ed7a19d ("qcacld-3.0:
Remove sme_roam_get_associated_stas()") removed the only client of
csr_roam_get_associated_stas(). Since this function is now obsolete,
remove it.
Change-Id: I8beb48c378e532c27f317d946bdf58b2aa512c14
CRs-Fixed: 2370965
Change Idb53c7cd871c0ccbacd3899f14fccc2a67935f4f ("qcacld-3.0:
Remove sme_roam_connect_to_last_profile()" removed the only
client of csr_roam_connect_to_last_profile(). Since this
function is now obsolete, remove it, along with the helper
function csr_roam_join_last_profile().
Change-Id: I3050cd9a704f9c2489a11c75cd439224e44b8748
CRs-Fixed: 2370964
Change I0e27d6dc72e26589b5973bd7668a1783ac132477 ("qcacld-3.0: Remove
serialization from open and close session") removed the last client of
csr_prepare_disconnect_command(). Since this is now obsolete, remove
it.
Change-Id: Ib67f580a79dfc8c29c04c375ce2a8ff1538c7552
CRs-Fixed: 2370962
Change I7e04b4488b10021d6815e76d0a55e040756b1794 ("qcacld-3.0: Remove
unused SCAN code under NAPIER_SCAN define") removed the last client of
csr_is_any_session_connected(). Since this function is now obsolete,
remove it.
Change-Id: Ide7a12b07907be0480445f886e419801bda2217d
CRs-Fixed: 2370963
The separate ValidChannelList & ValidChannelCount fields in
tSirRoamOffloadScanReq are obsolete since the valid channels are now
handled as part of the ConnectedNetwork struct, therefore remove
support for these obsolete fields.
Change-Id: Ic413d52f95fcc7082e1dfdd28d28513d6a7a2e7d
CRs-Fixed: 2370961
The BkidCandidateInfo and NumBkidCandidate fields in struct
csr_roam_session are initialized by csr_reset_bkid_candidate_list(),
but are otherwise unused. Since these are unused, remove the entire
infrastructure.
Change-Id: Ifb29e88b8c137a08ea65625ec4677ec7e8676298
CRs-Fixed: 2370960
Field NeighborRoamScanRefreshPeriod in tSirRoamOffloadScanRsp is
unused, so remove.
Change-Id: I54b9bc8cadfd00aded1719981917254d6fb1b14a
CRs-Fixed: 2370959
Field PEPreauthRespTimeout in tCsr11rAssocNeighborInfo is initialized
but never read. Since this field is unused, remove it.
Change-Id: Ifb812d9fec695cf410a10bd40fb4ec97f0c41d16
CRs-Fixed: 2370958
Change Icb45c37358dcfacbea8e3b3f40b93189d62e1be4 ("qcacld-3.0: Pass
short_retry_limit and long_retry_limit to FW") removed the last cleint
of the following functions:
- sme_update_short_retry_limit_threshold()
- sme_update_long_retry_limit_threshold()
Since these functions are now unused, remove them.
Change-Id: I5dddf069e2a04826e44b7ef1761d326bd88d9408
CRs-Fixed: 2370897
Add NAN Discovery specific modes, modules that manage NAN
Discovery interface. Add cases and exceptions that manage
concurrent operations alongside NAN Discovery.
Add policy manager changes to manage NAN Discovery.
Change-Id: Ib9a10be265c14adf8d1d5f2f2e2b65aa399d6636
CRs-Fixed: 2358183
The user setting value is checked against the previous setting
hence if the current setting value is greater than previous setting
then driver returns error.
Check the user setting value against the range and update the param
value.
Change-Id: I2c730b71668efa7932600328459da9347d3e1d2f
CRs-Fixed: 2371024
Change I6cb9fe12bee3702556c9b52e7ccb7c69c762d8de ("qcacld-3.0: Remove
legacy code for policy manager restructuring") removed the last client
of sme_store_joinreq_param(). Since it is no longer used, remove it.
Change-Id: I92f79f595e881fccb6eb5e87fcfa29e8f26fa1a5
CRs-Fixed: 2370896
Change Ic160dfafcfa015eb42a226304260b1be3dddc6f0
("qcacld-3.0: cleanup legacy scan request processing"
removed the last client of sme_scan_flush_p2p_result().
Since it is now unused, remove it.
Change-Id: I8a4cf81d4a2f561e2464b3e32c21202b5779de07
CRs-Fixed: 2370895
The following functions are unused, so remove them:
- sme_roam_get_pmkid_cache()
- sme_roam_get_num_pmkid_cache()
Change-Id: I98ef4dc56bd820849b038de5b33665f3bb7b01b4
CRs-Fixed: 2370894
Change I4a452d6eed9eb035ad124fb5cd1fe5f62f507b5f ("qcacld-3.0:
Remove wlansap_get_assoc_stations()") removed the last client of
sme_roam_get_associated_stas(). Since it is now obsolete, remove
it as well.
Change-Id: I55b6604b17c736d513dc9baf9045fb634ed7a19d
CRs-Fixed: 2370892
Change I6cb9fe12bee3702556c9b52e7ccb7c69c762d8de ("qcacld-3.0: Remove
legacy code for policy manager restructuring") removed the client of
sme_register_hw_mode_trans_cb(). Since this function is obsolete,
remove it along with the underlying data structures.
Change-Id: Ibc478a6e2a4d50ee57324ee2431ae677dcb1e3a0
CRs-Fixed: 2370889
Change Ifa27ecdf1e37eda6f929f89da603bc356e9cb7fd ("qcacld-3.0: legacy
code change for policy manager restructuring") removed the only client
of sme_issue_stored_joinreq(). Since this function is now unused,
remove it.
Change-Id: I360a0c0f7508026f1889e1998eeaac01464382de
CRs-Fixed: 2370887
Change Id84eb7cf579a29da30f3366edef24821fcd5be55 ("qcacld-3.0:
Cleanup qpower vendor command") removed the only client of
sme_is_auto_ps_timer_running(). Since this function is now
unused, remove it.
Change-Id: I00692e5ac8981752e609bb21cef4c76cfc03c838
CRs-Fixed: 2370886
Change I0ded9473083418f6bb33cec4fa43a17c8c281177 ("qcacld-3.0: Remove
hdd_exchange_version_and_caps()") removed the only client of the
following functions:
- sme_get_wcnss_wlan_compiled_version()
- sme_get_wcnss_wlan_reported_version()
- sme_get_wcnss_software_version()
- sme_get_wcnss_hardware_version()
Since these are now obsolete, remove them along with the underlying
tSirVersionType data structure.
Change-Id: Ief51bcf611d5d5759fa04e05c0bb4d96e44c7a29
CRs-Fixed: 2370885
Change I7c5fc06c66c004aa5c1a208376d1ab4b88956a6f ("qcacld-3.0:
Fix channel selection failure after radar is detected") removed
the only client of functions sme_get_channel_bonding_mode24_g() and
sme_get_channel_bonding_mode5_g(). Snce these are now unused,
remove them.
Change-Id: I21e6b5a927e27063f6393930a3933ee7b53b7e1e
CRs-Fixed: 2370883
Change Ib943f9de70a78ba5d5e87d81c76b20341893f8e9 ("qcacld-3.0:
Enable MAC provisioning from ini") removed the last client of
sme_cfg_set_str(). Since the CFG is being phased out there
should not be any new clients for this function, so remove it.
Change-Id: Ie97bb639423ceb0be41dab686d85dae46e4acff7
CRs-Fixed: 2370882
Change Idaaacac4fdaf1b964432c33c10b1c86f8a591c2d ("qcacld-3.0: Remove
legacy P2P codes in HDD") removed the logic which utilized the
rem_on_chan_ready_event field in struct hdd_adapter. Since this field
is no longer used, remove it.
Change-Id: Ic8947dc70d510bd123759e53e58e33c5b64ec130
CRs-Fixed: 2370881
Change Iba16643adf1cbd997138c740345e40c00c8e81f6 ("qcacld-3.0: Add
Suspend and Resume support in PMO") removed the logic which sent the
eWNI_SME_READY_TO_SUSPEND_IND message. However it left behind the
handler function in SME which will now never be called. Since this
message is now unused, remove the remaining infrastructure that
originally supported this message.
Change-Id: I91ef442eeb3fd0bb6dc3cccd803c77329b0c730f
CRs-Fixed: 2370880
Change I64d0b71853004679ae694bcd6ca7a2f2347adc84 ("qcacld-3.0: Remove
legacy P2P codes in MAC") removed the client of the PE Global Lock
Infrastucture. Since this is no longer used, remove it.
Change-Id: I71a7d98667eb779c1f62cc9d02a877814ad1d7a0
CRs-Fixed: 2370877
The is_nan_enabled flag in wma_handle_t is written but never read.
Since it is unused, remove it along with the logic that writes it.
Change-Id: I3e7d09ac1ab77427d37a8a45ca5f1612b05c5339
CRs-Fixed: 2370875
