476c942d9b
Control Flow Integrity(CFI) is a security mechanism that disallows
changes to the original control flow graph of a compiled binary,
making it significantly harder to perform such attacks.
init_state_node() assign same function callback to different
function pointer declarations.
static int init_state_node(struct cpuidle_state *idle_state,
const struct of_device_id *matches,
struct device_node *state_node) { ...
idle_state->enter = match_id->data; ...
idle_state->enter_s2idle = match_id->data; }
Function declarations:
struct cpuidle_state { ...
int (*enter) (struct cpuidle_device *dev,
struct cpuidle_driver *drv,
int index);
void (*enter_s2idle) (struct cpuidle_device *dev,
struct cpuidle_driver *drv,
int index); };
In this case, either enter() or enter_s2idle() would cause CFI check
failed since they use same callee.
Align function prototype of enter() since it needs return value for
some use cases. The return value of enter_s2idle() is no
need currently.
Bug: 159445192
Bug: 159672235
Change-Id: Iffc9e1b6a17471ca4291865ab3dc8803303a38ce
Link: https://lore.kernel.org/lkml/1595820346-4361-2-git-send-email-neal.liu@mediatek.com/
Signed-off-by: Neal Liu <neal.liu@mediatek.com>
Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
92 lines
1.9 KiB
C
92 lines
1.9 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (c) 2013, NVIDIA Corporation. All rights reserved.
|
|
*/
|
|
|
|
#include <asm/firmware.h>
|
|
#include <linux/tick.h>
|
|
#include <linux/cpuidle.h>
|
|
#include <linux/cpu_pm.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/firmware/trusted_foundations.h>
|
|
|
|
#include <asm/cpuidle.h>
|
|
#include <asm/smp_plat.h>
|
|
#include <asm/suspend.h>
|
|
#include <asm/psci.h>
|
|
|
|
#include "cpuidle.h"
|
|
#include "pm.h"
|
|
#include "sleep.h"
|
|
|
|
#ifdef CONFIG_PM_SLEEP
|
|
#define TEGRA114_MAX_STATES 2
|
|
#else
|
|
#define TEGRA114_MAX_STATES 1
|
|
#endif
|
|
|
|
#ifdef CONFIG_PM_SLEEP
|
|
static int tegra114_idle_power_down(struct cpuidle_device *dev,
|
|
struct cpuidle_driver *drv,
|
|
int index)
|
|
{
|
|
local_fiq_disable();
|
|
|
|
tegra_set_cpu_in_lp2();
|
|
cpu_pm_enter();
|
|
|
|
call_firmware_op(prepare_idle, TF_PM_MODE_LP2_NOFLUSH_L2);
|
|
|
|
/* Do suspend by ourselves if the firmware does not implement it */
|
|
if (call_firmware_op(do_idle, 0) == -ENOSYS)
|
|
cpu_suspend(0, tegra30_sleep_cpu_secondary_finish);
|
|
|
|
cpu_pm_exit();
|
|
tegra_clear_cpu_in_lp2();
|
|
|
|
local_fiq_enable();
|
|
|
|
return index;
|
|
}
|
|
|
|
static int tegra114_idle_enter_s2idle(struct cpuidle_device *dev,
|
|
struct cpuidle_driver *drv,
|
|
int index)
|
|
{
|
|
tegra114_idle_power_down(dev, drv, index);
|
|
|
|
return 0;
|
|
}
|
|
#endif
|
|
|
|
static struct cpuidle_driver tegra_idle_driver = {
|
|
.name = "tegra_idle",
|
|
.owner = THIS_MODULE,
|
|
.state_count = TEGRA114_MAX_STATES,
|
|
.states = {
|
|
[0] = ARM_CPUIDLE_WFI_STATE_PWR(600),
|
|
#ifdef CONFIG_PM_SLEEP
|
|
[1] = {
|
|
.enter = tegra114_idle_power_down,
|
|
.enter_s2idle = tegra114_idle_enter_s2idle,
|
|
.exit_latency = 500,
|
|
.target_residency = 1000,
|
|
.flags = CPUIDLE_FLAG_TIMER_STOP,
|
|
.power_usage = 0,
|
|
.name = "powered-down",
|
|
.desc = "CPU power gated",
|
|
},
|
|
#endif
|
|
},
|
|
};
|
|
|
|
int __init tegra114_cpuidle_init(void)
|
|
{
|
|
if (!psci_smp_available())
|
|
return cpuidle_register(&tegra_idle_driver, NULL);
|
|
|
|
return 0;
|
|
}
|