d65de5ee8b
[ Upstream commit ab327f8acdf8d06601fbf058859a539a9422afff ]
RAC flush causes kernel panics on BCM6358 with EHCI/OHCI when booting from TP1:
[ 3.881739] usb 1-1: new high-speed USB device number 2 using ehci-platform
[ 3.895011] Reserved instruction in kernel code[#1]:
[ 3.900113] CPU: 0 PID: 1 Comm: init Not tainted 5.10.16 #0
[ 3.905829] $ 0 : 00000000 10008700 00000000 77d94060
[ 3.911238] $ 4 : 7fd1f088 00000000 81431cac 81431ca0
[ 3.916641] $ 8 : 00000000 ffffefff 8075cd34 00000000
[ 3.922043] $12 : 806f8d40 f3e812b7 00000000 000d9aaa
[ 3.927446] $16 : 7fd1f068 7fd1f080 7ff559b8 81428470
[ 3.932848] $20 : 00000000 00000000 55590000 77d70000
[ 3.938251] $24 : 00000018 00000010
[ 3.943655] $28 : 81430000 81431e60 81431f28 800157fc
[ 3.949058] Hi : 00000000
[ 3.952013] Lo : 00000000
[ 3.955019] epc : 80015808 setup_sigcontext+0x54/0x24c
[ 3.960464] ra : 800157fc setup_sigcontext+0x48/0x24c
[ 3.965913] Status: 10008703 KERNEL EXL IE
[ 3.970216] Cause : 00800028 (ExcCode 0a)
[ 3.974340] PrId : 0002a010 (Broadcom BMIPS4350)
[ 3.979170] Modules linked in: ohci_platform ohci_hcd fsl_mph_dr_of ehci_platform ehci_fsl ehci_hcd gpio_button_hotplug usbcore nls_base usb_common
[ 3.992907] Process init (pid: 1, threadinfo=(ptrval), task=(ptrval), tls=77e22ec8)
[ 4.000776] Stack : 81431ef4 7fd1f080 81431f28 81428470 7fd1f068 81431edc 7ff559b8 81428470
[ 4.009467] 81431f28 7fd1f080 55590000 77d70000 77d5498c 80015c70 806f0000 8063ae74
[ 4.018149] 08100002 81431f28 0000000a 08100002 81431f28 0000000a 77d6b418 00000003
[ 4.026831] ffffffff 80016414 80080734 81431ecc 81431ecc 00000001 00000000 04000000
[ 4.035512] 77d54874 00000000 00000000 00000000 00000000 00000012 00000002 00000000
[ 4.044196] ...
[ 4.046706] Call Trace:
[ 4.049238] [<80015808>] setup_sigcontext+0x54/0x24c
[ 4.054356] [<80015c70>] setup_frame+0xdc/0x124
[ 4.059015] [<80016414>] do_notify_resume+0x1dc/0x288
[ 4.064207] [<80011b50>] work_notifysig+0x10/0x18
[ 4.069036]
[ 4.070538] Code: 8fc300b4 00001025 26240008 <ac820000> ac830004 3c048063 0c0228aa 24846a00 26240010
[ 4.080686]
[ 4.082517] ---[ end trace 22a8edb41f5f983b ]---
[ 4.087374] Kernel panic - not syncing: Fatal exception
[ 4.092753] Rebooting in 1 seconds..
Because the bootloader (CFE) is not initializing the Read-ahead cache properly
on the second thread (TP1). Since the RAC was not initialized properly, we
should avoid flushing it at the risk of corrupting the instruction stream as
seen in the trace above.
Fixes: d59098a0e9
("MIPS: bmips: use generic dma noncoherent ops")
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
213 lines
5.2 KiB
C
213 lines
5.2 KiB
C
/*
|
|
* This file is subject to the terms and conditions of the GNU General Public
|
|
* License. See the file "COPYING" in the main directory of this archive
|
|
* for more details.
|
|
*
|
|
* Copyright (C) 2008 Maxime Bizon <mbizon@freebox.fr>
|
|
* Copyright (C) 2014 Kevin Cernekee <cernekee@gmail.com>
|
|
*/
|
|
|
|
#include <linux/init.h>
|
|
#include <linux/bitops.h>
|
|
#include <linux/memblock.h>
|
|
#include <linux/clk-provider.h>
|
|
#include <linux/ioport.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/io.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_fdt.h>
|
|
#include <linux/of_platform.h>
|
|
#include <linux/libfdt.h>
|
|
#include <linux/smp.h>
|
|
#include <asm/addrspace.h>
|
|
#include <asm/bmips.h>
|
|
#include <asm/bootinfo.h>
|
|
#include <asm/cpu-type.h>
|
|
#include <asm/mipsregs.h>
|
|
#include <asm/prom.h>
|
|
#include <asm/smp-ops.h>
|
|
#include <asm/time.h>
|
|
#include <asm/traps.h>
|
|
|
|
#define RELO_NORMAL_VEC BIT(18)
|
|
|
|
#define REG_BCM6328_OTP ((void __iomem *)CKSEG1ADDR(0x1000062c))
|
|
#define BCM6328_TP1_DISABLED BIT(9)
|
|
|
|
extern bool bmips_rac_flush_disable;
|
|
|
|
static const unsigned long kbase = VMLINUX_LOAD_ADDRESS & 0xfff00000;
|
|
|
|
struct bmips_quirk {
|
|
const char *compatible;
|
|
void (*quirk_fn)(void);
|
|
};
|
|
|
|
static void kbase_setup(void)
|
|
{
|
|
__raw_writel(kbase | RELO_NORMAL_VEC,
|
|
BMIPS_GET_CBR() + BMIPS_RELO_VECTOR_CONTROL_1);
|
|
ebase = kbase;
|
|
}
|
|
|
|
static void bcm3384_viper_quirks(void)
|
|
{
|
|
/*
|
|
* Some experimental CM boxes are set up to let CM own the Viper TP0
|
|
* and let Linux own TP1. This requires moving the kernel
|
|
* load address to a non-conflicting region (e.g. via
|
|
* CONFIG_PHYSICAL_START) and supplying an alternate DTB.
|
|
* If we detect this condition, we need to move the MIPS exception
|
|
* vectors up to an area that we own.
|
|
*
|
|
* This is distinct from the OTHER special case mentioned in
|
|
* smp-bmips.c (boot on TP1, but enable SMP, then TP0 becomes our
|
|
* logical CPU#1). For the Viper TP1 case, SMP is off limits.
|
|
*
|
|
* Also note that many BMIPS435x CPUs do not have a
|
|
* BMIPS_RELO_VECTOR_CONTROL_1 register, so it isn't safe to just
|
|
* write VMLINUX_LOAD_ADDRESS into that register on every SoC.
|
|
*/
|
|
board_ebase_setup = &kbase_setup;
|
|
bmips_smp_enabled = 0;
|
|
}
|
|
|
|
static void bcm63xx_fixup_cpu1(void)
|
|
{
|
|
/*
|
|
* The bootloader has set up the CPU1 reset vector at
|
|
* 0xa000_0200.
|
|
* This conflicts with the special interrupt vector (IV).
|
|
* The bootloader has also set up CPU1 to respond to the wrong
|
|
* IPI interrupt.
|
|
* Here we will start up CPU1 in the background and ask it to
|
|
* reconfigure itself then go back to sleep.
|
|
*/
|
|
memcpy((void *)0xa0000200, &bmips_smp_movevec, 0x20);
|
|
__sync();
|
|
set_c0_cause(C_SW0);
|
|
cpumask_set_cpu(1, &bmips_booted_mask);
|
|
}
|
|
|
|
static void bcm6328_quirks(void)
|
|
{
|
|
/* Check CPU1 status in OTP (it is usually disabled) */
|
|
if (__raw_readl(REG_BCM6328_OTP) & BCM6328_TP1_DISABLED)
|
|
bmips_smp_enabled = 0;
|
|
else
|
|
bcm63xx_fixup_cpu1();
|
|
}
|
|
|
|
static void bcm6358_quirks(void)
|
|
{
|
|
/*
|
|
* BCM3368/BCM6358 need special handling for their shared TLB, so
|
|
* disable SMP for now
|
|
*/
|
|
bmips_smp_enabled = 0;
|
|
|
|
/*
|
|
* RAC flush causes kernel panics on BCM6358 when booting from TP1
|
|
* because the bootloader is not initializing it properly.
|
|
*/
|
|
bmips_rac_flush_disable = !!(read_c0_brcm_cmt_local() & (1 << 31));
|
|
}
|
|
|
|
static void bcm6368_quirks(void)
|
|
{
|
|
bcm63xx_fixup_cpu1();
|
|
}
|
|
|
|
static const struct bmips_quirk bmips_quirk_list[] = {
|
|
{ "brcm,bcm3368", &bcm6358_quirks },
|
|
{ "brcm,bcm3384-viper", &bcm3384_viper_quirks },
|
|
{ "brcm,bcm33843-viper", &bcm3384_viper_quirks },
|
|
{ "brcm,bcm6328", &bcm6328_quirks },
|
|
{ "brcm,bcm6358", &bcm6358_quirks },
|
|
{ "brcm,bcm6362", &bcm6368_quirks },
|
|
{ "brcm,bcm6368", &bcm6368_quirks },
|
|
{ "brcm,bcm63168", &bcm6368_quirks },
|
|
{ "brcm,bcm63268", &bcm6368_quirks },
|
|
{ },
|
|
};
|
|
|
|
void __init prom_init(void)
|
|
{
|
|
bmips_cpu_setup();
|
|
register_bmips_smp_ops();
|
|
}
|
|
|
|
void __init prom_free_prom_memory(void)
|
|
{
|
|
}
|
|
|
|
const char *get_system_type(void)
|
|
{
|
|
return "Generic BMIPS kernel";
|
|
}
|
|
|
|
void __init plat_time_init(void)
|
|
{
|
|
struct device_node *np;
|
|
u32 freq;
|
|
|
|
np = of_find_node_by_name(NULL, "cpus");
|
|
if (!np)
|
|
panic("missing 'cpus' DT node");
|
|
if (of_property_read_u32(np, "mips-hpt-frequency", &freq) < 0)
|
|
panic("missing 'mips-hpt-frequency' property");
|
|
of_node_put(np);
|
|
|
|
mips_hpt_frequency = freq;
|
|
}
|
|
|
|
void __init plat_mem_setup(void)
|
|
{
|
|
void *dtb;
|
|
const struct bmips_quirk *q;
|
|
|
|
set_io_port_base(0);
|
|
ioport_resource.start = 0;
|
|
ioport_resource.end = ~0;
|
|
|
|
/* intended to somewhat resemble ARM; see Documentation/arm/booting.rst */
|
|
if (fw_arg0 == 0 && fw_arg1 == 0xffffffff)
|
|
dtb = phys_to_virt(fw_arg2);
|
|
else if (fw_passed_dtb) /* UHI interface or appended dtb */
|
|
dtb = (void *)fw_passed_dtb;
|
|
else if (&__dtb_start != &__dtb_end)
|
|
dtb = (void *)__dtb_start;
|
|
else
|
|
panic("no dtb found");
|
|
|
|
__dt_setup_arch(dtb);
|
|
|
|
for (q = bmips_quirk_list; q->quirk_fn; q++) {
|
|
if (of_flat_dt_is_compatible(of_get_flat_dt_root(),
|
|
q->compatible)) {
|
|
q->quirk_fn();
|
|
}
|
|
}
|
|
}
|
|
|
|
void __init device_tree_init(void)
|
|
{
|
|
struct device_node *np;
|
|
|
|
unflatten_and_copy_device_tree();
|
|
|
|
/* Disable SMP boot unless both CPUs are listed in DT and !disabled */
|
|
np = of_find_node_by_name(NULL, "cpus");
|
|
if (np && of_get_available_child_count(np) <= 1)
|
|
bmips_smp_enabled = 0;
|
|
of_node_put(np);
|
|
}
|
|
|
|
static int __init plat_dev_init(void)
|
|
{
|
|
of_clk_init(NULL);
|
|
return 0;
|
|
}
|
|
|
|
device_initcall(plat_dev_init);
|