ac7c3b8f34
[ Upstream commit b344d6a83d01c52fddbefa6b3b4764da5b1022a0 ] The kernel test bot reported[1] that using set_mask_bits on a u8 causes the following issue on parisc: hppa-linux-ld: drivers/phy/ti/phy-tusb1210.o: in function `tusb1210_probe': >> (.text+0x2f4): undefined reference to `__cmpxchg_called_with_bad_pointer' >> hppa-linux-ld: (.text+0x324): undefined reference to `__cmpxchg_called_with_bad_pointer' hppa-linux-ld: (.text+0x354): undefined reference to `__cmpxchg_called_with_bad_pointer' Add support for cmpxchg on u8 pointers. [1] https://lore.kernel.org/patchwork/patch/1272617/#1468946 Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Liam Beguin <liambeguin@gmail.com> Tested-by: Dave Anglin <dave.anglin@bell.net> Signed-off-by: Helge Deller <deller@gmx.de> Signed-off-by: Sasha Levin <sashal@kernel.org>
94 lines
2.0 KiB
C
94 lines
2.0 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* bitops.c: atomic operations which got too long to be inlined all over
|
|
* the place.
|
|
*
|
|
* Copyright 1999 Philipp Rumpf (prumpf@tux.org)
|
|
* Copyright 2000 Grant Grundler (grundler@cup.hp.com)
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/spinlock.h>
|
|
#include <linux/atomic.h>
|
|
|
|
#ifdef CONFIG_SMP
|
|
arch_spinlock_t __atomic_hash[ATOMIC_HASH_SIZE] __lock_aligned = {
|
|
[0 ... (ATOMIC_HASH_SIZE-1)] = __ARCH_SPIN_LOCK_UNLOCKED
|
|
};
|
|
#endif
|
|
|
|
#ifdef CONFIG_64BIT
|
|
unsigned long __xchg64(unsigned long x, unsigned long *ptr)
|
|
{
|
|
unsigned long temp, flags;
|
|
|
|
_atomic_spin_lock_irqsave(ptr, flags);
|
|
temp = *ptr;
|
|
*ptr = x;
|
|
_atomic_spin_unlock_irqrestore(ptr, flags);
|
|
return temp;
|
|
}
|
|
#endif
|
|
|
|
unsigned long __xchg32(int x, int *ptr)
|
|
{
|
|
unsigned long flags;
|
|
long temp;
|
|
|
|
_atomic_spin_lock_irqsave(ptr, flags);
|
|
temp = (long) *ptr; /* XXX - sign extension wanted? */
|
|
*ptr = x;
|
|
_atomic_spin_unlock_irqrestore(ptr, flags);
|
|
return (unsigned long)temp;
|
|
}
|
|
|
|
|
|
unsigned long __xchg8(char x, char *ptr)
|
|
{
|
|
unsigned long flags;
|
|
long temp;
|
|
|
|
_atomic_spin_lock_irqsave(ptr, flags);
|
|
temp = (long) *ptr; /* XXX - sign extension wanted? */
|
|
*ptr = x;
|
|
_atomic_spin_unlock_irqrestore(ptr, flags);
|
|
return (unsigned long)temp;
|
|
}
|
|
|
|
|
|
u64 __cmpxchg_u64(volatile u64 *ptr, u64 old, u64 new)
|
|
{
|
|
unsigned long flags;
|
|
u64 prev;
|
|
|
|
_atomic_spin_lock_irqsave(ptr, flags);
|
|
if ((prev = *ptr) == old)
|
|
*ptr = new;
|
|
_atomic_spin_unlock_irqrestore(ptr, flags);
|
|
return prev;
|
|
}
|
|
|
|
unsigned long __cmpxchg_u32(volatile unsigned int *ptr, unsigned int old, unsigned int new)
|
|
{
|
|
unsigned long flags;
|
|
unsigned int prev;
|
|
|
|
_atomic_spin_lock_irqsave(ptr, flags);
|
|
if ((prev = *ptr) == old)
|
|
*ptr = new;
|
|
_atomic_spin_unlock_irqrestore(ptr, flags);
|
|
return (unsigned long)prev;
|
|
}
|
|
|
|
u8 __cmpxchg_u8(volatile u8 *ptr, u8 old, u8 new)
|
|
{
|
|
unsigned long flags;
|
|
u8 prev;
|
|
|
|
_atomic_spin_lock_irqsave(ptr, flags);
|
|
if ((prev = *ptr) == old)
|
|
*ptr = new;
|
|
_atomic_spin_unlock_irqrestore(ptr, flags);
|
|
return prev;
|
|
}
|