7fabffed53
commit 9629dbdabd1983ef53f125336e1d62d77b1620f9 upstream.
The syscon_regmap_lookup_by_phandle() will never return NULL, thus use
IS_ERR() to validate the return value instead of IS_ERR_OR_NULL().
Fixes: d41f59fd92 ("clk: sprd: Add common infrastructure")
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Link: https://lkml.kernel.org/r/1995139bee5248ff3e9d46dc715968f212cfc4cc.1570520268.git.baolin.wang@linaro.org
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
103 lines
2.2 KiB
C
103 lines
2.2 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
//
|
|
// Spreadtrum clock infrastructure
|
|
//
|
|
// Copyright (C) 2017 Spreadtrum, Inc.
|
|
// Author: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
|
|
|
|
#include <linux/mfd/syscon.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of_address.h>
|
|
#include <linux/of_platform.h>
|
|
#include <linux/regmap.h>
|
|
|
|
#include "common.h"
|
|
|
|
static const struct regmap_config sprdclk_regmap_config = {
|
|
.reg_bits = 32,
|
|
.reg_stride = 4,
|
|
.val_bits = 32,
|
|
.max_register = 0xffff,
|
|
.fast_io = true,
|
|
};
|
|
|
|
static void sprd_clk_set_regmap(const struct sprd_clk_desc *desc,
|
|
struct regmap *regmap)
|
|
{
|
|
int i;
|
|
struct sprd_clk_common *cclk;
|
|
|
|
for (i = 0; i < desc->num_clk_clks; i++) {
|
|
cclk = desc->clk_clks[i];
|
|
if (!cclk)
|
|
continue;
|
|
|
|
cclk->regmap = regmap;
|
|
}
|
|
}
|
|
|
|
int sprd_clk_regmap_init(struct platform_device *pdev,
|
|
const struct sprd_clk_desc *desc)
|
|
{
|
|
void __iomem *base;
|
|
struct device_node *node = pdev->dev.of_node;
|
|
struct regmap *regmap;
|
|
struct resource *res;
|
|
|
|
if (of_find_property(node, "sprd,syscon", NULL)) {
|
|
regmap = syscon_regmap_lookup_by_phandle(node, "sprd,syscon");
|
|
if (IS_ERR(regmap)) {
|
|
pr_err("%s: failed to get syscon regmap\n", __func__);
|
|
return PTR_ERR(regmap);
|
|
}
|
|
} else {
|
|
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
base = devm_ioremap_resource(&pdev->dev, res);
|
|
if (IS_ERR(base))
|
|
return PTR_ERR(base);
|
|
|
|
regmap = devm_regmap_init_mmio(&pdev->dev, base,
|
|
&sprdclk_regmap_config);
|
|
if (IS_ERR(regmap)) {
|
|
pr_err("failed to init regmap\n");
|
|
return PTR_ERR(regmap);
|
|
}
|
|
}
|
|
|
|
sprd_clk_set_regmap(desc, regmap);
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL_GPL(sprd_clk_regmap_init);
|
|
|
|
int sprd_clk_probe(struct device *dev, struct clk_hw_onecell_data *clkhw)
|
|
{
|
|
int i, ret;
|
|
struct clk_hw *hw;
|
|
|
|
for (i = 0; i < clkhw->num; i++) {
|
|
const char *name;
|
|
|
|
hw = clkhw->hws[i];
|
|
if (!hw)
|
|
continue;
|
|
|
|
name = hw->init->name;
|
|
ret = devm_clk_hw_register(dev, hw);
|
|
if (ret) {
|
|
dev_err(dev, "Couldn't register clock %d - %s\n",
|
|
i, name);
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
ret = devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, clkhw);
|
|
if (ret)
|
|
dev_err(dev, "Failed to add clock provider\n");
|
|
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL_GPL(sprd_clk_probe);
|
|
|
|
MODULE_LICENSE("GPL v2");
|