android_kernel_xiaomi_sm8350/fs/erofs
Gao Xiang eff9f8bc09
BACKPORT: erofs: fix lz4 inplace decompression
commit 3c12466b6b7bf1e56f9b32c366a3d83d87afb4de upstream.

Currently EROFS can map another compressed buffer for inplace
decompression, that was used to handle the cases that some pages of
compressed data are actually not in-place I/O.

However, like most simple LZ77 algorithms, LZ4 expects the compressed
data is arranged at the end of the decompressed buffer and it
explicitly uses memmove() to handle overlapping:
  __________________________________________________________
 |_ direction of decompression --> ____ |_ compressed data _|

Although EROFS arranges compressed data like this, it typically maps two
individual virtual buffers so the relative order is uncertain.
Previously, it was hardly observed since LZ4 only uses memmove() for
short overlapped literals and x86/arm64 memmove implementations seem to
completely cover it up and they don't have this issue.  Juhyung reported
that EROFS data corruption can be found on a new Intel x86 processor.
After some analysis, it seems that recent x86 processors with the new
FSRM feature expose this issue with "rep movsb".

Let's strictly use the decompressed buffer for lz4 inplace
decompression for now.  Later, as an useful improvement, we could try
to tie up these two buffers together in the correct order.

Reported-and-tested-by: Juhyung Park <qkrwngud825@gmail.com>
Closes: https://lore.kernel.org/r/CAD14+f2AVKf8Fa2OO1aAUdDNTDsVzzR6ctU_oJSmTyd6zSYR2Q@mail.gmail.com
Fixes: 0ffd71bcc3 ("staging: erofs: introduce LZ4 decompression inplace")
Fixes: 598162d05080 ("erofs: support decompress big pcluster for lz4 backend")
Cc: stable <stable@vger.kernel.org> # 5.4+
Tested-by: Yifan Zhao <zhaoyifan@sjtu.edu.cn>
Change-Id: Ib7a578283e33f0329ae2133223878ddf0738aba4
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Link: https://lore.kernel.org/r/20231206045534.3920847-1-hsiangkao@linux.alibaba.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[mkbestas: Adapt for android <=5.4 kernel which contains backports that
           caused various conflicts]
Signed-off-by: Michael Bestas <mkbestas@lineageos.org>
2024-04-16 16:57:37 +03:00
..
compress.h erofs: clean up file headers & footers 2024-04-16 16:57:37 +03:00
data.c erofs: clean up file headers & footers 2024-04-16 16:57:37 +03:00
decompressor.c BACKPORT: erofs: fix lz4 inplace decompression 2024-04-16 16:57:37 +03:00
dir.c erofs: clean up file headers & footers 2024-04-16 16:57:37 +03:00
erofs_fs.h erofs: clean up file headers & footers 2024-04-16 16:57:37 +03:00
inode.c erofs: clean up file headers & footers 2024-04-16 16:57:37 +03:00
internal.h erofs: clean up file headers & footers 2024-04-16 16:57:37 +03:00
Kconfig BACKPORT: erofs: add per-cpu threads for decompression as an option 2024-04-16 16:57:36 +03:00
Makefile UPSTREAM: erofs: introduce multipage per-CPU buffers 2024-04-16 16:57:33 +03:00
namei.c erofs: clean up file headers & footers 2024-04-16 16:57:37 +03:00
pcpubuf.c UPSTREAM: erofs: introduce multipage per-CPU buffers 2024-04-16 16:57:33 +03:00
super.c erofs: clean up file headers & footers 2024-04-16 16:57:37 +03:00
tagptr.h erofs: clean up file headers & footers 2024-04-16 16:57:37 +03:00
utils.c erofs: clean up file headers & footers 2024-04-16 16:57:37 +03:00
xattr.c erofs: clean up file headers & footers 2024-04-16 16:57:37 +03:00
xattr.h erofs: clean up file headers & footers 2024-04-16 16:57:37 +03:00
zdata.c erofs: clean up file headers & footers 2024-04-16 16:57:37 +03:00
zdata.h erofs: clean up file headers & footers 2024-04-16 16:57:37 +03:00
zmap.c erofs: clean up file headers & footers 2024-04-16 16:57:37 +03:00
zpvec.h erofs: clean up file headers & footers 2024-04-16 16:57:37 +03:00