efc557570d
xfs_fs_vcmn_err can be called under a spinlock, but does a sleeping memory allocation to create buffer for it's internal sprintf. Fortunately it's the only caller of icmn_err, so we can merge the two and have one single static buffer and spinlock protecting it. While we're at it make sure we proper __attribute__ format annotations so that the compiler can detect mismatched format strings. Reported-by: Alexander Beregalov <a.beregalov@gmail.com> Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Eric Sandeen <sandeen@sandeen.net> Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
73 lines
2.2 KiB
C
73 lines
2.2 KiB
C
/*
|
|
* Copyright (c) 2000-2005 Silicon Graphics, Inc.
|
|
* All Rights Reserved.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it would be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write the Free Software Foundation,
|
|
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
#ifndef __XFS_SUPPORT_DEBUG_H__
|
|
#define __XFS_SUPPORT_DEBUG_H__
|
|
|
|
#include <stdarg.h>
|
|
|
|
#define CE_DEBUG 7 /* debug */
|
|
#define CE_CONT 6 /* continuation */
|
|
#define CE_NOTE 5 /* notice */
|
|
#define CE_WARN 4 /* warning */
|
|
#define CE_ALERT 1 /* alert */
|
|
#define CE_PANIC 0 /* panic */
|
|
|
|
extern void cmn_err(int, char *, ...)
|
|
__attribute__ ((format (printf, 2, 3)));
|
|
extern void assfail(char *expr, char *f, int l);
|
|
|
|
#define ASSERT_ALWAYS(expr) \
|
|
(unlikely(expr) ? (void)0 : assfail(#expr, __FILE__, __LINE__))
|
|
|
|
#ifndef DEBUG
|
|
#define ASSERT(expr) ((void)0)
|
|
|
|
#ifndef STATIC
|
|
# define STATIC static noinline
|
|
#endif
|
|
|
|
#ifndef STATIC_INLINE
|
|
# define STATIC_INLINE static inline
|
|
#endif
|
|
|
|
#else /* DEBUG */
|
|
|
|
#define ASSERT(expr) \
|
|
(unlikely(expr) ? (void)0 : assfail(#expr, __FILE__, __LINE__))
|
|
|
|
#ifndef STATIC
|
|
# define STATIC noinline
|
|
#endif
|
|
|
|
/*
|
|
* We stop inlining of inline functions in debug mode.
|
|
* Unfortunately, this means static inline in header files
|
|
* get multiple definitions, so they need to remain static.
|
|
* This then gives tonnes of warnings about unused but defined
|
|
* functions, so we need to add the unused attribute to prevent
|
|
* these spurious warnings.
|
|
*/
|
|
#ifndef STATIC_INLINE
|
|
# define STATIC_INLINE static __attribute__ ((unused)) noinline
|
|
#endif
|
|
|
|
#endif /* DEBUG */
|
|
|
|
|
|
#endif /* __XFS_SUPPORT_DEBUG_H__ */
|