521594442c
This fixes a bug caused by changing pointers (viafb_mode, viafb_mode1) assigned by module_param. It reduces driver complexity by not needlessly changing these vars as they are only read once and removing now superfluous code. On unpatched kernels loading viafb with viafb_mode or viafb_mode1 option used and afterwards unloading it results in: kernel BUG at mm/slub.c:2926! invalid opcode: 0000 [#1] PREEMPT last sysfs file: /sys/devices/virtual/block/loop0/removable Modules linked in: snd_hda_codec_realtek snd_hda_intel snd_hda_codec snd_hwdep snd_pcm rtl8187 snd_timer eeprom_93cx6 mmc_block snd soundcore via_sdmmc fb snd_page_alloc i2c_algo_bit i2c_viapro ehci_hcd uhci_hcd cfbcopyarea mmc_core cfbimgblt cfbfillrect video output [last unloaded: viafb] Pid: 3355, comm: rmmod Not tainted (2.6.31-rc1 #0) EIP: 0060:[<c106a759>] EFLAGS: 00010246 CPU: 0 EIP is at kfree+0x80/0xda EAX: c17c2da0 EBX: dc7edbdc ECX: 0000010f EDX: 00000000 ESI: c102c700 EDI: dc7ed8fa EBP: d703ff2c ESP: d703ff20 DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068 Process rmmod (pid: 3355, ti=d703e000 task=db1412c0 task.ti=d703e000) Stack: dc7edbdc 00000014 00000016 d703ff40 c102c700 dc7f45d4 dc7f45d4 00000880 d703ff4c c103e571 00000000 d703ffac c103e751 66616976 da140062 db89ba80 00000328 d702edf8 db89ba80 d703ff9c c105d0f0 00000200 da14f898 00000014 Call Trace: [<c102c700>] ? destroy_params+0x1e/0x2b [<c103e571>] ? free_module+0xa2/0xd7 [<c103e751>] ? sys_delete_module+0x1ab/0x1da [<c105d0f0>] ? do_munmap+0x20a/0x225 [<c10029b4>] ? sysenter_do_call+0x12/0x26 Code: 10 76 7a 8d 87 00 00 00 40 c1 e8 0c c1 e0 05 03 05 1c 87 41 c1 66 83 38 00 79 03 8b 40 0c 8b 10 84 d2 78 12 66 f7 c2 00 c0 75 04 <0f> 0b eb fe e8 6f 5a fe ff eb 47 8b 55 04 8b 58 0c 9c 5e fa 3b EIP: [<c106a759>] kfree+0x80/0xda SS:ESP 0068:d703ff20 This is caused by the current code changing the pointers assigned by module_param. During unload it tries to free the memory the pointers point at which is now part of an internal structure. The patch simply avoids changing the pointers. This is okay as they are read only once during the initialization process. Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de> Cc: Scott Fang <ScottFang@viatech.com.cn> Cc: Joseph Chan <JosephChan@via.com.tw> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
112 lines
3.5 KiB
C
112 lines
3.5 KiB
C
/*
|
|
* Copyright 1998-2008 VIA Technologies, Inc. All Rights Reserved.
|
|
* Copyright 2001-2008 S3 Graphics, Inc. All Rights Reserved.
|
|
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation;
|
|
* either version 2, or (at your option) any later version.
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTIES OR REPRESENTATIONS; without even
|
|
* the implied warranty of MERCHANTABILITY or FITNESS FOR
|
|
* A PARTICULAR PURPOSE.See the GNU General Public License
|
|
* for more details.
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc.,
|
|
* 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
|
|
*/
|
|
|
|
#ifndef __VIAFBDEV_H__
|
|
#define __VIAFBDEV_H__
|
|
|
|
#include <linux/proc_fs.h>
|
|
#include <linux/fb.h>
|
|
|
|
#include "ioctl.h"
|
|
#include "share.h"
|
|
#include "chip.h"
|
|
#include "hw.h"
|
|
#include "via_i2c.h"
|
|
|
|
#define VERSION_MAJOR 2
|
|
#define VERSION_KERNEL 6 /* For kernel 2.6 */
|
|
|
|
#define VERSION_OS 0 /* 0: for 32 bits OS, 1: for 64 bits OS */
|
|
#define VERSION_MINOR 4
|
|
|
|
struct viafb_par {
|
|
int bpp;
|
|
int hres;
|
|
int vres;
|
|
int linelength;
|
|
u32 xoffset;
|
|
u32 yoffset;
|
|
|
|
void __iomem *fbmem_virt; /*framebuffer virtual memory address */
|
|
void __iomem *io_virt; /*iospace virtual memory address */
|
|
unsigned int fbmem; /*framebuffer physical memory address */
|
|
unsigned int memsize; /*size of fbmem */
|
|
unsigned int io; /*io space address */
|
|
unsigned long mmio_base; /*mmio base address */
|
|
unsigned long mmio_len; /*mmio base length */
|
|
u32 fbmem_free; /* Free FB memory */
|
|
u32 fbmem_used; /* Use FB memory size */
|
|
u32 cursor_start; /* Cursor Start Address */
|
|
u32 VQ_start; /* Virtual Queue Start Address */
|
|
u32 VQ_end; /* Virtual Queue End Address */
|
|
u32 iga_path;
|
|
struct proc_dir_entry *proc_entry; /*viafb proc entry */
|
|
u8 duoview; /*Is working in duoview mode? */
|
|
|
|
/* I2C stuff */
|
|
struct via_i2c_stuff i2c_stuff;
|
|
|
|
/* All the information will be needed to set engine */
|
|
struct tmds_setting_information *tmds_setting_info;
|
|
struct crt_setting_information *crt_setting_info;
|
|
struct lvds_setting_information *lvds_setting_info;
|
|
struct lvds_setting_information *lvds_setting_info2;
|
|
struct chip_information *chip_info;
|
|
|
|
/* some information related to video playing */
|
|
int video_on_crt;
|
|
int video_on_dvi;
|
|
int video_on_lcd;
|
|
|
|
};
|
|
struct viafb_modeinfo {
|
|
u32 xres;
|
|
u32 yres;
|
|
int mode_index;
|
|
};
|
|
extern unsigned int viafb_second_virtual_yres;
|
|
extern unsigned int viafb_second_virtual_xres;
|
|
extern unsigned int viafb_second_offset;
|
|
extern int viafb_second_size;
|
|
extern int viafb_SAMM_ON;
|
|
extern int viafb_dual_fb;
|
|
extern int viafb_LCD2_ON;
|
|
extern int viafb_LCD_ON;
|
|
extern int viafb_DVI_ON;
|
|
extern int viafb_accel;
|
|
extern int viafb_hotplug;
|
|
extern int viafb_memsize;
|
|
|
|
extern int strict_strtoul(const char *cp, unsigned int base,
|
|
unsigned long *res);
|
|
|
|
void viafb_memory_pitch_patch(struct fb_info *info);
|
|
void viafb_fill_var_timing_info(struct fb_var_screeninfo *var, int refresh,
|
|
int mode_index);
|
|
int viafb_get_mode_index(int hres, int vres);
|
|
u8 viafb_gpio_i2c_read_lvds(struct lvds_setting_information
|
|
*plvds_setting_info, struct lvds_chip_information
|
|
*plvds_chip_info, u8 index);
|
|
void viafb_gpio_i2c_write_mask_lvds(struct lvds_setting_information
|
|
*plvds_setting_info, struct lvds_chip_information
|
|
*plvds_chip_info, struct IODATA io_data);
|
|
#endif /* __VIAFBDEV_H__ */
|